fix(ci)_: fetch gomobile deps #6625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (36)
|
siddarthkay
force-pushed
the
fix-statusgo-android-build
branch
from
5f846dc to
17b4735
Compare
markoburcul
approved these changes
Jun 4, 2025
jakubgs
approved these changes
Jun 4, 2025
Makefile
Outdated
Comment on lines
187
to
188
| export GO111MODULE=on; \ | ||
| export GOFLAGS="-mod=mod" \ |
There was a problem hiding this comment.
What's the point of this indent? Also you don't need two exports:
Suggested change
| export GO111MODULE=on; \ | |
| export GOFLAGS="-mod=mod" \ | |
| export GO111MODULE=on GOFLAGS="-mod=mod"; \ |
There was a problem hiding this comment.
ah sorry, i fucked up indents trying to get this PR out quickly.
will fix.
siddarthkay
force-pushed
the
fix-statusgo-android-build
branch
from
17b4735 to
cae58ee
Compare
Otherwise CI builds were failing with : ``` github.com/status-im/status-go/mobile/requests github.com/status-im/status-go/server/pairing/preflight github.com/status-im/status-go/mobile gobind/gobind gobind/gobind /nix/store/9cimpd18hk5dly63v76nwjdfc6h284bm-gomobile-0-unstable-2024-12-13/bin/gomobile: open build/bin/statusgo.aar: no such file or directory make: *** [Makefile:186: statusgo-android] Error 1 ``` failing CI job : https://ci.status.im/blue/organizations/jenkins/status-go%2Fprs%2Fandroid/detail/PR-6612/13/pipeline/ I tried to build manually on `linux-02` and got the same failure, also this build directory was absent. ``` bash-5.2$ ls -la build/ 2>/dev/null || echo "build directory doesn't exist" build directory doesn't exist ``` also fixes : #6579
siddarthkay
force-pushed
the
fix-statusgo-android-build
branch
from
cae58ee to
ff46c74
Compare
siddarthkay
changed the title
siddarthkay
force-pushed
the
fix-statusgo-android-build
branch
from
9172db3 to
b779de9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6625 +/- ##
===========================================
+ Coverage 60.44% 60.50% +0.06%
===========================================
Files 837 837
Lines 104244 104244
===========================================
+ Hits 63006 63073 +67
+ Misses 33661 33618 -43
+ Partials 7577 7553 -24
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise CI builds were failing with :
failing CI job : https://ci.status.im/blue/organizations/jenkins/status-go%2Fprs%2Fandroid/detail/PR-6612/13/pipeline/
I tried to build manually on
linux-02and got the same failure, also this build directory was absent.also fixes : #6579