Skip to content

Commit

Permalink
Gradle: drop unavailable JCenter Bintray from config
Browse files Browse the repository at this point in the history
This repository has been shut down a year ago:

* https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
* https://testfairy.com/blog/jcenter-and-bintray-is-shutting-down-what-to-do/

And yet we still keep references to it in the Gradle config.

Resolves: #13320

Signed-off-by: Jakub Sokołowski <jakub@status.im>
  • Loading branch information
jakubgs committed May 4, 2022
1 parent 411fd84 commit 13f3198
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 17 deletions.
22 changes: 7 additions & 15 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@ buildscript {
repositories {
flatDir { dirs "libs", "${rootDir}/app/libs" }
google()
jcenter()
}
dependencies {
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.31"
classpath "com.android.tools.build:gradle:${project.ext.gradlePluginVersion}"
classpath "com.google.gms:google-services:4.3.10"
classpath "com.google.gms:google-services:4.3.10"
// WARNING: Do not place your application dependencies here!
// They belong in the individual module build.gradle files.
}
Expand Down Expand Up @@ -51,21 +50,14 @@ allprojects {
}

repositories {
mavenLocal()
maven {
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
url("$rootDir/../node_modules/react-native/android")
}
maven {
// Android JSC is installed from npm
url("$rootDir/../node_modules/jsc-android/dist")
}

google()
jcenter()

mavenLocal()
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
maven { url("$rootDir/../node_modules/react-native/android") }
// Android JSC is installed from npm
maven { url("$rootDir/../node_modules/jsc-android/dist") }
maven { url "https://www.jitpack.io" }
// for geth, function, and status-go
flatDir { dirs "libs", System.env.STATUS_GO_ANDROID_LIBDIR }
maven { url "https://www.jitpack.io" }
}
}
2 changes: 1 addition & 1 deletion nix/deps/nodejs-patched/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Modules provided by `yarn2nix` are normally fine, but we use `react-native-*` pa
```js
repositories {
google()
jcenter()
maven { url "https://www.jitpack.io" }
}
```
And these need to be patched and replaced with `mavenLocal()` to make sure Gradle doesn't try to fetch dependencies from remote repos.
Expand Down
1 change: 0 additions & 1 deletion nix/pkgs/patch-maven-srcs/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@ writeScript "patch-maven-srcs" (''
# Some of those find something, some don't, that's fine.
patchMavenSource "$gradleFile" 'mavenCentral()' 'mavenLocal()'
patchMavenSource "$gradleFile" 'google()' 'mavenLocal()'
patchMavenSource "$gradleFile" 'jcenter()' 'mavenLocal()'
'')

0 comments on commit 13f3198

Please sign in to comment.