Change App ID for PR builds of iOS app

A successor to #7479

Signed-off-by: Jakub Sokołowski <jakub@status.im>

ci/ios.groovy

@@ -2,9 +2,7 @@ nix = load('ci/nix.groovy')
 utils = load('ci/utils.groovy')
 
 def plutil(name, value) {
-  return """
-  plutil -replace ${name} -string ${value} ios/StatusIm/Info.plist;
-"""
+  return "plutil -replace ${name} -string ${value} ios/StatusIm/Info.plist;"
 }
 
 def bundle() {
@@ -14,7 +12,7 @@ def bundle() {
     case 'release':     target = 'release'; break;
     case 'testflight':  target = 'release'; break;
     case 'e2e':         target = 'e2e';     break;
-    default:            target = 'nightly';
+    default:            target = 'pr';
   }
   /* configure build metadata */
   nix.shell(

fastlane/Fastfile

@@ -149,7 +149,11 @@ def build_ios_e2e
         # ...and we don't need an .ipa file for them, because we use .app directly
         skip_package_ipa: true,
         export_options: {
-            "UseModernBuildSystem": "N"
+            UseModernBuildSystem: "N",
+            provisioningProfiles: { 
+              "im.status.ethereum": "match AdHoc im.status.ethereum",
+              "im.status.ethereum.pr" => "match AdHoc im.status.ethereum.pr",
+            }
         }
     )
 
@@ -191,11 +195,25 @@ platform :ios do
 
   desc "`fastlane ios pr` - makes a new pr build"
   desc "This lane builds a new adhoc build and leaves an .ipa that is ad-hoc signed (can be uploaded to diawi)"
+  desc "It changes two parameters to avoid overriding releases:"
+  desc " - `CFBundleDisplayName` - `Status PR`"
+  desc " - `CFBundleIdentifier` - `im.status.ethereum.pr`"
   lane :pr do
     unlock_keychain_if_needed
+    update_app_identifier(
+      app_identifier: 'im.status.ethereum.pr',
+      plist_path: 'StatusIm/Info.plist',
+      xcodeproj: 'ios/StatusIm.xcodeproj'
+    )
+    update_info_plist(
+      display_name: 'Status PR',
+      plist_path: 'StatusIm/Info.plist',
+      xcodeproj: 'ios/StatusIm.xcodeproj'
+    )
     build_ios_adhoc(false)
   end
 
+
   desc "`fastlane ios nightly` - makes a new nightly"
   desc "This lane builds a new nightly and leaves an .ipa that is ad-hoc signed (can be uploaded to diawi)"
   lane :nightly do