Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser: Improve typed message display #12098

Closed
alfetopito opened this issue May 7, 2021 · 0 comments
Closed

Browser: Improve typed message display #12098

alfetopito opened this issue May 7, 2021 · 0 comments
Labels
feature feature requests

Comments

@alfetopito
Copy link

Feature Issue

User Story

As a user, I want to see a nicely formatted structured data when signing messages so that I can easily see what I am signing.

Description

Summary: Right now, signature request of type eth_signTypedData_v4 and eth_signTypedData_v3 display the raw JSON data, which is not very clear for the user point of view.

This issue applies to the Mobile app (I personally only tested the Android version, but would assume the same applies to iOS) dApp browser, when a dApp requests the user signature using the aforementioned methods.

(I would share an app screenshot here, but it's disabled in the Playstore version)

This is for example how Metamask display such kind of signature requests:
screenshot_2021-05-07_09-43-53

Acceptance Criteria

I'll leave this up to the maintainers

Notes

This issue is related to #12097
I would say that has a higher priority since typed data signature are not working at the moment.

@alfetopito alfetopito added the feature feature requests label May 7, 2021
@churik churik changed the title Improve typed message display Browser: Improve typed message display Sep 22, 2021
@churik churik added the dapp label Sep 22, 2021
@status-im status-im locked and limited conversation to collaborators Sep 22, 2021
@churik churik closed this as completed Sep 22, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

2 participants