Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Horizontal frames are not centered within the camera box and a bulge appears at the end of the frame line #16278

Closed
VolodLytvynenko opened this issue Jun 14, 2023 · 3 comments
Closed

[Android] Horizontal frames are not centered within the camera box and a bulge appears at the end of the frame line #16278

VolodLytvynenko opened this issue Jun 14, 2023 · 3 comments
Labels
low-prio

Comments

@VolodLytvynenko
Copy link
Contributor

follow up for #16206 (comment)
Related to comment https://www.figma.com/file/Tf5nfkYvpbnNCo4rKLK7lS/Feedback-for-Mobile?type=design&node-id=1929-154137#429224561

Steps to reproduce:

  1. Open 'Sign in by syncing' page
  2. Enable the camera

Actual result:

  • The horizontal frames are not in the middle of the camera box
  • Bulge is shown at the end of the frame lines
    image

Expected result:

  • Framing lines should be in the middle of the camera box
  • The end points has to be round, not flat
    image

Device:

  • Real device: Pixel 7a, Android 13
  • Android Emulator: Pixel 6 API 31. v12
@jo-mut jo-mut self-assigned this Jun 14, 2023
@VolodLytvynenko
Copy link
Contributor Author

how it looks on Android Emulator: Pixel 6 API 31. v12

frames.mp4

@VolodLytvynenko VolodLytvynenko mentioned this issue Jun 14, 2023
Merged
@jo-mut jo-mut removed their assignment Jun 19, 2023
@ulisesmac ulisesmac self-assigned this Jul 12, 2023
@cammellos cammellos added bug and removed bug labels Jul 14, 2023
@ulisesmac ulisesmac mentioned this issue Jul 18, 2023
Merged
ulisesmac added a commit that referenced this issue Jul 26, 2023
@ulisesmac
[#16278] fix tips in white camera border (#16716)
4f04476 
* Remove unnecessary wrapper
* Fix border tips and refactor
* Add comment about using 1.9 width
@ulisesmac
Copy link
Contributor

White tips have been addressed, but still there's an issue with the alignment of the frame because of different device's DPI, I am not sure, but I think it's not possible to center for all devices.

Make sure to test in different devices while solving this issue, a comment about it: #16716 (comment)

@ulisesmac ulisesmac removed their assignment Jul 26, 2023
andresceballosm pushed a commit to andresceballosm/status-mobile that referenced this issue Aug 6, 2023
@ulisesmac @andresceballosm
[status-im#16278] fix tips in white camera border (status-im#16716)
236c7fa 
* Remove unnecessary wrapper
* Fix border tips and refactor
* Add comment about using 1.9 width
@churik
Copy link
Member

churik commented Jun 20, 2024

I think for now it is not a priority anymore, reopen if still relevant.

@churik churik closed this as completed Jun 20, 2024
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ilmotta @cammellos @churik @jo-mut @VolodLytvynenko @ulisesmac