Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥅 Dapps connected on Testnet should not be visible on the Dapps list page if the app is in mainnet mode (and vice-versa) #20794

Closed
shivekkhurana opened this issue Jul 18, 2024 · 0 comments
Closed

🥅 Dapps connected on Testnet should not be visible on the Dapps list page if the app is in mainnet mode (and vice-versa) #20794

shivekkhurana opened this issue Jul 18, 2024 · 0 comments
Assignees
@shivekkhurana
Labels
dapp-interactions
Milestone
2.31.0

Comments

@shivekkhurana
Copy link
Contributor

Bug Report

Problem

The Dapp's list screen for accounts lists all Wallet Connect connections (Testnet and mainnet) together. This is because we read from the Wallet Connect SDK, and it doesn't filter based on chains.

But in our database, we maintain a list of connections by testnet and mainnet.

Expected behavior

  1. When the app is in testnet, only testnet wallet connections should show on the Dapps List screen
  2. When the app is in mainnet, only mainnet wallet connections should show on the Dapps List screen

Actual behavior

  1. Regardless of mainnet or testnet mode in the app, all Wallet Connect connections show on the Dapps List Screen.

Reproduction

  1. Connect to a mainnet app (Uniswap)
  2. Connect to a testnet app (Wallet Connect Sample)
  3. Put the app in Testnet mode, both connections are visible on Dapps List Screen
  4. Turn off Testnet mode, still both connections are visible on Dapps List Screen
@shivekkhurana shivekkhurana self-assigned this Jul 18, 2024
@clauxx clauxx added this to the 2.30.0 Beta milestone Jul 18, 2024
shivekkhurana added a commit that referenced this issue Jul 18, 2024
@shivekkhurana
🥅 Filter connected dapps based on testnet mode
27ee3fd 
- Fixes #20794
@shivekkhurana shivekkhurana mentioned this issue Jul 18, 2024
Merged
@shivekkhurana shivekkhurana moved this from In Progress to Code Review in Status Desktop/Mobile Board Jul 18, 2024
shivekkhurana added a commit that referenced this issue Jul 18, 2024
@shivekkhurana
🥅 Filter connected dapps based on testnet mode
b8a2a49 
- Fixes #20794
shivekkhurana added a commit that referenced this issue Jul 19, 2024
@shivekkhurana
🥅 Filter connected dapps based on testnet mode
a21da69 
- Fixes #20794
shivekkhurana added a commit that referenced this issue Jul 22, 2024
@shivekkhurana
🥅 Filter connected dapps based on testnet mode
ed40d37 
- Fixes #20794
shivekkhurana added a commit that referenced this issue Jul 24, 2024
@shivekkhurana
🥅 Filter connected dapps based on testnet mode
8608fca 
- Fixes #20794
shivekkhurana added a commit that referenced this issue Jul 25, 2024
@shivekkhurana
🥅 Filter connected dapps based on testnet mode
0f3e3fe 
- Fixes #20794
@clauxx clauxx moved this from Code Review to QA in Status Desktop/Mobile Board Jul 25, 2024
@qoqobolo qoqobolo mentioned this issue Jul 25, 2024
Merged
@churik churik modified the milestones: 2.30.0 Beta, 2.31.0 Beta Jul 25, 2024
shivekkhurana added a commit that referenced this issue Jul 25, 2024
@shivekkhurana
🥅 Filter connected dapps based on testnet mode
bedfaca 
- Fixes #20794
@shivekkhurana shivekkhurana linked a pull request Jul 25, 2024 that will close this issue
🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully #20799
Merged
@shivekkhurana shivekkhurana removed a link to a pull request Jul 25, 2024
🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully #20799
Merged
J-Son89 pushed a commit that referenced this issue Jul 26, 2024
@shivekkhurana @J-Son89
🥅 Filter connected dapps based on testnet mode, reject proposals and …
f04ed09 
…requests gracefully (#20799)

* 🥅 Filter connected dapps based on testnet mode

- Fixes #20794

* 🥅 Remove map, just filter

* 💿 Rebase

* ❌ Remove greedy fetch

* 🙅‍♀️ Properly reject proposals and requests

* 🎗️ Remove newline and move `set`

- `set` was applied at the wrong place here

* ✏️ Address review comments

* 👀 Read proposal to reject from state

* ◀️ Bring back network filtering

* 🧹 Cleanup

* ✏️ Move comment around

* 🎣 Use filter operable accounts helper

* ➕ Add back events deleted during rebase

* 🧰 Fix Issue 2, Testnet sessions not visible

* 🖊️ Fix lint

* 🔗 Make testnet filtering more explicit

* 🥢 Use union instead of two subsets call

* ✏️ Fix lint

* 🔇 Undo changes that creeped in an unrelated ns
ilmotta pushed a commit that referenced this issue Jul 28, 2024
@shivekkhurana @ilmotta
🥅 Filter connected dapps based on testnet mode, reject proposals and …
7571af1 
…requests gracefully (#20799)

* 🥅 Filter connected dapps based on testnet mode

- Fixes #20794

* 🥅 Remove map, just filter

* 💿 Rebase

* ❌ Remove greedy fetch

* 🙅‍♀️ Properly reject proposals and requests

* 🎗️ Remove newline and move `set`

- `set` was applied at the wrong place here

* ✏️ Address review comments

* 👀 Read proposal to reject from state

* ◀️ Bring back network filtering

* 🧹 Cleanup

* ✏️ Move comment around

* 🎣 Use filter operable accounts helper

* ➕ Add back events deleted during rebase

* 🧰 Fix Issue 2, Testnet sessions not visible

* 🖊️ Fix lint

* 🔗 Make testnet filtering more explicit

* 🥢 Use union instead of two subsets call

* ✏️ Fix lint

* 🔇 Undo changes that creeped in an unrelated ns
@shivekkhurana shivekkhurana mentioned this issue Jul 29, 2024
Closed
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivekkhurana shivekkhurana

Labels
dapp-interactions
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.31.0
Development

No branches or pull requests
4 participants
@ilmotta @shivekkhurana @churik @clauxx