Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🖊️⚙️ Implement Input and Validation for Max Base Fee and Priority Fee in Custom TX Parameters #21023

Open
2 tasks
vkjr opened this issue Aug 12, 2024 · 1 comment · May be fixed by #21838
Open
2 tasks

🖊️⚙️ Implement Input and Validation for Max Base Fee and Priority Fee in Custom TX Parameters #21023

vkjr opened this issue Aug 12, 2024 · 1 comment · May be fixed by #21838
Assignees
@vkjr
Labels
wallet: TX settings Send screen transaction settings (nonce, limits) wallet-core Issues for mobile wallet team
Milestone
2.33.0

Comments

@vkjr
Copy link
Contributor

vkjr commented Aug 12, 2024 •
edited by shivekkhurana
Loading

Feature

Implement max fees flow: https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=17671-228142&m=dev
Implement priority fee flow: https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=17671-229387&t=BUk6LX8HGnOk60xD-4

TBD

  • where to get current limits?

Implementation

Acceptance Criteria

  • There should be error messages if fees are incorrect
  • There should be a help section as shown in designs

Notes
@vkjr vkjr added the wallet: TX settings Send screen transaction settings (nonce, limits) label Aug 12, 2024
@vkjr vkjr added this to the 2.31.0 Beta milestone Aug 12, 2024
@vkjr vkjr mentioned this issue Aug 12, 2024
Open
1 task
@churik churik added the wallet-core Issues for mobile wallet team label Aug 28, 2024
@churik churik modified the milestones: 2.31.0 Beta, 2.32.0 Beta Sep 23, 2024
@shivekkhurana shivekkhurana changed the title Max fees screen, tx settings 🖊️⚙️ Implement Input and Validation for Max Base Fee and Priority Fee in Custom TX Parameters Nov 4, 2024
This was referenced Nov 4, 2024
Closed
Closed
Closed
Closed
@alwx alwx self-assigned this Nov 5, 2024
@churik
Copy link
Member

churik commented Nov 25, 2024

I do not think that it is feasible to include this feature to 2.32, postponing due to limited capacity in order to keep release scope clear

cc @shivekkhurana

@churik churik modified the milestones: 2.32.0, 2.33.0 Nov 25, 2024
@vkjr vkjr assigned vkjr and unassigned alwx Nov 25, 2024
@vkjr vkjr linked a pull request Dec 17, 2024 that will close this issue
Open
@vkjr vkjr moved this to Code Review in Status Desktop/Mobile Board Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkjr vkjr

Labels
wallet: TX settings Send screen transaction settings (nonce, limits) wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.33.0
Development

Successfully merging a pull request may close this issue.

Screens for editing transaction settings status-im/status-mobile
3 participants
@alwx @churik @vkjr