Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cannot read property" error is displayed on profiles list page when the Dapp attempts to send a signature #21853

Open
VolodLytvynenko opened this issue Dec 19, 2024 · 3 comments · May be fixed by #21873
Assignees
Labels
wallet-connect: Refinement Fixing bugs and assuring the quality of the Wallet Connect integration wallet-core Issues for mobile wallet team
Milestone

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Dec 19, 2024

Steps:

  1. Connect to the Dapp(in my case Uniswap) using universal scanner
  2. Log out
  3. Make any transaction Using Dapp (approve or swap)

Actual result:

A "cannot read property" error is displayed when the Dapp attempts to send a signature
Image

Expected result:

No errors are shown

There is another issue which might be related to current one. Please ping me up if the issues are unrelated and I will log a separate one.

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17

Logs

logs.zip

@VolodLytvynenko VolodLytvynenko added this to the 2.33.0 milestone Dec 19, 2024
@VolodLytvynenko VolodLytvynenko added wallet-connect: Refinement Fixing bugs and assuring the quality of the Wallet Connect integration mobile-core labels Dec 19, 2024
@VolodLytvynenko VolodLytvynenko moved this from Next to Backlog in Status Desktop/Mobile Board Dec 19, 2024
@ilmotta
Copy link
Contributor

ilmotta commented Dec 19, 2024

Just double-checking @VolodLytvynenko, is this issue really for mobile-core, or should it be wallet-core?

@VolodLytvynenko
Copy link
Contributor Author

Just double-checking @VolodLytvynenko, is this issue really for mobile-core, or should it be wallet-core?

@ilmotta Unfortunately, I can't reproduce this issue on desktop as the logic works differently.

  • On mobile, I can trigger the issue by logging out and triggering the signature via a Dapp while on the profile list.
  • On desktop, logging out just closes the app.
    I can reopen desktop and go to the profile list and trigger the signature, but the issue doesn't happen on either desktop or mobile in this case.

@ilmotta
Copy link
Contributor

ilmotta commented Dec 20, 2024

Thanks @VolodLytvynenko. In that case I think the best is to leave this issue to the wallet team @shivekkhurana. It seems there's some kind of listener which wasn't cleared up after logout, that's probably why the app still reacts to your action via the dapp even though you are not logged in.

@ilmotta ilmotta added wallet-core Issues for mobile wallet team and removed mobile-core labels Dec 20, 2024
@VolodLytvynenko VolodLytvynenko changed the title "cannot read property" error is displayed when the Dapp attempts to send a signature "cannot read property" error is displayed on profiles list page when the Dapp attempts to send a signature Dec 20, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this Dec 24, 2024
@mohsen-ghafouri mohsen-ghafouri moved this from Backlog to In Progress in Status Desktop/Mobile Board Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet-connect: Refinement Fixing bugs and assuring the quality of the Wallet Connect integration wallet-core Issues for mobile wallet team
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants