Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing message title overlaps phone status bar on some screens #8408

Closed
annadanchenko opened this issue Jun 12, 2019 · 0 comments · Fixed by #8539
Closed

Signing message title overlaps phone status bar on some screens #8408

annadanchenko opened this issue Jun 12, 2019 · 0 comments · Fixed by #8539

Comments

@annadanchenko
Copy link

annadanchenko commented Jun 12, 2019 •
edited by StatusWrike
Loading

Description

Type: Bug

Summary: In new signing flow: title and status bar overlap each other if sign message from Dapp on Galaxy S6, Pixel XL phones. In the same time on Pixel 3, Galaxy S10 it's shown fine. Found in #8361
Screenshot_20190612-120757

5.2" screen on Android
image

Expected behavior

no overlap

Actual behavior

title "Signing a message" and button Cancel overlap phone status bar with time, battery indicator
comment: # (Describe what actually happened.)

Reproduction

  • Open Status in Galaxy S6
  • Register in cryptoKitties or use Simple Test Dapp and sign a message
  • Check how top of the screen looks like

Additional Information

  • Status version: nightly after June 12
  • Operating System: Android and iOS
@annadanchenko annadanchenko changed the title Signing message title overlap phone status bar on some screens Signing message title overlaps phone status bar on some screens Jun 12, 2019
@flexsurfer flexsurfer self-assigned this Jun 14, 2019
@weekly-digest weekly-digest bot mentioned this issue Jun 16, 2019
Closed
flexsurfer added a commit that referenced this issue Jul 8, 2019
@flexsurfer
[#8506] [#8408] fixes signing panel
513a75e
@flexsurfer flexsurfer mentioned this issue Jul 8, 2019
Merged
flexsurfer added a commit that referenced this issue Jul 9, 2019
@flexsurfer
[#8506] [#8408] fixes signing panel
368eaf1 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#8506] [#8408] fixes signing panel status-im/status-mobile
3 participants
@annadanchenko @flexsurfer @rachelhamlin