Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Back up seed phrase' in Profile is present for recovered accounts #8938

Closed
Serhy opened this issue Sep 6, 2019 · 12 comments · Fixed by #9105
Closed

'Back up seed phrase' in Profile is present for recovered accounts #8938

Serhy opened this issue Sep 6, 2019 · 12 comments · Fixed by #9105
Assignees

Comments

@Serhy
Copy link
Contributor

Serhy commented Sep 6, 2019

Type: Bug

Summary: Back up seed phrase in Profile is present for recovered accounts. As well as after user backed up seed phrase еру Back up seed phrase is still present and it lands user to You're all set screen.
We need either to hide or disable Back up seed phrase option in Profile if it's not needed.

Expected behavior

No Back up seed phrase in user Profile for account which was recovered.
No Back up seed phrase in user Profile if it was already backed up.

Actual behavior

Back up seed phrase in user Profile for account which was recovered is present.
Back up seed phrase in user Profile is present if it was already backed up.

Screenshot 2019-09-06 at 16 47 52

Reproduction #1

  • Open Status
  • Recover any account
  • Navigate to Profile -> Privacy and Security

Reproduction #2

  • Open Status
  • Create new account
  • Navigate to Profile -> Privacy and security
  • Back up your seed phrase

Additional Information

  • Status version: Develop 0.14.0 (2019090603)
  • Operating System: Android and iOS
@gitcoinbot
Copy link

gitcoinbot commented Oct 3, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 2 years, 4 months ago.
Please review their action plans below:

1) acolytec3 has been approved to start work.

Identify where seed-phrase suppression is failing in privacy_and_security_settings views.cljs and correct.

Is there a preference for whether the whole backup seed phrase section is suppressed vs disabled?

Learn more on the Gitcoin Issue Details page.

@acolytec3
Copy link
Contributor

@rachelhamlin Initial PR is submitted so can submit on Gitcoin whenever you have time to approve. :-)

@acolytec3
Copy link
Contributor

acolytec3 commented Oct 7, 2019

@rachelhamlin Can you (or @StatusSceptre) approve me on Gitcoin so I can submit work on this PR given that the PR was just merged? Thanks!

@rachelhamlin
Copy link
Contributor

Done @acolytec3! Will add your 20 DAI tip for the other issue where I shorted you on here.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 60.0 DAI (60.0 USD @ $1.0/DAI) has been submitted by:

  1. @acolytec3

@StatusSceptre please take a look at the submitted work:


@acolytec3
Copy link
Contributor

@rachelhamlin, any chance I can get paid for this plus the other 20 from #8027 side the PR is merged?

@rachelhamlin
Copy link
Contributor

Definitely & thanks for reminder @acolytec3. Gitcoin is currently not recognizing that Metamask is unlocked so I'm blocked. Going to try again later and escalate if necessary.

@acolytec3
Copy link
Contributor

@rachelhamlin Any luck here with metamask?

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Oct 17, 2019

Hi @acolytec3 unfortunately I'm still blocked on Metamask. :/ But another colleague is able to get in, so he'll pay you for this one + tip for #8027.

Awesome work on #8960 too. I'll get help setting up a belated bounty there as well.

@acolytec3
Copy link
Contributor

acolytec3 commented Oct 17, 2019 via email

@gitcoinbot
Copy link

⚡️ A tip worth 80.00000 DAI (80.0 USD @ $1.0/DAI) has been granted to @acolytec3 for this issue from @StatusSceptre. ⚡️

Nice work @acolytec3! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This Bounty has been completed.

Additional Tips for this Bounty:

  • StatusSceptre tipped 80.0000 DAI worth 80.0 USD to acolytec3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants