Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer UI refresh #1103

Merged
merged 3 commits into from
May 26, 2017
Merged

Drawer UI refresh #1103

merged 3 commits into from
May 26, 2017

Conversation

GustavoNunes
Copy link
Contributor

@GustavoNunes GustavoNunes commented Apr 28, 2017 •
edited
Loading

Summary:

  • Larger drawer.
  • 2 most recent unsigned transactions, shortcut to transactions list.
  • Show current network.
  • Removed "Discover" and "Contacts" labels.
  • Removed "Shake your phone" text.
  • Switch accounts now under menu button in top.

status: ready

@GustavoNunes GustavoNunes self-assigned this Apr 28, 2017
@GustavoNunes GustavoNunes force-pushed the feature/drawer-ui-refresh branch 2 times, most recently from aa93522 to 53e465b Compare May 2, 2017 05:49
@GustavoNunes GustavoNunes requested a review from rasom May 2, 2017 05:54
@GustavoNunes
Copy link
Contributor Author

@rasom, this PR is ready.
@flexsurfer, I've added the current network ("Ropsten" hardcoded here), you can make this dynamic in your PR.

@flexsurfer
Copy link
Member

@GustavoNunes great, thanks

@rasom rasom changed the title [WIP] Drawer UI refresh Drawer UI refresh May 2, 2017
@annadanchenko
Copy link

app crashes on launching if use build Branch: feature/drawer-ui-refresh
iOS: https://i.diawi.com/sKkYgP

@annadanchenko
Copy link

annadanchenko commented May 13, 2017 •
edited
Loading

@GustavoNunes there are some differences with design (example is for iOS but same applies to Android except point 3: there is no separator lines between transactions in Android design):

  1. no blue background is shown
  2. no date
  3. no separator lines between transactions
    ios drawer compare

@GustavoNunes
Copy link
Contributor Author

@annadanchenko I fixed these issues, thank you!

@annadanchenko
Copy link

annadanchenko commented May 23, 2017 •
edited
Loading

@GustavoNunes Thanks! I'm still in progress of testing (waiting when Wallet will get some ether from faucet). However, there is some difference in time format. Currently, it shows 10:19 (no PM/AM) while it's 22:19.
img_1531

I also see that in previous PR build there was 13:02, so it was OK there. To get the exact transaction:

  • open Auction house DApp
  • tap on Create an Auction
  • in 1st editbox "Name to reserve" type any title.eth and tap on Register name (to get ransaction of 0 ETH)
  • as soon as transaction is created open Profile
    It happens both in iOS and Android

@GustavoNunes
Copy link
Contributor Author

@annadanchenko Fixed, thanks!

@annadanchenko
Copy link

annadanchenko commented May 25, 2017 •
edited
Loading

@GustavoNunes Changes look good! I found that both design and implementation on Android have regular font for User Name instead of Medium font on iOS. So, user name is not so visible together with status text. In current UI, Android user name has "bold" font. I propose to make same style on both platforms. It can go as a separate issue if you prefer, and this PR can be merged.
img_0090
screenshot_20170525-154246

@GustavoNunes
Copy link
Contributor Author

good idea @annadanchenko, this was a quick change

@annadanchenko
Copy link

Tested. Looks OK

@rasom rasom merged commit 01fabc2 into develop May 26, 2017
@rasom rasom deleted the feature/drawer-ui-refresh branch May 26, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

Assignees

@GustavoNunes GustavoNunes

Labels
Tested - OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GustavoNunes @flexsurfer @annadanchenko @rasom