Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include a 'My Profile' button in the Start New Chat dialogue #12044

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Include a 'My Profile' button in the Start New Chat dialogue #12044

merged 1 commit into from
Apr 27, 2021

Conversation

briansztamfater
Copy link
Member

@briansztamfater briansztamfater commented Apr 26, 2021 •
edited
Loading

fixes #11990

Summary

Include a 'My Profile' button in the Start New Chat dialogue

Demo

iOS

my-profile-demo-ios

Android

my-profile-demo-android

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • 1-1 chats

Steps to test

  • Open Status
  • Go to Chat tab
  • Tap on + button
  • Tap on "Start new chat"
  • Interact with "My Profile" button

status: ready

@briansztamfater briansztamfater force-pushed the improvement/new-chat-own-address branch from 5e54f15 to b1a92f2 Compare April 26, 2021 19:20
@status-im-auto
Copy link
Member

status-im-auto commented Apr 26, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (11)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5e54f15 #1 2021-04-26 19:26:16 ~11 min android-e2e 📦apk 📲
✔️ 5e54f15 #1 2021-04-26 19:26:18 ~11 min android 📦apk 📲
✔️ 5e54f15 #1 2021-04-26 19:35:40 ~21 min ios 📦ipa 📲
✔️ b1a92f2 #2 2021-04-26 19:30:06 ~9 min android 📦apk 📲
✔️ b1a92f2 #2 2021-04-26 19:34:26 ~14 min android-e2e 📦apk 📲
✔️ b1a92f2 #2 2021-04-26 19:41:12 ~20 min ios 📦ipa 📲
✔️ 88d6a4b #3 2021-04-26 20:40:15 ~9 min android-e2e 📦apk 📲
✔️ 88d6a4b #3 2021-04-26 20:42:03 ~10 min android 📦apk 📲
✔️ 3064b5b #4 2021-04-26 20:45:10 ~10 min android-e2e 📦apk 📲
✔️ 3064b5b #4 2021-04-26 20:55:14 ~20 min ios 📦ipa 📲
✔️ 3064b5b #5 2021-04-27 08:26:55 ~12 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9ca7bc3 #5 2021-04-27 15:16:24 ~9 min android-e2e 📦apk 📲
✔️ 9ca7bc3 #6 2021-04-27 15:16:30 ~9 min android 📦apk 📲
✔️ 9ca7bc3 #6 2021-04-27 15:56:16 ~19 min ios 📦ipa 📲
✔️ 7abed5c #7 2021-04-27 19:52:44 ~9 min android 📦apk 📲
✔️ 7abed5c #7 2021-04-27 20:00:40 ~17 min ios 📦ipa 📲
✔️ 7abed5c #6 2021-04-27 20:01:32 ~18 min android-e2e 📦apk 📲

@errorists
Copy link
Contributor

please tell me you didn't hardcode the user profile picture 😅

@briansztamfater briansztamfater force-pushed the improvement/new-chat-own-address branch 2 times, most recently from 88d6a4b to 3064b5b Compare April 26, 2021 20:34
@briansztamfater
Copy link
Member Author

please tell me you didn't hardcode the user profile picture 😅

didnt-see-anything

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 80
Failed tests: 3
Passed tests: 77

IDs of failed tests: 6265,5783,6283

Failed tests (3)

Click to expand
  • Rerun tests

    • 1. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 2: *Find HomeButton by accessibility id:* `home-tab-button`
    Device 2: *Click until ChatElement by xpath:*`//*[@content-desc='chat-name-text'][starts-with(@text,'New Awesome Tenrec')]/..` *is presented*

    Device 2: DeclineTransaction by xpath: `//*[starts-with(@text,'↓ Incoming transaction')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text="Decline"]` is not found on the screen

    Device sessions

    2. test_can_use_purchased_stickers_on_recovered_account, id: 5783

    Device 1: *Find Button by accessibility id:* `new-chat-button`
    Device 1: ChatButton element not found

    Device 1: ChatButton by accessibility id:`join-public-chat-button` is not found on the screen; also Unexpected Alert is shown: 'Ethereum node was started with incorrect configuration, application will be stopped to recover from that condition. Configured

    Device sessions

    3. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283

    Device 1: *Press system Home button*
    Device 2: *Press system Home button*

    Push notification with text was received for new message in activity centre

    Device sessions

    Passed tests (77)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_send_eth_from_wallet_to_address, id: 5308
    Device sessions

    4. test_onboarding_screen_when_requesting_tokens_for_recovered_account, id: 5677
    Device sessions

    5. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_keycard_create_login_resotore_unlock_same_seed, id: 5689
    Device sessions

    13. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    14. test_delete_close_all_tabs, id: 5390
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    19. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    20. test_block_user_from_public_chat, id: 5786
    Device sessions

    21. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    22. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    23. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    24. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    25. test_request_public_key_status_test_daap, id: 5397
    Device sessions

    26. test_sign_message_from_daap, id: 5342
    Device sessions

    27. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    28. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    30. test_redirect_to_public_chat_tapping_tag_message, id: 5675
    Device sessions

    31. test_keycard_send_two_transactions_one_after_another_in_dapp, id: 6288
    Device sessions

    32. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    33. test_long_press_to_delete_chat, id: 5319
    Device sessions

    34. test_copy_and_paste_messages, id: 5317
    Device sessions

    35. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    36. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    37. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    38. test_transaction_wrong_password_wallet, id: 5408
    Device sessions

    39. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    40. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    41. test_send_two_transactions_one_after_another_in_dapp, id: 5744
    Device sessions

    42. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    43. test_fetch_more_history_in_empty_chat, id: 6205
    Device sessions

    44. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    45. test_keycard_send_two_transactions_in_batch_in_dapp, id: 6287
    Device sessions

    46. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    47. test_keycard_sign_message_from_daap, id: 6251
    Device sessions

    48. test_manage_assets, id: 5341
    Device sessions

    49. test_send_two_transactions_in_batch_in_dapp, id: 5743
    Device sessions

    50. test_browser_managing_bookmarks, id: 6633
    Device sessions

    51. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    52. test_request_stt_from_daap, id: 5309
    Device sessions

    53. test_send_emoji, id: 5328
    Device sessions

    54. test_dapps_permissions, id: 5738
    Device sessions

    55. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    56. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    57. test_create_new_group_chat_messaging_pn_delived, id: 3994
    Device sessions

    58. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    59. test_wallet_set_up, id: 5335
    Device sessions

    60. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    61. test_home_view, id: 5379
    Device sessions

    62. test_can_add_existing_ens, id: 5502
    Device sessions

    63. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    64. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    65. test_set_profile_picture, id: 6646
    Device sessions

    66. test_collectible_from_wallet, id: 5346
    Device sessions

    67. test_public_chat_messaging, id: 5313
    Device sessions

    68. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    69. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    70. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    71. test_pass_phrase_validation, id: 5363
    Device sessions

    72. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    73. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    74. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    75. test_filters_from_daap, id: 5353
    Device sessions

    76. test_fetching_balance_after_offline, id: 6237
    Device sessions

    77. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    @qoqobolo qoqobolo self-assigned this Apr 27, 2021
    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Apr 27, 2021 •
    edited
    Loading

    @briansztamfater thanks for your work! Looks great :)

    Please, add accessibility-id to the profile picture in the 'My Profile' button.
    Once it is added, the PR is ready to be merged.

    Screenshot 2021-04-27 at 15 16 51

    @errorists
    Copy link
    Contributor

    agree, great work! 👏

    @briansztamfater briansztamfater force-pushed the improvement/new-chat-own-address branch from 3064b5b to 9ca7bc3 Compare April 27, 2021 15:06
    @briansztamfater
    Copy link
    Member Author

    Thanks, just added the accessibility id to the profile picture :)

    @briansztamfater briansztamfater force-pushed the improvement/new-chat-own-address branch from 9ca7bc3 to 7abed5c Compare April 27, 2021 19:43
    @briansztamfater
    Include a 'My Profile' button in the Start New Chat dialogue
    4dacc95 
    Signed-off-by: Brian Sztamfater <brian@status.im>
    @briansztamfater briansztamfater force-pushed the improvement/new-chat-own-address branch from 7abed5c to 4dacc95 Compare April 27, 2021 19:44
    @briansztamfater briansztamfater merged commit 4dacc95 into develop Apr 27, 2021
    @briansztamfater briansztamfater deleted the improvement/new-chat-own-address branch April 27, 2021 19:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @briansztamfater briansztamfater

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Include a 'My Profile' button in the Start New Chat dialogue
    5 participants
    @briansztamfater @status-im-auto @errorists @qoqobolo @flexsurfer