Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑 Delete message UI #12390

Closed
wants to merge 0 commits into from

Conversation

shivekkhurana
Copy link
Contributor

@shivekkhurana shivekkhurana commented Jul 28, 2021

fixes #12286

Summary

Add the option to delete chat message. Also introduce a new UI for message actions.

View screenshot 📸

Simulator Screen Shot - iPhone 11 - 2021-08-03 at 10 29 33

Review notes

Messages are critical in terms of perf. Verify that this PR doesn't introduces unintended pitfalls.

Platforms

  • Android
  • iOS

Areas that maybe impacted

  • all chats
Functional
  • 1-1 chats
  • public chats
  • group chats

Steps to test

  • Send a message (public or private)
  • Long press on a message sent by you to see message actions
  • You should see a "Delete" option along with other options
  • Clicking delete hides the message in the db
  • Deleting doesn't affect the receiver's database

status: WIP

@shivekkhurana shivekkhurana changed the title 🗑Delete message UI 🗑 Delete message UI Jul 28, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Jul 28, 2021

Jenkins Builds

Click to see older builds (15)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2a599b6 #1 2021-07-28 09:23:01 ~12 min android 📦apk 📲
✔️ 2a599b6 #1 2021-07-28 09:31:50 ~21 min ios 📦ipa 📲
✔️ 2a599b6 #1 2021-07-28 09:32:34 ~22 min android-e2e 📦apk 📲
✔️ 2aac9f4 #2 2021-07-30 02:00:54 ~14 min android-e2e 📦apk 📲
✔️ 2aac9f4 #2 2021-07-30 02:00:58 ~14 min android 📦apk 📲
✔️ 2aac9f4 #2 2021-07-30 02:03:12 ~17 min ios 📦ipa 📲
✔️ 18feae4 #3 2021-08-03 04:23:36 ~15 min android-e2e 📦apk 📲
✔️ 18feae4 #3 2021-08-03 04:23:43 ~15 min android 📦apk 📲
✔️ 18feae4 #3 2021-08-03 04:24:54 ~16 min ios 📦ipa 📲
✔️ 57c3c6a #4 2021-08-03 04:39:22 ~14 min android-e2e 📦apk 📲
✔️ 57c3c6a #4 2021-08-03 04:39:30 ~15 min android 📦apk 📲
✔️ 57c3c6a #4 2021-08-03 04:45:00 ~20 min ios 📦ipa 📲
✖️ 61e2d1f #5 2021-08-06 02:31:50 ~13 min ios 📦ipa 📲
✖️ 61e2d1f #5 2021-08-06 02:32:46 ~14 min android 📦apk 📲
✖️ 61e2d1f #5 2021-08-06 02:32:57 ~14 min android-e2e 📦apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4c082ab #6 2021-08-06 09:06:01 ~13 min ios 📦ipa 📲
✔️ 4c082ab #6 2021-08-06 09:07:56 ~15 min android-e2e 📦apk 📲
✔️ 4c082ab #6 2021-08-06 09:08:01 ~15 min android 📦apk 📲
✔️ 4c082ab #7 2021-08-10 08:39:54 ~17 min ios 📦ipa 📲
✔️ c3f5130 #7 2021-08-16 09:53:05 ~19 min android-e2e 📦apk 📲
✔️ c3f5130 #7 2021-08-16 09:53:41 ~19 min android 📦apk 📲
✔️ c3f5130 #8 2021-08-16 09:54:11 ~20 min ios 📦ipa 📲

@flexsurfer
Copy link
Member

@shivekkhurana is it wip ?is draft

@shivekkhurana
Copy link
Contributor Author

shivekkhurana commented Jul 28, 2021

@flexsurfer It's wip. I'm not clear if the messages will be deleted from the network, and if yes, how to handle them. Started a conversation thread on Discord here.

@shivekkhurana shivekkhurana force-pushed the shivekkhurana/12286/delete-messages branch from 18feae4 to 57c3c6a Compare August 3, 2021 04:24
@shivekkhurana shivekkhurana marked this pull request as ready for review August 3, 2021 04:24
@shivekkhurana
Copy link
Contributor Author

@flexsurfer I have implemented a UI only message delete. It doesn't rebuilds the list on every delete.
Will update other instances of hide-message when this gets merged.

@shivekkhurana
Copy link
Contributor Author

shivekkhurana commented Aug 3, 2021

UPDATE : Resolved

Known Bug: Deleted message is visible to the receiver until they go-back to the chat index and open the chat again.

https://discord.com/channels/624205794384281629/862717376915308544/872026952754663466
While implementing the delete-message UI, I realised that the signal doesn't have the id of the deleted message.
Imagine this flow: D1 and D2 are two devices with a 1:1 chat open.

  1. D1 sends the message "2" to D2
  2. D1 sends the message "4" to D2
  3. D1 deletes the message "4"

At step 3, D2 receives a signal like this:

{:description "",
 :lastClockValue 1627977236319,
 :deletedAtClockValue 0,
 :joined 1627976672860,
 :identicon "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADIAAAAyCAYAAAAeP4ixAAAAmklEQVR4nOzY0QnCQBAGYRV7sSnLsAzLsCmrSd6PHLnlODL8zPcoizAsLEcetxCG0BhCYwiNITQxIc/Rwe//tx39/nm971fMt2I2YgiNIVokZiOG0BhCM/3W6qm+qar/04rZiCE0htAMX62e0atyNl+9Zq2YjRhCYwjN9NXqmf1OVRWzEUNoDNEiMRsxhMYQGkNoDKHZAwAA//8uLB1h/9556wAAAABJRU5ErkJggg==",
 :color "",
 :name "0x045238",
 :alias "Remarkable Uniform Nudibranch",
 :lastMessage {:messageType 1,
               :identicon "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADIAAAAyCAYAAAAeP4ixAAAAoUlEQVR4nOzYwQnCQBBGYRV7sSQbsQwbsSSrSe4hC7PZXXj8vO88Bx8Dg5vHLYQhNIbQGEJjCE1MyLM6+P3/trU/5dzn9b5X5mI2YgiNITSli3BF68pVr1CvmI0YQmMIzfAFmfUfbPSaxWzEEBpDaMovxF6tK7TqpRmzEUNoDKEZ/q7Ve51mzR/FbMQQGkO0SMxGDKExhMYQGkNo9gAAAP//YnAcZw9HxUQAAAAASUVORK5CYII=",
               :replace "",
               :chatId "0x0452380654d8e40fcd056db49b1c71c99358d5bc320b1ed0b862c400cbf3201ed7cfb1a480b245c69614453381e5bff2fd8ccffcafb4b9155883f58ef2511d95a9",
               :lineCount 0,
               :whisperTimestamp 1627977123593,
               :alias "Welloff Impressive Reptile",
               :seen true,
               :gapParameters {},
               :from "0x040f2f9a3ccba626625e4479fe61a806dca36fcb453050c21adc36f6d8f024611869326464d6143e2339a9ba7f3f477abe6a9e56fb94cd46b5df14378f50e43d43",
               :id "0x6214e4b09359d6fa73f0fcc302b1089be603676a1fd1a5a147f8d885e42ab0f6",
               :parsedText [{:type "paragraph",
                             :children [{:literal "2"}]}],
               :contentType 1,
               :clock 1627977123593,
               :localChatId "0x0452380654d8e40fcd056db49b1c71c99358d5bc320b1ed0b862c400cbf3201ed7cfb1a480b245c69614453381e5bff2fd8ccffcafb4b9155883f58ef2511d95a9",
               :outgoingStatus "delivered",
               :timestamp 1627977123593,
               :ensName "",
               :quotedMessage nil,
               :rtl false,
               :responseTo "",
               :text "2"},
 :active true,
 :id "0x0452380654d8e40fcd056db49b1c71c99358d5bc320b1ed0b862c400cbf3201ed7cfb1a480b245c69614453381e5bff2fd8ccffcafb4b9155883f58ef2511d95a9",
 :unviewedMentionsCount 0,
 :unviewedMessagesCount 0,
 :membershipUpdateEvents nil,
 :chatType 1,
 :members nil,
 :timestamp 1627977237846}

This signal has no reference to the deleted message. There is no problem if the chat is in the background or the user is on some other screen. But if the user is on the chat screen, I need some id to remove the deleted message from the screen.

@churik
Copy link
Member

churik commented Aug 4, 2021

@shivekkhurana
please ping me once it is ready to be tested.
Thank you.

@shivekkhurana
Copy link
Contributor Author

@churik This is ready to test

src/status_im/chat/models/input.cljs Outdated Show resolved Hide resolved
src/status_im/signals/core.cljs Outdated Show resolved Hide resolved
(defn flip-args [f]
(fn [x y] (f y x)))

(defn message-ids->message-id-chat-id-map
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhm , why is it so complex ? isn't it possible to have this in the format we want from status-go ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the backend only returns the message-id of the deleted messages. But messages are indexed by chat-id in the frontend model. Its not ideal. I'll check if I can re-write the backend. There is one more issue that needs to be solved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean its not urgent, i think thats fine

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 71
Failed tests: 3
Passed tests: 68
IDs of failed tests: 5360,5502,6249 

Failed tests (3)

Click to expand
  • Rerun tests

  • 1. test_unread_messages_counter_public_chat, id: 5360

    Device 2: **Signed in successfully!**
    Device 2: **Looking for chat '#bozzmoa'**

    Counter is not shown for mention in public chat

    Device sessions

    2. test_can_add_existing_ens, id: 5502

    Device 1: *Click until Button by xpath:*`(//android.widget.ImageView[@content-desc='icon'])[2]/../..` *is NOT presented*
    Device 1: *Find Button by xpath:* `//*[@text="Ok, got it"]`

    Device 1: Button by xpath: `//*[@text="Ok, got it"]` is not found on the screen

    Device sessions

    3. test_keycard_request_stt_from_daap, id: 6249

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen

    Device sessions

    Passed tests (68)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    12. test_delete_close_all_tabs, id: 5390
    Device sessions

    13. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    14. test_send_token_with_7_decimals, id: 5350
    Device sessions

    15. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    26. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    27. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    29. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    31. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    32. test_long_press_to_delete_chat, id: 5319
    Device sessions

    33. test_copy_and_paste_messages, id: 5317
    Device sessions

    34. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    35. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    36. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    37. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    38. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    39. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    40. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    41. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    42. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    43. test_manage_assets, id: 5341
    Device sessions

    44. test_browser_managing_bookmarks, id: 6633
    Device sessions

    45. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    46. test_request_stt_from_daap, id: 5309
    Device sessions

    47. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    48. test_dapps_permissions, id: 5738
    Device sessions

    49. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    50. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    51. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    52. test_wallet_set_up, id: 5335
    Device sessions

    53. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    54. test_home_view, id: 5379
    Device sessions

    55. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    56. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    57. test_set_profile_picture, id: 6646
    Device sessions

    58. test_collectible_from_wallet, id: 5346
    Device sessions

    59. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    60. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    61. test_pass_phrase_validation, id: 5363
    Device sessions

    62. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    63. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    64. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    65. test_fetching_balance_after_offline, id: 6237
    Device sessions

    66. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    67. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    68. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    @status-im-auto
    Copy link
    Member

    96% of end-end tests have passed

    Total executed tests: 71
    Failed tests: 3
    Passed tests: 68
    
    IDs of failed tests: 5314,6265,6237 
    

    Failed tests (3)

    Click to expand
  • Rerun tests

  • 1. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314

    Device 1: *Pull to refresh view*
    Device 1: *Pull to refresh view*

    Device 1: TransactionElement by xpath:`//android.view.ViewGroup[@content-desc="transaction-item"]` is not found on the screen

    Device sessions

    2. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 1: Decline transaction request and check that state is changed
    Device 1: =========================================================================

    Device 1: RequestCommand by xpath: `//*[@text="Request transaction"]` is not found on the screen

    Device sessions

    3. test_fetching_balance_after_offline, id: 6237

    Device 1: **Signing transaction (keycard:False, default_gas_price:False)**
    Device 1: *Find Button by accessibility id:* `custom-gas-fee`

    Device 1: Button by accessibility id: `custom-gas-fee` is not found on the screen

    Device sessions

    Passed tests (68)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    11. test_delete_close_all_tabs, id: 5390
    Device sessions

    12. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    13. test_send_token_with_7_decimals, id: 5350
    Device sessions

    14. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    15. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    16. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    17. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    18. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    19. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    20. test_block_user_from_public_chat, id: 5786
    Device sessions

    21. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    22. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    25. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    26. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    27. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    28. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    30. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    31. test_long_press_to_delete_chat, id: 5319
    Device sessions

    32. test_copy_and_paste_messages, id: 5317
    Device sessions

    33. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    34. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    35. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    36. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    37. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    38. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    39. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    40. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    41. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    42. test_manage_assets, id: 5341
    Device sessions

    43. test_browser_managing_bookmarks, id: 6633
    Device sessions

    44. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    45. test_request_stt_from_daap, id: 5309
    Device sessions

    46. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    47. test_dapps_permissions, id: 5738
    Device sessions

    48. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    49. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    50. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    51. test_wallet_set_up, id: 5335
    Device sessions

    52. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    53. test_home_view, id: 5379
    Device sessions

    54. test_can_add_existing_ens, id: 5502
    Device sessions

    55. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    56. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    57. test_set_profile_picture, id: 6646
    Device sessions

    58. test_collectible_from_wallet, id: 5346
    Device sessions

    59. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    60. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    61. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    62. test_pass_phrase_validation, id: 5363
    Device sessions

    63. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    64. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    65. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    66. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    67. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    68. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Aug 10, 2021

    @shivekkhurana

    ISSUE 1: Recipient sees the deleted message if it was received while Recipient was offline/logged out.

    Reproduction:

    1. D1 starts or join any chat with D2 (1-1/group/public/community)
    2. D2 closes Status
    3. D1 sends a message and deletes it
    4. D2 logs in and opens the chat

    Expected behaviour: no message in chat history
    Actual behaviour: message is visible

    ISSUE 2: Unread indicator/counter is shown for deleted message

    Reproduction:

    1. D1 and D2 join the same public chat
    2. D1 navigates to Home screen
    3. D2 sends a message and deletes it

    Expected behaviour: unread indicator disappears after deleting a message
    Actual behaviour: indicator remains on chat preview

    IMG_0833.mp4

    ISSUE 3: Deleted message is visible in Activity center

    If D1 sends a message (in 1-1 or mention/reply in group/community) and deletes it, preview with deleted message will be displayed in Activity center.

    ISSUE 4: Deleted message is visible in push notifications

    If you think it's better to fix it in a separate PR, ping me pls and I'll log it.

    ISSUE 5: Redundant ! button in the 'Message actions' context menu in Timeline

    Reproduction:

    1. Post smth in Timeline
    2. Long tap on the message

    Screenshot 2021-08-10 at 16 09 51

    ISSUE 6: Deleted messages in 1-1 and group chats are visible for sender in chat preview on Home screen

    Reproduction:

    1. Start 1-1 and create group chat with another user
    2. Send messages to both chats
    3. Delete messages
    4. Check chat previews on Home screen

    Screenshot 2021-08-10 at 16 41 26

    @qoqobolo qoqobolo self-assigned this Aug 11, 2021
    @shivekkhurana
    Copy link
    Contributor Author

    @cammellos cammellos force-pushed the shivekkhurana/12286/delete-messages branch from 4c082ab to c3f5130 Compare August 16, 2021 09:33
    @cammellos
    Copy link
    Contributor

    @qoqobolo issue 1 should be fixed in the next build, do you think is good enough to merge or there's some other issue that's blocking you think?

    Thanks!

    @qoqobolo
    Copy link
    Contributor

    @cammellos confirm that Issue 1 is fixed, that's great, thanks!

    However, it would be nice to have fixed issues 3, 4, 5, and 6 in the PR if possible as well, since there are quite a few places left where the deleted messages remain visible for users.

    But if you think it would be more convenient to fix it later, let me know, I'll log them separately and include them to 1.16.

    @cammellos
    Copy link
    Contributor

    @qoqobolo if you could log them separately, it would be better, if that's ok, if we could merge, so we don't have to rebase, and I can take a look at the remaining issues.
    Thanks!

    @qoqobolo
    Copy link
    Contributor

    @cammellos sure, np!

    @cammellos cammellos closed this Aug 16, 2021
    @cammellos cammellos force-pushed the shivekkhurana/12286/delete-messages branch from c3f5130 to 8ec46a0 Compare August 16, 2021 11:27
    @churik churik mentioned this pull request Aug 20, 2021
    @shivekkhurana shivekkhurana deleted the shivekkhurana/12286/delete-messages branch November 8, 2021 08:29
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Delete messages
    6 participants