Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when opening 1-1 chat in activity center for blocked user #12399

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

briansztamfater
Copy link
Member

fixes #12333

Summary

This PR aims to fix an error when opening 1-1 chat in activity center with a previously blocked user. The proposed solution is to avoid showing that notifications as it makes no sense, so we filter it.

Platforms

  • Android
  • iOS
Functional
  • activity center

Steps to test

User A:

  • Join a public chat
  • Send a message
  • Send a message in 1-1 chat with User B

User B:

  • Join the same public chat
  • Tap User's A name in chat view > Open profile > Block
  • Open Activity center
  • Verify there's no notification in activity center for a 1-to-1 chat

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jul 29, 2021

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e644ff2 #1 2021-07-29 21:30:00 ~14 min android-e2e 📦apk 📲
✔️ e644ff2 #1 2021-07-29 21:30:43 ~14 min android 📦apk 📲
✔️ e644ff2 #1 2021-07-29 21:33:47 ~18 min ios 📦ipa 📲
✔️ e644ff2 #2 2021-08-02 14:52:22 ~20 min ios 📦ipa 📲

@churik churik self-assigned this Aug 2, 2021
@churik
Copy link
Member

churik commented Aug 3, 2021

Tested:

  • reply from blocked user in activity centre
  • mention from blocked user in activity centre
  • 1-1 chat invite from blocked user in activity centre
  • invite to group chat from blocked user in activity centre

No error is shown, however all messages are shown - ideally they should be erased from activity centre, but I believe it is another issue with lower priority.
Thank you @briansztamfater - ready to be merged

Signed-off-by: Brian Sztamfater <brian@status.im>
@briansztamfater briansztamfater force-pushed the bug/fix-error-notification-blocked-user branch from e644ff2 to e5477cd Compare August 3, 2021 12:31
@briansztamfater briansztamfater merged commit e5477cd into develop Aug 3, 2021
@briansztamfater briansztamfater deleted the bug/fix-error-notification-blocked-user branch August 3, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Error when opening 1-1 chat in Activity center with a previously blocked user
4 participants