Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13642: Cannot sign in on claim.lens.xyz #13668

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Jul 15, 2022

fixes #13642

@status-im-auto
Copy link
Member

status-im-auto commented Jul 15, 2022

Jenkins Builds

Click to see older builds (3)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e735e64 #1 2022-07-15 06:17:08 ~9 min android 📦apk 📲
✔️ e735e64 #1 2022-07-15 06:17:10 ~9 min android-e2e 📦apk 📲
✔️ e735e64 #1 2022-07-15 06:20:05 ~12 min ios 📦ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4dc1c45 #2 2022-07-15 10:26:34 ~9 min android-e2e 📦apk 📲
✔️ 4dc1c45 #2 2022-07-15 10:27:41 ~10 min ios 📦ipa 📲
✔️ 4dc1c45 #2 2022-07-15 10:29:08 ~11 min android 📦apk 📲
✔️ 61cb54f #3 2022-07-15 15:18:55 ~12 min android 📦apk 📲
61cb54f #3 2022-07-15 15:19:17 ~13 min android-e2e 📄log

Copy link
Member

@Parveshdhull Parveshdhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @qfrank , Thank you very much for the PR.

Comment on lines +192 to +198
try{
cb(data)
} catch(e){
setTimeout((()=>{throw e}))
}});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are using setTimeout to throw the error, so that it shouldn't stop the current js thread. Please can you explain, what is the benefit of doing that, can we just use an empty block here?

Copy link
Member

@Parveshdhull Parveshdhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thanks for adding comment. PR looks good to me. Thank you

@status-im-auto
Copy link
Member

82% of end-end tests have passed

Total executed tests: 84
Failed tests: 15
Passed tests: 69
IDs of failed tests: 700739,702196,702077,702072,702156,702076,702073,702078,700738,702194,5396,5317,5675,702075,702074 

Failed tests (15)

Click to expand
  • Rerun failed tests

  • 1. test_public_chat_open_using_deep_link, id: 700739
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    2. test_pairing_sync_contacts_block_unblock, id: 702196
    Test is not run, e2e blocker [[reason: [NOTRUN] failing due to issue #13635. Skipping until fix]]

    Class: TestPairingSyncMultipleDevicesMerged

    3. test_browser_bookmarks_create_edit_remove, id: 702077
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    4. test_browser_blocked_url, id: 702072
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    5. test_ens_mention_push_highlighted_public_chat, id: 702156

    Device 2: Find `Button` by `xpath`: `//*[starts-with(@text,'statuse2e.eth')]`
    Device 2: Image differs from template to 9.34597102244161 percents

    critical/chats/test_1_1_public_chats.py:1124: in test_ens_mention_push_highlighted_public_chat self.errors.verify_no_errors() base_test_case.py:189: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    6. test_browser_delete_close_tabs, id: 702076
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    7. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    8. test_browser_web3_permissions_testdapp, id: 702078
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    9. test_public_chat_tag_message, id: 700738
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    10. test_pairing_sync_initial_contacts_blocked_users, id: 702194
    Test is not run, e2e blocker [[reason: [NOTRUN] failing due to issue #13635. Skipping until fix]]

    Class: TestPairingSyncMultipleDevicesMerged

    11. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    12. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    13. test_public_chat_fetch_more_history, id: 5675

    Device 1: Find `CheckBox` by `accessibility id`: `checkbox-off`
    Device 1: Click until `Button` by `xpath`: `//*[@text="Generate keys"]` will be presented

    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    Device sessions

    14. test_browser_offline, id: 702075
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    15. test_browser_invalid_url, id: 702074
    Test setup failed: /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:699: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.8/site-packages/urllib3/connectionpool.py:445: in _make_request s

    Class: TestPublicChatBrowserOneDeviceMerged

    Passed tests (69)

    Click to expand

    1. test_wallet_manage_assets, id: 700758

    Class: TestWalletManagementDeviceMerged

    Device sessions

    2. test_public_chat_message_edit, id: 700734

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    3. test_contact_block_unblock_public_chat_offline, id: 702176

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    5. test_keycard_relogin_after_restore, id: 700768

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    6. test_group_chat_push_system_messages_when_invited, id: 3994

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    7. test_ens_command_send_tx_eth_1_1_chat, id: 702153

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    8. test_send_tx_token_7_decimals, id: 700764

    Class: TestSendTxDeviceMerged

    Device sessions

    9. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    10. test_public_chat_unread_messages_counter, id: 5360

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    11. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    12. test_public_chat_emoji_send_copy_paste_reply, id: 700719

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    13. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    14. test_send_tx_eth_check_logcat, id: 700763

    Class: TestSendTxDeviceMerged

    Device sessions

    15. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    16. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

    Class: TestSendTxDeviceMerged

    Device sessions

    17. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    18. test_wallet_add_account_seed_phrase_validation, id: 700762

    Class: TestWalletManagementDeviceMerged

    Device sessions

    19. test_public_chat_delete_chat_long_press, id: 5319

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    20. test_onboarding_home_initial_popup, id: 700742

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    21. test_wallet_add_hide_unhide_account_private_key, id: 700761

    Class: TestWalletManagementDeviceMerged

    Device sessions

    22. test_1_1_chat_message_reaction, id: 6315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    23. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    24. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    25. test_1_1_chat_image_send_save_reply, id: 6305

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    26. test_group_chat_highligted, id: 5756

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    27. test_public_chat_link_send_open, id: 700736

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    28. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    29. test_onboarding_share_contact_address, id: 700743

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    30. test_sticker_1_1_public_chat, id: 702157

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    31. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    32. test_restore_set_up_wallet_sign_phrase, id: 700749

    Class: TestRestoreOneDeviceMerged

    Device sessions

    33. test_ens_mention_nickname_1_1_chat, id: 702155

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    34. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    35. test_public_chat_mark_all_messages_as_read, id: 6270

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    36. test_send_tx_set_recipient_options, id: 700757

    Class: TestSendTxDeviceMerged

    Device sessions

    37. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    38. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

    Class: TestSendTxDeviceMerged

    Device sessions

    39. test_group_chat_join_send_text_messages_push, id: 700731

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    40. test_1_1_chat_text_message_with_push, id: 6316

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    41. test_wallet_add_delete_watch_only_account, id: 700760

    Class: TestWalletManagementDeviceMerged

    Device sessions

    42. test_onboarding_share_wallet_address, id: 700744

    Class: TestOnboardingOneDeviceMerged

    Device sessions

    43. test_keycard_create_account_unlock_same_seed, id: 5689

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    44. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

    Class: TestCommandsMultipleDevicesMerged

    Device sessions

    45. test_pairing_sync_1_1_chat_message, id: 702198

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    46. test_pairing_sync_public_chat_add_remove, id: 702199

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    47. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

    Class: TestWalletManagementDeviceMerged

    Device sessions

    48. test_group_chat_offline_pn, id: 3998

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    49. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    50. test_group_chat_add_new_member_activity_centre, id: 700732

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    51. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    52. test_ens_purchased_in_profile, id: 702152

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    53. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    54. test_keycard_send_tx_eth, id: 700767

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    55. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Class: TestRestoreOneDeviceMerged

    Device sessions

    56. test_restore_seed_phrase_field_validation, id: 700750

    Class: TestRestoreOneDeviceMerged

    Device sessions

    57. test_wallet_add_account_generate_new, id: 700759

    Class: TestWalletManagementDeviceMerged

    Device sessions

    58. test_start_new_chat_public_key_validation, id: 702158

    Class: TestEnsStickersMultipleDevicesMerged

    Device sessions

    59. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

    Class: TestRestoreOneDeviceMerged

    Device sessions

    60. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    61. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

    Class: TestWalletManagementDeviceMerged

    Device sessions

    62. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

    Class: TestContactBlockMigrateKeycardMultipleSharedDevices

    Device sessions

    63. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    64. test_group_chat_leave_relogin, id: 3997

    Class: TestGroupChatMultipleDeviceMerged

    Device sessions

    65. test_public_chat_message_delete, id: 700735

    Class: TestPublicChatMultipleDeviceMerged

    Device sessions

    66. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

    Class: TestKeycardTxOneDeviceMerged

    Device sessions

    67. test_1_1_chat_push_emoji, id: 6283

    Class: TestOneToOneChatMultipleSharedDevices

    Device sessions

    68. test_pairing_sync_initial_public_chats, id: 702195

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    69. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

    Class: TestPairingSyncMultipleDevicesMerged

    Device sessions

    @qoqobolo qoqobolo self-assigned this Jul 15, 2022
    @qoqobolo
    Copy link
    Contributor

    @qfrank thank you for the fix!
    Tested on Android and iOS, with regular and Keycard accounts. E2e test failures are not PR-related.
    It can be merged.

    Signed-off-by: Parvesh Monu <parvesh.dhullmonu@gmail.com>
    @Parveshdhull Parveshdhull merged commit 61cb54f into status-im:develop Jul 15, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Cannot sign in on claim.lens.xyz
    5 participants