-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #13642: Cannot sign in on claim.lens.xyz #13668
Conversation
Jenkins BuildsClick to see older builds (3)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @qfrank , Thank you very much for the PR.
try{ | ||
cb(data) | ||
} catch(e){ | ||
setTimeout((()=>{throw e})) | ||
}}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you are using setTimeout
to throw the error, so that it shouldn't stop the current js thread. Please can you explain, what is the benefit of doing that, can we just use an empty block here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thanks for adding comment. PR looks good to me. Thank you
82% of end-end tests have passed
Failed tests (15)Click to expand
Passed tests (69)Click to expand
|
@qfrank thank you for the fix! |
Signed-off-by: Parvesh Monu <parvesh.dhullmonu@gmail.com>
fixes #13642