Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of switcher cards #13854

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Implementation of switcher cards #13854

merged 1 commit into from
Sep 19, 2022

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Aug 24, 2022 •
edited
Loading

Review Notes:

This PR depends on #14006, but for the purpose of review, those changes are currently reverted.
If you want to try the app please install #6 build (commit hash fada028)

status: ready

@Parveshdhull Parveshdhull self-assigned this Aug 24, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Aug 24, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (35)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 08ff740 #1 2022-08-24 23:27:09 ~7 min android-e2e 📦apk 📲
✖️ 08ff740 #1 2022-08-24 23:28:22 ~8 min android 📦apk 📲
✖️ 08ff740 #1 2022-08-24 23:31:41 ~11 min ios 📦ipa 📲
❌ e013619 #1 2022-08-28 21:09:16 ~1 min tests 📄log
❌ e013619 #2 2022-08-28 21:11:26 ~4 min ios 📄log
✔️ e013619 #2 2022-08-28 21:15:16 ~7 min android 📦apk 📲
✔️ e013619 #2 2022-08-28 21:16:50 ~9 min android-e2e 📦apk 📲
❌ 3713951 #2 2022-08-28 21:21:08 ~2 min tests 📄log
✔️ 3713951 #3 2022-08-28 21:26:18 ~7 min android 📦apk 📲
✔️ 3713951 #3 2022-08-28 21:26:25 ~7 min android-e2e 📦apk 📲
✔️ 3713951 #3 2022-08-28 21:34:47 ~16 min ios 📦ipa 📲
❌ 94938e5 #3 2022-08-28 21:39:07 ~2 min tests 📄log
✔️ 94938e5 #4 2022-08-28 21:44:18 ~7 min android-e2e 📦apk 📲
✔️ 94938e5 #4 2022-08-28 21:44:57 ~8 min android 📦apk 📲
✔️ 94938e5 #4 2022-08-28 21:52:28 ~15 min ios 📦ipa 📲
❌ 94938e5 #1 2022-09-02 12:01:30 ~10 min android 📄log
❌ 94938e5 #1 2022-09-02 12:16:10 ~24 min tests 📄log
❌ 9b0e237 #2 2022-09-11 22:35:20 ~1 min tests 📄log
✔️ 9b0e237 #2 2022-09-11 22:41:10 ~7 min android-e2e 📦apk 📲
✔️ 9b0e237 #2 2022-09-11 22:41:15 ~7 min android 📦apk 📲
✔️ 9b0e237 #2 2022-09-11 22:45:41 ~12 min ios 📦ipa 📲
❌ 7db41a9 #3 2022-09-12 10:18:41 ~3 min tests 📄log
✔️ 7db41a9 #3 2022-09-12 10:22:44 ~7 min android-e2e 📦apk 📲
✔️ 7db41a9 #3 2022-09-12 10:25:03 ~10 min android 📦apk 📲
✔️ 7db41a9 #3 2022-09-12 10:29:18 ~14 min ios 📦ipa 📲
❌ f08749e #4 2022-09-18 00:18:23 ~49 sec android 📄log
❌ f08749e #4 2022-09-18 00:18:34 ~1 min android-e2e 📄log
❌ f08749e #4 2022-09-18 00:19:02 ~1 min tests 📄log
❌ f08749e #4 2022-09-18 00:19:40 ~2 min ios 📄log
❌ 80d3ce4 #5 2022-09-18 22:41:34 ~1 min tests 📄log
✔️ 80d3ce4 #5 2022-09-18 22:47:01 ~7 min android 📦apk 📲
✔️ fada028 #6 2022-09-18 22:49:15 ~1 min tests 📦log
✔️ fada028 #6 2022-09-18 22:54:46 ~7 min android-e2e 📦apk 📲
✔️ fada028 #6 2022-09-18 22:54:50 ~7 min android 📦apk 📲
✔️ fada028 #6 2022-09-18 22:59:25 ~12 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 44e2d1a #7 2022-09-18 23:03:13 ~1 min tests 📄log
✔️ 44e2d1a #7 2022-09-18 23:08:33 ~7 min android-e2e 📦apk 📲
✔️ 44e2d1a #7 2022-09-18 23:09:03 ~7 min android 📦apk 📲
✔️ 44e2d1a #7 2022-09-18 23:13:29 ~12 min ios 📦ipa 📲
✔️ ab3c9b7 #8 2022-09-19 09:26:56 ~21 min android-e2e 📦apk 📲
✔️ ab3c9b7 #8 2022-09-19 09:28:42 ~23 min tests 📦log
✔️ ab3c9b7 #8 2022-09-19 09:36:35 ~31 min android 📦apk 📲

@Parveshdhull Parveshdhull force-pushed the feature/switcher-cards branch 2 times, most recently from e013619 to 3713951 Compare August 28, 2022 21:18
@Parveshdhull Parveshdhull changed the title switcher cards [WIP] switcher cards Aug 28, 2022
@Parveshdhull Parveshdhull mentioned this pull request Aug 28, 2022
Merged
@Parveshdhull Parveshdhull force-pushed the feature/switcher-cards branch 3 times, most recently from 7db41a9 to f08749e Compare September 18, 2022 00:17
@Parveshdhull Parveshdhull changed the title [WIP] switcher cards Implementation of switcher cards Sep 18, 2022
@Parveshdhull Parveshdhull force-pushed the feature/switcher-cards branch 2 times, most recently from 80d3ce4 to fada028 Compare September 18, 2022 22:46
@Parveshdhull Parveshdhull marked this pull request as ready for review September 18, 2022 22:47
@du82
Copy link
Contributor

du82 commented Sep 18, 2022

Now it errors

Screenshot_2022-09-18-17-51-59-58_65ad86f86fd2321a85272a99323da10f

@Parveshdhull
Copy link
Member Author

Parveshdhull commented Sep 18, 2022 •
edited
Loading

Review Notes:

This PR depends on #14006, but for the purpose of review, those changes are currently reverted.
If you want to try the app please install #6 build (commit hash fada028)

cc: @Du64

@status-im-auto
Copy link
Member

95% of end-end tests have passed

Total executed tests: 87
Failed tests: 4
Passed tests: 83

IDs of failed tests: 5756,700757,700732,3997

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_highligted, id: 5756

    Device 1: Double tap on: HomeButton
    Device 1: Find `HomeButton` by `xpath`: `//*[contains(@content-desc,'tab, 1 out of 5')]` 

    critical/chats/test_group_chat.py:162: in test_group_chat_highligted
    [self.homes[i].home_button.double_click() for i in range(3)]
critical/chats/test_group_chat.py:162: in <listcomp>
    [self.homes[i].home_button.double_click() for i in range(3)]
../views/base_element.py:110: in double_click
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:110: in <listcomp>
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen



    Device sessions

    2. test_group_chat_add_new_member_activity_centre, id: 700732

    Device 3: Find Button by accessibility id: notifications-unread-badge
    Device 3: Tap on found: Button 

    critical/chats/test_group_chat.py:118: in test_group_chat_add_new_member_activity_centre
    self.homes[2].get_chat(self.chat_name).click()
../views/home_view.py:257: in get_chat
    chat_in_ac.wait_for_element(20)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `3`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'dzfokjd')]/../..` is not found on the screen after wait_for_element



    Device sessions

    3. test_group_chat_leave_relogin, id: 3997

    Device 1: Double tap on: HomeButton
    Device 1: Find HomeButton by xpath: //*[contains(@content-desc,'tab, 1 out of 5')] 

    critical/chats/test_group_chat.py:178: in test_group_chat_leave_relogin
    [self.homes[i].home_button.double_click() for i in range(2)]
critical/chats/test_group_chat.py:178: in <listcomp>
    [self.homes[i].home_button.double_click() for i in range(2)]
../views/base_element.py:110: in double_click
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:110: in <listcomp>
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen



    Device sessions

    Class TestSendTxDeviceMerged:

    1. test_send_tx_set_recipient_options, id: 700757

    Device 1: Type my to EditBox
    Device 1: Find Button by xpath: //*[@text="my_basic_address"] 

    critical/wallet_and_tx/test_send_tx_dapp_keycard.py:262: in test_send_tx_set_recipient_options
    send_tr.element_by_text(basic_add_to_fav_name).click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="my_basic_address"]` is not found on the screen



    Device sessions

    Passed tests (83)

    Click to expand

    Class TestPublicChatMultipleDeviceMerged:

    1. test_public_chat_message_edit, id: 700734
    Device sessions

    2. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    3. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    5. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    6. test_public_chat_link_send_open, id: 700736
    Device sessions

    7. test_public_chat_mark_all_messages_as_read, id: 6270
    Device sessions

    8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    10. test_public_chat_message_delete, id: 700735
    Device sessions

    Class TestSendTxDeviceMerged:

    1. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    3. test_send_tx_token_8_decimals, id: 700764
    Device sessions

    4. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_sticker_1_1_public_chat_mainnet, id: 702157
    Device sessions

    2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
    Device sessions

    3. test_ens_mention_push_highlighted_public_chat, id: 702156
    Device sessions

    4. test_ens_mention_nickname_1_1_chat, id: 702155
    Device sessions

    5. test_ens_purchased_in_profile, id: 702152
    Device sessions

    6. test_start_new_chat_public_key_validation, id: 702158
    Device sessions

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    3. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    4. test_keycard_send_tx_eth, id: 700767
    Device sessions

    5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    3. test_group_chat_offline_pn, id: 3998
    Device sessions

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
    Device sessions

    2. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    3. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    2. test_browser_bookmarks_create_edit_remove, id: 702077
    Device sessions

    3. test_browser_blocked_url, id: 702072
    Device sessions

    4. test_browser_delete_close_tabs, id: 702076
    Device sessions

    5. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Device sessions

    6. test_browser_web3_permissions_testdapp, id: 702078
    Device sessions

    7. test_public_chat_tag_message, id: 700738
    Device sessions

    8. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    9. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
    Device sessions

    10. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    11. test_browser_offline, id: 702075
    Device sessions

    12. test_browser_invalid_url, id: 702074
    Device sessions

    Class TestOnboardingOneDeviceMerged:

    1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    2. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    3. test_onboarding_share_contact_address, id: 700743
    Device sessions

    4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    6. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    Class TestRestoreOneDeviceMerged:

    1. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
    Device sessions

    3. test_restore_seed_phrase_field_validation, id: 700750
    Device sessions

    4. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    Class TestPairingSyncMultipleDevicesMerged:

    1. test_pairing_sync_clear_history, id: 702394
    Device sessions

    2. test_pairing_sync_contacts_block_unblock, id: 702196
    Device sessions

    3. test_pairing_sync_initial_profile_picture, id: 702392
    Device sessions

    4. test_pairing_sync_initial_bookmarks, id: 702393
    Device sessions

    5. test_pairing_sync_initial_contacts_blocked_users, id: 702194
    Device sessions

    6. test_pairing_sync_1_1_chat_message, id: 702198
    Device sessions

    7. test_pairing_sync_public_chat_add_remove, id: 702199
    Device sessions

    8. test_pairing_sync_initial_public_chats, id: 702195
    Device sessions

    9. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_contact_block_unblock_public_chat_offline, id: 702176
    Device sessions

    2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
    Device sessions

    3. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
    Device sessions

    4. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
    Device sessions

    5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
    Device sessions

    Class TestWalletManagementDeviceMerged:

    1. test_wallet_manage_assets, id: 700758
    Device sessions

    2. test_wallet_add_account_seed_phrase_validation, id: 700762
    Device sessions

    3. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    4. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    6. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
    Device sessions

    Class TestOneToOneChatMultipleSharedDevices:

    1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
    Device sessions

    2. test_1_1_chat_message_reaction, id: 6315
    Device sessions

    3. test_1_1_chat_audio_message_with_push, id: 6316
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
    Device sessions

    5. test_1_1_chat_image_send_save_reply, id: 6305
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
    Device sessions

    7. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
    Device sessions

    8. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
    Device sessions

    9. test_1_1_chat_push_emoji, id: 6283
    Device sessions

    @du82
    Copy link
    Contributor

    du82 commented Sep 19, 2022

    The wallet cards, browser card, and communities discover don't show anything

    @Parveshdhull
    Copy link
    Member Author

    The wallet cards, browser card, and communities discover don't show anything

    yes, they are currently not implemented. I will work on them later.

    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented Sep 19, 2022 •
    edited
    Loading

    we are currently focusing on redesign of messaging and communities first and will work on wallets and browser after that.

    @du82
    Copy link
    Contributor

    du82 commented Sep 19, 2022

    just out of curiosity, where can I find the current figma designs that you all are currently using?

    btw I didn't see any problems with the PR :)

    @Parveshdhull
    Copy link
    Member Author

    btw I didn't see any problems with the PR :)

    Awesome, thank you for testing.

    just out of curiosity, where can I find the current figma designs that you all are currently using?

    Redesign Issues also have their corresponding figma files in description.

    Components, Shell , Messaging, etc.

    @Parveshdhull Parveshdhull merged commit 0c83801 into develop Sep 19, 2022
    @Parveshdhull Parveshdhull deleted the feature/switcher-cards branch September 19, 2022 09:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @Parveshdhull Parveshdhull

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @Parveshdhull @status-im-auto @du82 @flexsurfer