Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix can't remove node 0 error breaking react-devtools #14316

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

yqrashawn
Copy link
Contributor

@yqrashawn yqrashawn commented Nov 10, 2022

You can now use the layout inspector in flipper now

Note:

status: ready

CleanShot 2022-11-10 at 15 47 40

@status-im-auto
Copy link
Member

status-im-auto commented Nov 10, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6338a75 #1 2022-11-10 07:53:52 ~2 min tests 📦log
✔️ 6338a75 #1 2022-11-10 08:00:19 ~9 min android 📦apk 📲
✔️ 6338a75 #1 2022-11-10 08:02:24 ~11 min android-e2e 📦apk 📲
✔️ 6338a75 #1 2022-11-10 08:06:16 ~15 min ios 📦ipa 📲
✔️ 8f66066 #2 2022-11-10 08:17:07 ~2 min tests 📦log
✔️ 8f66066 #2 2022-11-10 08:22:00 ~7 min android-e2e 📦apk 📲
✔️ 8f66066 #2 2022-11-10 08:27:09 ~12 min android 📦apk 📲
✔️ 8f66066 #2 2022-11-10 08:27:21 ~13 min ios 📦ipa 📲

Copy link
Member

@flexsurfer flexsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@status-im-auto
Copy link
Member

67% of end-end tests have passed

Total executed tests: 6
Failed tests: 2
Passed tests: 4
Not executed tests: 1
IDs of not executed tests: 702777 
IDs of failed tests: 702733,702745 

Not executed tests (1)

Click to expand
  • Rerun not executed tests
  • Failed tests (2)

    Click to expand
  • Rerun failed tests

  • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 1: Looking for chat: 'Silky Mixed Frogmouth'
    Device 1: Wait for element `Button` for max 30s and click when it is available

    critical/chats/test_1_1_public_chats.py:1319: in test_1_1_chat_text_message_delete_push_disappear
        self.home_1.get_chat(self.default_username_2).click()
    ../views/home_view.py:255: in get_chat
        self.notifications_unread_badge.wait_and_click(wait_time)
    ../views/base_element.py:369: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:134: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 1: Looking for chat: 'Silky Mixed Frogmouth'
    Device 1: Wait for element Button for max 30s and click when it is available

    critical/chats/test_1_1_public_chats.py:1279: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
        self.home_1.get_chat(self.default_username_2).click()
    ../views/home_view.py:255: in get_chat
        self.notifications_unread_badge.wait_and_click(wait_time)
    ../views/base_element.py:369: in wait_and_click
        self.wait_for_visibility_of_element(sec)
    ../views/base_element.py:134: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (4)

    Click to expand

    Class TestDeeplinkOneDevice:

    1. test_public_chat_open_using_deep_link, id: 702776
    Device sessions

    2. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 702774
    Device sessions

    3. test_deep_link_open_user_profile, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    @yqrashawn yqrashawn merged commit f5a61d9 into develop Nov 10, 2022
    @yqrashawn yqrashawn deleted the fix/react-devtool branch November 10, 2022 08:42
    @yqrashawn
    Copy link
    Contributor Author

    Seems remote debugging is not possible due to react-native-reanimated v2.x facebook/metro#731 (comment)

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    3 participants