nix: upgrade nixpkgs to latest nixos-23.05 #14944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (48)
|
jakubgs
force-pushed
the
nixpkgs-upgrade
branch
from
2e205d6 to
aeacf4c
Compare
|
Looks like something is broken with the loader for prebuilt |
|
This issue was introduced by this PR and commit due to a typo: I've fixed it in: |
jakubgs
force-pushed
the
nixpkgs-upgrade
branch
2 times, most recently
from
265fbf7 to
4010ca1
Compare
|
still relevant? |
|
It will be when the React Native upgrade goes through. |
flexsurfer
changed the title
|
@jakubgs is there the specific version we're waiting for? i believe one major upgrade has been merged already. |
|
Actually, now that we don't depend on Gradle 5 I could update this and get it merged: Line 60 in 56dbb77 Since just yesterday a new NixOS release was cut: Which no longer contains Gradle 5: So we can try using that now. Although I'm wondering if maybe I should take this opportunity and teach @yakimant about upgrade of |
jakubgs
changed the title
jakubgs
force-pushed
the
nixpkgs-upgrade
branch
2 times, most recently
from
5595d02 to
1d0c698
Compare
|
Looks like linting is failing with: Might be due to Clojure upgrade, or Clj-kondo upgrade, no idea. |
|
Also APK Analyzer fails to start: |
сс @yqrashawn could you take a look pls |
|
guess these checks are from clj-kondo |
|
thanks @yqrashawn , @jakubgs should be fixed now |
|
There's two failure modes for Which can be induced by changing from The other one seems to be due to inability to find Android SDK The only obvious change are just Android SDK So the surrounding tooling, the bash wrapper around the tool, or something about Android SDK must have changed. @yakimant I'd appreciate if you could investigate what's the issue here. The most likely fix will probably be somewhere in I have done some initial research into how |
|
Summary of investigation:
Tools versions
There are 2 possible solutions of upgrade issues:
|
|
I think upgrading to OpenJDK 11 is a good idea. We should do it eventually, so it would be good to try it Thanks for researching. |
|
We've switched:
As I see CI jobs pass succesfully, so we need some testing from Mobile developers. I also created an issue for broken |
|
@jakubgs I guess PR can be merged, if @jakubgs has more ideas what can be checked here - please share. |
Notable upgrades: * Bash `5.1` to `5.2` * Git `2.37.3` to `2.40.1` * Curl `7.85.0` to `8.0.1` * OpenSSL `3.0.5` to `3.0.8` * Go `1.18.6` to `1.18.9` * NodeJS `18.9.1` to `18.16.0` * Java `1.8.0_322` to `11.0.11` * Ruby `3.1.2` to `3.1.4` * Python `2.7.18` to `3.10.11` * Clojure `1.11.1.1165` to `1.11.1.1273` * Clj-kondo `v2022.10.05` to `v2023.04.14` * Zprint `1.2.5` to `1.2.6` * Bundler `2.3.22` to `2.4.13` * Gradle `6.9.2` to `6.9.4` * Android Platform Tools `33.0.2` to `33.0.3` * Android SDK Tools to Android SDK Command-Line Tools Removals: * Zprint since the version in `nixpkgs` was newer than in overlay. * Xcode wrapper definition was removed since my fixes were merged: - NixOS/nixpkgs#204278 - NixOS/nixpkgs#228696 Signed-off-by: Jakub Sokołowski <jakub@status.im>
This was referenced Jun 22, 2023
jakubgs
pushed a commit
that referenced
this pull request
Jun 24, 2023
Fixes following error: ``` ld: framework not found IOKit clang-11: error: linker command failed with exit code 1 (use -v to see invocation) make[1]: *** [status_nodejs_addon.target.mk:175: Release/status_nodejs_addon.node] Error 1 ``` The `make test` target started to fail on macOS after #14944. This PR adds 2 Apple SDK frameworks to default shell: `IOKit` and `CoreServices` The other 2 mentioned in `binding.gyp` are not added, but build is ok. Resolves: #16356 Signed-off-by: Jakub Sokołowski <jakub@status.im>
This was referenced Jun 26, 2023
Closed
yakimant
added a commit
that referenced
this pull request
Jun 27, 2023
watchman was upgraded significantly during the last #14944 (4.9.0 (Aug 16, 2017) to 2023.01.30.00 - 6 years between): status-im/nixpkgs@4e9c02b Probably causing developers to have "too many files open" issue #16341 This PR is an attempt to fix the issue by downgrading the watchman
yakimant
added a commit
that referenced
this pull request
Jun 30, 2023
watchman was upgraded significantly during the last #14944 (4.9.0 (Aug 16, 2017) to 2023.01.30.00 - 6 years between): status-im/nixpkgs@4e9c02b Probably causing developers to have "too many files open" issue #16341 This PR is an attempt to fix the issue by downgrading the watchman
jakubgs
added a commit
to status-im/status-go
that referenced
this pull request
Jun 30, 2023
To match the version we upgrade to in: status-im/status-mobile#14944 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-go
that referenced
this pull request
Jun 30, 2023
To match the version we upgrade to in: status-im/status-mobile#14944 I'm upgrading Protobuf to `3.19` since `3.17` is gone: ``` error: protobuf3_17 does not receive updates anymore and has been removed ``` Not sure if that's a big deal. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-go
that referenced
this pull request
Jun 30, 2023
To match the version we upgrade to in: status-im/status-mobile#14944 I'm upgrading Protobuf to `3.20` since `3.17` is gone: ``` error: protobuf3_17 does not receive updates anymore and has been removed ``` Not sure if that's a big deal. Signed-off-by: Jakub Sokołowski <jakub@status.im>
yakimant
added a commit
that referenced
this pull request
Jun 30, 2023
watchman was upgraded significantly during the last #14944 (4.9.0 (Aug 16, 2017) to 2023.01.30.00 - 6 years between): status-im/nixpkgs@4e9c02b Probably causing developers to have "too many files open" issue #16341 This PR is an attempt to fix the issue by downgrading the watchman
jakubgs
pushed a commit
that referenced
this pull request
Jul 2, 2023
watchman was upgraded significantly during the last #14944 (4.9.0 (Aug 16, 2017) to 2023.01.30.00 - 6 years between): status-im/nixpkgs@4e9c02b Probably causing developers to have "too many files open" issue #16341 This PR is an attempt to fix the issue by downgrading the watchman
jakubgs
pushed a commit
that referenced
this pull request
Jul 2, 2023
watchman was upgraded significantly during the last #14944 (4.9.0 (Aug 16, 2017) to 2023.01.30.00 - 6 years between): status-im/nixpkgs@4e9c02b Probably causing developers to have "too many files open" issue #16341 This PR is an attempt to fix the issue by downgrading the watchman Signed-off-by: Jakub Sokołowski <jakub@status.im>
codemaster115
pushed a commit
that referenced
this pull request
Jul 7, 2023
Fixes following error: ``` ld: framework not found IOKit clang-11: error: linker command failed with exit code 1 (use -v to see invocation) make[1]: *** [status_nodejs_addon.target.mk:175: Release/status_nodejs_addon.node] Error 1 ``` The `make test` target started to fail on macOS after #14944. This PR adds 2 Apple SDK frameworks to default shell: `IOKit` and `CoreServices` The other 2 mentioned in `binding.gyp` are not added, but build is ok. Resolves: #16356 Signed-off-by: Jakub Sokołowski <jakub@status.im>
codemaster115
pushed a commit
that referenced
this pull request
Jul 7, 2023
watchman was upgraded significantly during the last #14944 (4.9.0 (Aug 16, 2017) to 2023.01.30.00 - 6 years between): status-im/nixpkgs@4e9c02b Probably causing developers to have "too many files open" issue #16341 This PR is an attempt to fix the issue by downgrading the watchman Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-go
that referenced
this pull request
Aug 1, 2023
To match the version we upgrade to in: status-im/status-mobile#14944 I'm upgrading Protobuf to `3.20` since `3.17` is gone: ``` error: protobuf3_17 does not receive updates anymore and has been removed ``` Not sure if that's a big deal. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/status-go
that referenced
this pull request
Aug 2, 2023
To match the version we upgrade to in: status-im/status-mobile#14944 I'm upgrading Protobuf to `3.20` since `3.17` is gone: ``` error: protobuf3_17 does not receive updates anymore and has been removed ``` Not sure if that's a big deal. Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable upgrades:
5.1to5.22.37.3to2.40.17.85.0to8.0.13.0.5to3.0.81.18.6to1.18.918.9.1to18.16.01.8.0_322to1.8.0_3623.1.2to3.1.42.7.18to3.10.111.11.1.1165to1.11.1.1273v2022.10.05tov2023.04.141.2.5to1.2.66.9.2to6.9.42.3.22to2.3.2633.0.2to33.0.3Removals:
nixpkgswas newer than in overlay.