Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15128] Introduce muting for a specific duration #15253

Merged
merged 25 commits into from
Apr 16, 2023

Conversation

ibrkhalil
Copy link
Contributor

@ibrkhalil ibrkhalil commented Mar 5, 2023

fixes #15128

Summary

This PR Introduces muting a chat for a specific amount of time
QA notes: Kindly try to mute a chat from the home screen, It should be muted for one minute and then unmuted automatically .. We won't allow users to mute for a minute ofc but this is just to help QA team in testing
This is a PR to introduce the functionality that'll be used here
status: ready

@ibrkhalil ibrkhalil self-assigned this Mar 5, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Mar 5, 2023

Jenkins Builds

Click to see older builds (134)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 47360a5 #1 2023-03-05 17:52:19 ~9 min ios 📱ipa 📲
✔️ 47360a5 #1 2023-03-05 17:53:22 ~10 min android-e2e 🤖apk 📲
✔️ 47360a5 #1 2023-03-05 17:53:34 ~11 min android 🤖apk 📲
✔️ 8496705 #3 2023-03-05 18:26:58 ~8 min android 🤖apk 📲
✔️ 8496705 #3 2023-03-05 18:28:28 ~9 min android-e2e 🤖apk 📲
8496705 #3 2023-03-05 18:29:22 ~10 min tests 📄log
✔️ 8496705 #3 2023-03-05 18:29:25 ~10 min ios 📱ipa 📲
2bfb908 #4 2023-03-07 19:47:52 ~10 sec ios 📄log
2bfb908 #4 2023-03-07 19:47:54 ~12 sec android 📄log
2bfb908 #4 2023-03-07 19:47:55 ~13 sec android-e2e 📄log
2bfb908 #4 2023-03-07 19:47:57 ~11 sec tests 📄log
4ff261f #5 2023-03-08 05:28:46 ~12 sec android-e2e 📄log
4ff261f #5 2023-03-08 05:28:50 ~12 sec tests 📄log
4ff261f #5 2023-03-08 05:28:56 ~18 sec ios 📄log
4ff261f #5 2023-03-08 05:28:57 ~24 sec android 📄log
1fd2186 #6 2023-03-08 05:38:09 ~10 sec ios 📄log
1fd2186 #6 2023-03-08 05:38:11 ~11 sec android-e2e 📄log
1fd2186 #6 2023-03-08 05:38:11 ~12 sec android 📄log
1fd2186 #6 2023-03-08 05:38:14 ~11 sec tests 📄log
1ed6533 #7 2023-03-08 11:27:36 ~11 sec android-e2e 📄log
1ed6533 #7 2023-03-08 11:27:41 ~11 sec android 📄log
1ed6533 #7 2023-03-08 11:27:41 ~12 sec tests 📄log
1ed6533 #7 2023-03-08 11:27:42 ~13 sec ios 📄log
eea74af #8 2023-03-08 14:17:48 ~11 sec ios 📄log
eea74af #8 2023-03-08 14:17:48 ~12 sec android 📄log
eea74af #8 2023-03-08 14:17:49 ~13 sec android-e2e 📄log
eea74af #8 2023-03-08 14:18:12 ~36 sec tests 📄log
d4a9e67 #9 2023-03-08 14:31:23 ~12 sec android 📄log
d4a9e67 #9 2023-03-08 14:31:23 ~12 sec android-e2e 📄log
d4a9e67 #9 2023-03-08 14:31:26 ~10 sec ios 📄log
d4a9e67 #9 2023-03-08 14:31:28 ~12 sec tests 📄log
d891d11 #10 2023-03-08 14:43:39 ~17 sec ios 📄log
d891d11 #10 2023-03-08 14:47:21 ~3 min android-e2e 📄log
d891d11 #10 2023-03-08 14:47:31 ~4 min android 📄log
d891d11 #10 2023-03-08 14:47:34 ~4 min tests 📄log
6689ee2 #11 2023-03-12 10:31:29 ~12 sec ios 📄log
6689ee2 #11 2023-03-12 10:31:29 ~12 sec tests 📄log
6689ee2 #11 2023-03-12 10:31:29 ~12 sec android-e2e 📄log
6689ee2 #11 2023-03-12 10:31:30 ~13 sec android 📄log
2a3ad40 #12 2023-03-12 10:32:33 ~10 sec android-e2e 📄log
2a3ad40 #12 2023-03-12 10:32:38 ~10 sec ios 📄log
2a3ad40 #12 2023-03-12 10:32:38 ~11 sec tests 📄log
2a3ad40 #12 2023-03-12 10:32:38 ~12 sec android 📄log
c2a4851 #13 2023-03-12 10:34:08 ~10 sec android-e2e 📄log
c2a4851 #13 2023-03-12 10:34:13 ~10 sec ios 📄log
c2a4851 #13 2023-03-12 10:34:13 ~11 sec android 📄log
c2a4851 #13 2023-03-12 10:34:13 ~11 sec tests 📄log
5f4bbb7 #14 2023-03-12 10:40:38 ~3 min tests 📄log
902d60c #15 2023-03-12 10:48:19 ~3 min tests 📄log
902d60c #15 2023-03-12 10:49:31 ~4 min ios 📄log
✔️ f3c9d7a #16 2023-03-12 10:54:08 ~4 min tests 📄log
✔️ f3c9d7a #16 2023-03-12 10:57:33 ~7 min ios 📱ipa 📲
✔️ f3c9d7a #16 2023-03-12 10:58:15 ~8 min android-e2e 🤖apk 📲
✔️ f3c9d7a #16 2023-03-12 10:58:37 ~8 min android 🤖apk 📲
✔️ 439fd3a #17 2023-03-12 13:19:08 ~4 min tests 📄log
✔️ 439fd3a #17 2023-03-12 13:21:28 ~7 min android-e2e 🤖apk 📲
✔️ 439fd3a #17 2023-03-12 13:22:09 ~7 min ios 📱ipa 📲
✔️ 439fd3a #17 2023-03-12 13:22:38 ~8 min android 🤖apk 📲
✔️ db3bc4e #18 2023-03-12 13:30:03 ~5 min tests 📄log
✔️ db3bc4e #18 2023-03-12 13:33:36 ~8 min ios 📱ipa 📲
✔️ db3bc4e #18 2023-03-12 13:35:34 ~10 min android-e2e 🤖apk 📲
✔️ db3bc4e #18 2023-03-12 13:35:50 ~10 min android 🤖apk 📲
✔️ 0f326ce #19 2023-03-13 13:51:14 ~6 min tests 📄log
✔️ 0f326ce #19 2023-03-13 13:52:58 ~8 min ios 📱ipa 📲
✔️ 0f326ce #19 2023-03-13 13:53:51 ~9 min android-e2e 🤖apk 📲
✔️ 0f326ce #19 2023-03-13 13:55:31 ~11 min android 🤖apk 📲
✔️ 353379c #21 2023-03-13 15:09:32 ~5 min tests 📄log
✔️ 353379c #21 2023-03-13 15:13:53 ~9 min android 🤖apk 📲
✔️ 353379c #21 2023-03-13 15:14:17 ~10 min android-e2e 🤖apk 📲
✔️ 353379c #21 2023-03-13 15:15:00 ~11 min ios 📱ipa 📲
003d67c #22 2023-03-25 10:27:46 ~11 sec ios 📄log
003d67c #22 2023-03-25 10:27:59 ~24 sec android 📄log
003d67c #22 2023-03-25 10:28:10 ~39 sec android-e2e 📄log
003d67c #22 2023-03-25 10:28:13 ~37 sec tests 📄log
✔️ e7d903c #24 2023-03-25 10:40:09 ~7 min tests 📄log
✔️ e7d903c #24 2023-03-25 10:41:15 ~8 min ios 📱ipa 📲
✔️ e7d903c #24 2023-03-25 10:42:44 ~9 min android-e2e 🤖apk 📲
✔️ e7d903c #24 2023-03-25 10:43:08 ~10 min android 🤖apk 📲
✔️ ba0e62d #25 2023-03-27 08:16:46 ~8 min tests 📄log
✔️ ba0e62d #25 2023-03-27 08:17:14 ~9 min ios 📱ipa 📲
✔️ ba0e62d #25 2023-03-27 08:18:07 ~10 min android 🤖apk 📲
✔️ ba0e62d #25 2023-03-27 08:21:50 ~13 min android-e2e 🤖apk 📲
5cdc6bd #26 2023-03-29 19:59:43 ~15 sec ios 📄log
5cdc6bd #26 2023-03-29 20:01:05 ~1 min android-e2e 📄log
5cdc6bd #26 2023-03-29 20:01:21 ~1 min tests 📄log
5cdc6bd #26 2023-03-29 20:01:22 ~1 min android 📄log
71e0f5a #27 2023-04-03 07:39:34 ~12 sec android-e2e 📄log
71e0f5a #27 2023-04-03 07:39:38 ~12 sec tests 📄log
71e0f5a #27 2023-04-03 07:39:39 ~14 sec android 📄log
71e0f5a #27 2023-04-03 07:40:03 ~38 sec ios 📄log
✔️ cb9c0ee #28 2023-04-03 09:07:20 ~6 min tests 📄log
✔️ cb9c0ee #28 2023-04-03 09:09:24 ~9 min ios 📱ipa 📲
✔️ cb9c0ee #28 2023-04-03 09:11:02 ~10 min android-e2e 🤖apk 📲
✔️ cb9c0ee #28 2023-04-03 09:11:26 ~11 min android 🤖apk 📲
38ce888 #29 2023-04-05 11:59:17 ~11 sec android 📄log
38ce888 #29 2023-04-05 11:59:19 ~13 sec ios 📄log
38ce888 #29 2023-04-05 11:59:21 ~12 sec tests 📄log
38ce888 #29 2023-04-05 11:59:28 ~22 sec android-e2e 📄log
✔️ f6ec489 #30 2023-04-05 12:11:59 ~6 min tests 📄log
✔️ f6ec489 #30 2023-04-05 12:12:34 ~6 min ios 📱ipa 📲
✔️ f6ec489 #30 2023-04-05 12:14:34 ~8 min android-e2e 🤖apk 📲
✔️ f6ec489 #30 2023-04-05 12:14:49 ~8 min android 🤖apk 📲
a998272 #31 2023-04-08 14:47:44 ~13 sec ios 📄log
a998272 #31 2023-04-08 14:47:53 ~22 sec android-e2e 📄log
a998272 #31 2023-04-08 14:47:55 ~23 sec android 📄log
a998272 #31 2023-04-08 14:47:58 ~27 sec tests 📄log
a297db4 #32 2023-04-08 15:21:33 ~12 sec tests 📄log
a297db4 #32 2023-04-08 15:21:34 ~13 sec ios 📄log
a297db4 #32 2023-04-08 15:21:44 ~24 sec android 📄log
a297db4 #32 2023-04-08 15:21:45 ~24 sec android-e2e 📄log
f87a127 #33 2023-04-08 19:47:23 ~11 sec android-e2e 📄log
f87a127 #33 2023-04-08 19:47:27 ~11 sec tests 📄log
f87a127 #33 2023-04-08 19:47:29 ~13 sec ios 📄log
f87a127 #33 2023-04-08 19:47:30 ~14 sec android 📄log
✔️ 98b01fa #34 2023-04-08 19:58:49 ~9 min ios 📱ipa 📲
✔️ 98b01fa #34 2023-04-08 20:00:21 ~10 min android-e2e 🤖apk 📲
✔️ 98b01fa #34 2023-04-08 20:00:36 ~11 min android 🤖apk 📲
✔️ 3b0bc32 #35 2023-04-10 14:28:07 ~6 min tests 📄log
✔️ 3b0bc32 #35 2023-04-10 14:29:18 ~8 min ios 📱ipa 📲
✔️ 3b0bc32 #35 2023-04-10 14:32:13 ~11 min android 🤖apk 📲
✔️ 3b0bc32 #35 2023-04-10 14:34:21 ~13 min android-e2e 🤖apk 📲
919e607 #37 2023-04-10 14:42:09 ~1 min android 📄log
919e607 #37 2023-04-10 14:42:22 ~1 min ios 📄log
919e607 #37 2023-04-10 14:42:41 ~1 min tests 📄log
919e607 #37 2023-04-10 14:42:50 ~2 min android-e2e 📄log
919e607 #38 2023-04-10 14:46:01 ~1 min android 📄log
9955f88 #38 2023-04-11 08:13:03 ~14 sec ios 📄log
9955f88 #39 2023-04-11 08:13:15 ~27 sec android 📄log
9955f88 #38 2023-04-11 08:13:18 ~28 sec tests 📄log
9955f88 #38 2023-04-11 08:13:22 ~35 sec android-e2e 📄log
✔️ 25cfdd2 #40 2023-04-11 08:28:50 ~8 min tests 📄log
✔️ 25cfdd2 #40 2023-04-11 08:31:28 ~10 min ios 📱ipa 📲
✔️ 25cfdd2 #40 2023-04-11 08:31:49 ~11 min android-e2e 🤖apk 📲
✔️ 25cfdd2 #41 2023-04-11 08:32:12 ~11 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
0fa1ba2 #42 2023-04-16 15:18:22 ~5 min tests 📄log
✔️ 0fa1ba2 #43 2023-04-16 15:20:58 ~7 min android 🤖apk 📲
✔️ 0fa1ba2 #42 2023-04-16 15:21:12 ~7 min android-e2e 🤖apk 📲
✔️ 4dcb635 #43 2023-04-16 15:28:55 ~6 min tests 📄log
✔️ 4dcb635 #43 2023-04-16 15:31:04 ~8 min android-e2e 🤖apk 📲
✔️ 4dcb635 #44 2023-04-16 15:31:10 ~8 min android 🤖apk 📲
✔️ 4dcb635 #43 2023-04-16 15:31:16 ~8 min ios 📱ipa 📲

@ibrkhalil ibrkhalil marked this pull request as ready for review March 8, 2023 05:37
@ibrkhalil ibrkhalil requested review from flexsurfer, ilmotta, rasom and Parveshdhull and removed request for flexsurfer March 8, 2023 05:37
[{:keys [db]} chat-id muted?]
(let [method (if muted? "wakuext_muteChat" "wakuext_unmuteChat")]
[{:keys [db]} chat-id muted? mute-type]
(let [method (if muted? "wakuext_muteChatV2" "wakuext_unmuteChat")
Copy link
Contributor Author

@ibrkhalil ibrkhalil Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna have to go with a V2 naming to not break desktop muting functionality

src/status_im/ui/screens/profile/contact/views.cljs Outdated Show resolved Hide resolved
src/status_im2/common/mute_chat_drawer/view.cljs Outdated Show resolved Hide resolved
src/status_im2/common/mute_chat_drawer/view.cljs Outdated Show resolved Hide resolved
src/status_im2/common/mute_chat_drawer/view.cljs Outdated Show resolved Hide resolved
src/status_im2/common/mute_chat_drawer/view.cljs Outdated Show resolved Hide resolved
src/status_im2/common/mute_chat_drawer/view.cljs Outdated Show resolved Hide resolved
@pavloburykh
Copy link
Contributor

Hey @ibrkhalil ! Could you please rebase the PR and resolve conflicts? If it is ready for testing feel free to move it to E2E column. Thanx.

@ibrkhalil ibrkhalil force-pushed the mute-for-specific-amount-of-time branch from 003d67c to d8cb727 Compare March 25, 2023 10:32
@status-im-auto
Copy link
Member

0% of end-end tests have passed

Total executed tests: 7
Failed tests: 7
Passed tests: 0
Not executed tests: 22
IDs of not executed tests: 702730,702782,702731,702745,702813,702855,702733,702783,702784,702838,702843,702839,702840,702841,702844,702894,702845,702786,702846,702742,702850,702851 
IDs of failed tests: 702947,702958,702732,702807,702936,702957,702808 

Not executed tests (22)

Click to expand
  • Rerun not executed tests
  • Failed tests (7)

    Click to expand
  • Rerun failed tests

  • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Test setup failed: critical/chats/test_group_chat.py:153: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:35: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:199: in create_user
        self.chats_tab.wait_for_visibility_of_element(30)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
    



    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 1: Tap on found: Button
    Device 2: Tap on found: Button

    Test setup failed: critical/chats/test_group_chat.py:153: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:35: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:199: in create_user
        self.chats_tab.wait_for_visibility_of_element(30)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    3. test_group_chat_offline_pn, id: 702808

    Test setup failed: critical/chats/test_group_chat.py:153: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:35: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:199: in create_user
        self.chats_tab.wait_for_visibility_of_element(30)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
    



    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Test setup failed: medium/test_activity_center.py:186: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:35: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:199: in create_user
        self.chats_tab.wait_for_visibility_of_element(30)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
    



    2. test_activity_center_admin_notification_accept_swipe, id: 702958

    Test setup failed: medium/test_activity_center.py:186: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:35: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:199: in create_user
        self.chats_tab.wait_for_visibility_of_element(30)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
    



    3. test_navigation_jump_to, id: 702936

    Device 1: Find Button by xpath: //*[@text="Next"]
    Device 1: Tap on found: Button

    Test setup failed: medium/test_activity_center.py:186: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:35: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:199: in create_user
        self.chats_tab.wait_for_visibility_of_element(30)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    4. test_activity_center_mentions, id: 702957

    Test setup failed: medium/test_activity_center.py:186: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:35: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:199: in create_user
        self.chats_tab.wait_for_visibility_of_element(30)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
    



    @ibrkhalil ibrkhalil force-pushed the mute-for-specific-amount-of-time branch 2 times, most recently from 38ce888 to f6ec489 Compare April 5, 2023 12:05
    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 5, 2023
    @status-im-auto
    Copy link
    Member

    40% of end-end tests have passed

    Total executed tests: 25
    Failed tests: 15
    Passed tests: 10
    Not executed tests: 4
    
    IDs of not executed tests: 702846,702742,702850,702851 
    
    IDs of failed tests: 702843,702839,702957,702947,702844,702784,702808,702841,702838,702840,702786,702745,702958,702845,702894 
    

    Not executed tests (4)

    Click to expand
  • Rerun not executed tests
  • Failed tests (15)

    Click to expand
  • Rerun failed tests

  • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    # STEP: check that messages are shown for every member
    Device 1: Looking for a message by text: message from old member

    critical/chats/test_group_chat.py:259: in test_group_chat_offline_pn
        if not self.chats[i].chat_element_by_text(message).is_element_displayed(30):
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    2. test_community_message_delete, id: 702839

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    4. test_community_unread_messages_badge, id: 702841

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    5. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Looking for chat: 'general'
    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed' 
    

    [[blocked by 14797]]

    Device sessions

    6. test_community_emoji_send_copy_paste_reply, id: 702840

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    7. test_community_mentions_push_notification, id: 702786

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    8. test_community_leave, id: 702845

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    9. test_community_contact_block_unblock_offline, id: 702894

    Test setup failed: critical/test_public_chat_browsing.py:404: in prepare_devices
        community_view.get_channel(self.channel_name).click()
    ../views/home_view.py:54: in click
        self.click_until_presence_of_element(desired_element=desired_element)
    ../views/base_element.py:99: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:193: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:133: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:71: in until
        value = method(self._driver)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:128: in __call__
        return _element_if_visible(_find_element(driver, self.locator))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:148: in _element_if_visible
        return element if element.is_displayed() == visibility else False
     'dict' object has no attribute 'is_displayed'
    



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784

    ## Sign in (password:qwerty1234, keycard:False)
    Device 2: Find EditBox by accessibility id: password-input

    critical/chats/test_1_1_public_chats.py:1317: in test_1_1_chat_delete_via_long_press_relogin
        self.home_2.reopen_app()
    ../views/base_view.py:612: in reopen_app
        sign_in_view.sign_in(password)
    ../views/sign_in_view.py:266: in sign_in
        self.password_input.set_value(password)
    ../views/base_element.py:352: in set_value
        self.find_element().set_value(value)
     'dict' object has no attribute 'set_value'
    



    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Looking for a message by text: profile_photo
    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']

    critical/chats/test_1_1_public_chats.py:1135: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
        if self.chat_2.chat_element_by_text(message).member_photo.is_element_differs_from_template("member3.png",
    ../views/base_element.py:251: in is_element_differs_from_template
        difference = ImageChops.difference(self.image, self.template)
    ../views/base_element.py:224: in image
        return Image.open(BytesIO(base64.b64decode(self.find_element().screenshot_as_base64)))
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:557: in screenshot_as_base64
        return self._execute(Command.ELEMENT_SCREENSHOT)['value']
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:633: in _execute
        return self._parent.execute(command, params)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
        self.error_handler.check_response(response)
    /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
        raise wde
    /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
        super().check_response(response)
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response
        raise exception_class(message, screen, stacktrace)
     Failed to capture a screenshot. Does the current view have 'secure' flag set?
    



    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957

    Device 1: Looking for activity center element: '@user1'
    Device 1: Find Button by xpath: //*[contains(@text, '@user1')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-title"]

    medium/test_activity_center.py:356: in test_activity_center_mentions
        if mention_element.title.text != 'Mention':
    ../views/base_element.py:209: in text
        return self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by xpath: `//*[contains(@text, '@user1')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-title"]` is not found on the screen 
    

    [[Blocked by 15500]]

    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    # STEP: Mark it as read and check filter
    Device 1: Swiping right on element ActivityCenterElement

    medium/test_activity_center.py:297: in test_activity_center_reply_read_unread_delete_filter_swipe
        reply_element.swipe_right_on_element()
    ../views/base_element.py:280: in swipe_right_on_element
        location, size = self.get_element_coordinates()
    ../views/base_element.py:268: in get_element_coordinates
        size = element.size
    /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:519: in size
        new_size = {"height": size["height"],
     'height'
    



    Device sessions

    3. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 1: Tap on found: Button
    Device 1: Find ChatButton by accessibility id: communities-button

    medium/test_activity_center.py:381: in test_activity_center_admin_notification_accept_swipe
        self.home_1.create_community(name=community_name, description='community to test', require_approval=True)
    ../views/home_view.py:383: in create_community
        chat_view = self.communities_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: ChatButton by accessibility id: `communities-button` is not found on the screen 
    

    [[Blocked by 15500]]

    Device sessions

    Passed tests (10)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_pin_messages, id: 702732
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    @xAlisher
    Copy link

    I agree! We didn't design it specifically, but what you are suggesting makes sense to me.

    @VolodLytvynenko
    Copy link
    Contributor

    VolodLytvynenko commented Apr 11, 2023

    Shouldn't we bring back the indicatior on unmute?, I think that's how Telegram and WhatsApp work and personally I think it's nicer to let the user know he missed X amount of messages. CC: @xAlisher

    thanx for clarifying this with @xAlisher . I thought this is an issue but this is a feature :)

    @VolodLytvynenko
    Copy link
    Contributor

    @xAlisher when the chat is muted, should an unread indicator and an unread counter appear just for the chat preview, or also it should cause appearing of old unread messages in the activity center as well?

    As for me, it is better not to show them in AC (for not to annoy the user). And now it is implemented so.

    So, if the muted chat is unmuted, then the unread indicator or unread counter will appear in the chat preview and in the chat tab icon (on the screen) if some unread messages were sent when the chat was muted.
    Just want to confirm it from your side also
    image

    @status-im-auto
    Copy link
    Member

    79% of end-end tests have passed

    Total executed tests: 29
    Failed tests: 6
    Passed tests: 23
    
    IDs of failed tests: 702745,702786,702850,702731,702838,702742 
    

    Failed tests (6)

    Click to expand
  • Rerun failed tests

  • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find `Button` by `accessibility id`: `tab-recent`
    Device 2: Tap on found: Button

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
        self.errors.verify_no_errors()
    base_test_case.py:184: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Username is not shown on 'Add contact' page after entering valid public key 
    

    [[Blocked by 15500]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Looking for a message by text: hello
    Device 2: Find TimeStampText by xpath: //*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp']

    critical/chats/test_1_1_public_chats.py:1118: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
        timestamp = self.chat_2.chat_element_by_text(messages[0]).timestamp
    ../views/chat_view.py:162: in timestamp
        return TimeStampText(self.driver, self.locator).text
    ../views/base_element.py:209: in text
        return self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: TimeStampText by xpath: `//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp']` is not found on the screen
    



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731

    Device 2: Looking for a message by text: Message 2
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'Message 2')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']

    critical/chats/test_1_1_public_chats.py:1022: in test_1_1_chat_pin_messages
        self.chat_2.pin_message(self.message_2, 'pin-to-chat')
    ../views/chat_view.py:947: in pin_message
        self.chat_element_by_text(message).long_press_until_element_is_shown(element)
    ../views/base_element.py:298: in long_press_until_element_is_shown
        element = self.find_element()
    ../views/chat_view.py:134: in find_element
        self.wait_for_visibility_of_element(20)
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'Message 2')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Find ChatMessageInput by accessibility id: chat-message-input
    Device 2: Type @ to ChatMessageInput

    ../views/chat_view.py:1142: in mention_user
        mentions_list = self.mentions_list.wait_for_element()
    ../views/base_element.py:117: in wait_for_element
        raise TimeoutException(
     Device `2`: `BaseElement` by` accessibility id`: `mentions-list` is not found on the screen after wait_for_element
    
    During handling of the above exception, another exception occurred:
    critical/test_public_chat_browsing.py:666: in test_community_mentions_push_notification
        self.channel_2.mention_user(self.default_username_1)
    ../views/chat_view.py:1145: in mention_user
        self.driver.fail("Mentions list is not shown")
    base_test_case.py:172: in fail
        pytest.fail('Device %s: %s' % (self.number, text))
    E   Failed: Device 2: Mentions list is not shown
    



    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
        channel.verify_message_is_under_today_text(message, self.errors)
    ../views/chat_view.py:923: in verify_message_is_under_today_text
        message_element.wait_for_visibility_of_element()
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element 
    

    [[blocked by 14797]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Find ChatMessageInput by accessibility id: chat-message-input
    Device 1: Clear text in ChatMessageInput

    critical/test_public_chat_browsing.py:352: in test_community_copy_and_paste_message_in_chat_input
        self.errors.verify_no_errors()
    base_test_case.py:184: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Message mmmeowesage_text text was not copied in community channel
    E    Message https://status.im text was not copied in community channel
    



    Device sessions

    Passed tests (23)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @xAlisher
    Copy link

    @xAlisher when the chat is muted, should an unread indicator and an unread counter appear just for the chat preview, or also it should cause appearing of old unread messages in the activity center as well?

    As for me, it is better not to show them in AC (for not to annoy the user). And now it is implemented so.

    So, if the muted chat is unmuted, then the unread indicator or unread counter will appear in the chat preview and in the chat tab icon (on the screen) if some unread messages were sent when the chat was muted. Just want to confirm it from your side also image

    After unmuting badge appears only on the list. (Not notifying in a bottom bar, but not marked as read)
    image

    @ibrkhalil
    Copy link
    Contributor Author

    @xAlisher when the chat is muted, should an unread indicator and an unread counter appear just for the chat preview, or also it should cause appearing of old unread messages in the activity center as well?
    As for me, it is better not to show them in AC (for not to annoy the user). And now it is implemented so.
    So, if the muted chat is unmuted, then the unread indicator or unread counter will appear in the chat preview and in the chat tab icon (on the screen) if some unread messages were sent when the chat was muted. Just want to confirm it from your side also image

    After unmuting badge appears only on the list. (Not notifying in a bottom bar, but not marked as read) image

    In the screenshot, the bottom bar doesn't show a counter of unread messages for chats who are never muted.

    @status-im-auto
    Copy link
    Member

    90% of end-end tests have passed

    Total executed tests: 29
    Failed tests: 3
    Passed tests: 26
    
    IDs of failed tests: 702840,702850,702838 
    

    Failed tests (3)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 1: Find `RepliedMessageText` by `xpath`: `//*[starts-with(@text,'test message')]/preceding::android.widget.TextView[@content-desc='quoted-message']`
    Device 1: `RepliedMessageText` is `🤷🏼`

    critical/test_public_chat_browsing.py:482: in test_community_emoji_send_copy_paste_reply
        self.errors.verify_no_errors()
    base_test_case.py:184: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Emoji message was not copied
    



    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
        channel.verify_message_is_under_today_text(message, self.errors)
    ../views/chat_view.py:923: in verify_message_is_under_today_text
        message_element.wait_for_visibility_of_element()
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element 
    

    [[blocked by 14797]]

    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: tab-recent
    Device 2: Tap on found: Button

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
        self.errors.verify_no_errors()
    base_test_case.py:184: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Username is not shown on 'Add contact' page after entering valid public key 
    

    [[Blocked by 15500]]

    Device sessions

    Passed tests (26)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @ibrkhalil Thank you for your work. PR is ready to be merged

    @ibrkhalil ibrkhalil merged commit 8af7011 into develop Apr 16, 2023
    @ibrkhalil ibrkhalil deleted the mute-for-specific-amount-of-time branch April 16, 2023 15:31
    @pavloburykh
    Copy link
    Contributor

    QA notes: Kindly try to mute a chat from the home screen, It should be muted for one minute and then unmuted automatically .. We won't allow users to mute for a minute ofc but this is just to help QA team in testing

    Hey @ibrkhalil ! Could you please elaborate, what is current muting time for chats (1-1, group chat) in develop? I suppose it is till unmute?
    Will be mute period menu (screenshot below) implanted for chats as it we do it for communities and channels? Was not able to find ticket for this feature.

    Settings for Mobile – Figma 2023-05-12 17-03-38

    @ibrkhalil
    Copy link
    Contributor Author

    QA notes: Kindly try to mute a chat from the home screen, It should be muted for one minute and then unmuted automatically .. We won't allow users to mute for a minute ofc but this is just to help QA team in testing

    Hey @ibrkhalil ! Could you please elaborate, what is current muting time for chats (1-1, group chat) in develop? I suppose it is till unmute?

    Will be mute period menu (screenshot below) implanted for chats as it we do it for communities and channels? Was not able to find ticket for this feature.

    Settings for Mobile – Figma 2023-05-12 17-03-38

    I thought we were going to do the same for chats

    I added it here actually
    #15128

    1 similar comment
    @ibrkhalil
    Copy link
    Contributor Author

    QA notes: Kindly try to mute a chat from the home screen, It should be muted for one minute and then unmuted automatically .. We won't allow users to mute for a minute ofc but this is just to help QA team in testing

    Hey @ibrkhalil ! Could you please elaborate, what is current muting time for chats (1-1, group chat) in develop? I suppose it is till unmute?

    Will be mute period menu (screenshot below) implanted for chats as it we do it for communities and channels? Was not able to find ticket for this feature.

    Settings for Mobile – Figma 2023-05-12 17-03-38

    I thought we were going to do the same for chats

    I added it here actually
    #15128

    @pavloburykh
    Copy link
    Contributor

    I thought we were going to do the same for chats

    I added it here actually #15128

    Oh, cool, thank you. I didn't notice it because I thought that this PR is related to channels only.

    @ibrkhalil
    Copy link
    Contributor Author

    I thought we were going to do the same for chats
    I added it here actually #15128

    Oh, cool, thank you. I didn't notice it because I thought that this PR is related to channels only.

    It is, But I though it wouldn't make sense to have a feature in one part and to have it missing in a really similar part.

    @xAlisher
    Copy link

    @xAlisher when the chat is muted, should an unread indicator and an unread counter appear just for the chat preview, or also it should cause appearing of old unread messages in the activity center as well?

    As for me, it is better not to show them in AC (for not to annoy the user). And now it is implemented so.

    So, if the muted chat is unmuted, then the unread indicator or unread counter will appear in the chat preview and in the chat tab icon (on the screen) if some unread messages were sent when the chat was muted. Just want to confirm it from your side also image

    If the user has not been in this muted chat and has not seen the messages in the viewing window, an icon should appear after unmuting.

    @VolodLytvynenko
    Copy link
    Contributor

    @xAlisher when the chat is muted, should an unread indicator and an unread counter appear just for the chat preview, or also it should cause appearing of old unread messages in the activity center as well?
    As for me, it is better not to show them in AC (for not to annoy the user). And now it is implemented so.
    So, if the muted chat is unmuted, then the unread indicator or unread counter will appear in the chat preview and in the chat tab icon (on the screen) if some unread messages were sent when the chat was muted. Just want to confirm it from your side also image

    After unmuting badge appears only on the list. (Not notifying in a bottom bar, but not marked as read) image

    In the screenshot, the bottom bar doesn't show a counter of unread messages for chats who are never muted.

    Design team answer
    image

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    7 participants