Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove contact from mutual contact list after contact is blocked #15579

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix: remove contact from mutual contact list after contact is blocked #15579

merged 2 commits into from
Apr 20, 2023

Conversation

jo-mut
Copy link
Contributor

@jo-mut jo-mut commented Apr 5, 2023 •
edited
Loading

fixes #15279

Summary

This pr removes user A (the blocked contact) from the contact list of user B once blocked and removes user B from user A list of contacts

@jo-mut jo-mut self-assigned this Apr 5, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Apr 5, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (43)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 74372cc #1 2023-04-05 10:17:10 ~7 min tests 📄log
✔️ 74372cc #1 2023-04-05 10:17:19 ~7 min ios 📱ipa 📲
✔️ 74372cc #1 2023-04-05 10:18:30 ~8 min android 🤖apk 📲
✔️ 74372cc #1 2023-04-05 10:19:15 ~9 min android-e2e 🤖apk 📲
✔️ f3d7670 #2 2023-04-05 18:32:02 ~5 min tests 📄log
✔️ f3d7670 #2 2023-04-05 18:33:29 ~7 min ios 📱ipa 📲
✔️ f3d7670 #2 2023-04-05 18:34:00 ~7 min android-e2e 🤖apk 📲
✔️ f3d7670 #2 2023-04-05 18:34:52 ~8 min android 🤖apk 📲
✔️ 10b29bc #3 2023-04-07 20:53:53 ~7 min tests 📄log
✔️ 10b29bc #3 2023-04-07 20:54:02 ~7 min ios 📱ipa 📲
✔️ 10b29bc #3 2023-04-07 21:02:59 ~16 min android 🤖apk 📲
✔️ 10b29bc #3 2023-04-07 21:03:09 ~16 min android-e2e 🤖apk 📲
✔️ afc10bd #4 2023-04-10 09:21:56 ~7 min tests 📄log
✔️ afc10bd #4 2023-04-10 09:22:50 ~8 min android-e2e 🤖apk 📲
✔️ afc10bd #4 2023-04-10 09:23:16 ~8 min ios 📱ipa 📲
✔️ afc10bd #4 2023-04-10 09:23:52 ~9 min android 🤖apk 📲
✔️ bdef700 #5 2023-04-10 16:11:34 ~6 min tests 📄log
✔️ bdef700 #5 2023-04-10 16:12:19 ~7 min android-e2e 🤖apk 📲
✔️ bdef700 #5 2023-04-10 16:13:14 ~8 min android 🤖apk 📲
✔️ bdef700 #5 2023-04-10 16:14:33 ~9 min ios 📱ipa 📲
✔️ 62ad5a5 #6 2023-04-11 10:11:13 ~5 min tests 📄log
✔️ 62ad5a5 #6 2023-04-11 10:12:30 ~7 min ios 📱ipa 📲
✔️ 62ad5a5 #6 2023-04-11 10:13:46 ~8 min android-e2e 🤖apk 📲
✔️ 62ad5a5 #6 2023-04-11 10:14:12 ~9 min android 🤖apk 📲
✔️ 96e9ab5 #8 2023-04-14 02:37:56 ~8 min android 🤖apk 📲
✔️ 96e9ab5 #8 2023-04-14 02:38:16 ~8 min tests 📄log
✔️ 96e9ab5 #8 2023-04-14 02:38:40 ~8 min ios 📱ipa 📲
✔️ 96e9ab5 #8 2023-04-14 02:38:46 ~9 min android-e2e 🤖apk 📲
✔️ 701a53c #9 2023-04-14 12:30:06 ~5 min android-e2e 🤖apk 📲
✔️ 701a53c #9 2023-04-14 12:30:51 ~6 min android 🤖apk 📲
✔️ 701a53c #9 2023-04-14 12:31:05 ~6 min tests 📄log
✔️ 701a53c #9 2023-04-14 12:51:30 ~27 min ios 📱ipa 📲
✔️ 00a3aee #10 2023-04-14 15:02:43 ~7 min tests 📄log
✔️ 00a3aee #10 2023-04-14 15:04:45 ~9 min android 🤖apk 📲
✔️ 00a3aee #10 2023-04-14 15:04:46 ~9 min android-e2e 🤖apk 📲
✔️ 00a3aee #10 2023-04-14 15:04:54 ~9 min ios 📱ipa 📲
✔️ 2a3f9ef #11 2023-04-17 19:59:56 ~5 min android 🤖apk 📲
✔️ 2a3f9ef #11 2023-04-17 20:03:32 ~9 min android-e2e 🤖apk 📲
✔️ 2a3f9ef #11 2023-04-17 20:04:50 ~10 min ios 📱ipa 📲
✔️ abf1cf0 #13 2023-04-18 15:09:01 ~7 min tests 📄log
✔️ abf1cf0 #12 2023-04-18 15:10:42 ~8 min android 🤖apk 📲
✔️ abf1cf0 #12 2023-04-18 15:10:58 ~8 min android-e2e 🤖apk 📲
✔️ abf1cf0 #12 2023-04-18 15:13:01 ~10 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9eef676 #13 2023-04-19 13:46:41 ~5 min android 🤖apk 📲
✔️ 9eef676 #13 2023-04-19 13:49:06 ~7 min android-e2e 🤖apk 📲
✔️ 9eef676 #13 2023-04-19 13:49:29 ~8 min ios 📱ipa 📲
✔️ 9eef676 #14 2023-04-19 13:49:37 ~8 min tests 📄log
❌ 340ce04 #14 2023-04-20 16:19:31 ~3 min ios 📄log
✔️ 340ce04 #14 2023-04-20 16:28:44 ~12 min android-e2e 🤖apk 📲
✔️ 340ce04 #15 2023-04-20 16:29:13 ~13 min tests 📄log
✔️ 340ce04 #14 2023-04-20 16:29:36 ~13 min android 🤖apk 📲
✔️ 340ce04 #15 2023-04-20 17:43:08 ~8 min ios 📱ipa 📲

@jo-mut jo-mut force-pushed the jmn/fix-blocked-user branch 2 times, most recently from f3d7670 to 10b29bc Compare April 7, 2023 20:46
ibrkhalil
ibrkhalil reviewed Apr 8, 2023
View reviewed changes
src/status_im/contact/block.cljs
Comment on lines 62 to +64
(assoc :blocked? true
:added? false))
:added? false
:active? false))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set the mutual? attribute to false too ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibrkhalil does not seem to have any effect but it can be set to false since the two contacts in this context are no longer mutual the moment one becomes blocked

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you are right

@VolodLytvynenko
Copy link
Contributor

Hi @jo-mut let me know please if this PR is ready for tests

@jo-mut
Copy link
Contributor Author

jo-mut commented Apr 10, 2023

@VladimrLitvinenko this is ready you can proceed with the testing. Thanks

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 29
Failed tests: 4
Passed tests: 25

IDs of failed tests: 702745,702850,702731,702838

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Looking for a message by text: hello
    Device 2: Find `TimeStampText` by `xpath`: `//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp']` 

    critical/chats/test_1_1_public_chats.py:1118: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    timestamp = self.chat_2.chat_element_by_text(messages[0]).timestamp
../views/chat_view.py:162: in timestamp
    return TimeStampText(self.driver, self.locator).text
../views/base_element.py:209: in text
    return self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: TimeStampText by xpath: `//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-timestamp']` is not found on the screen



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731

    Device 2: Looking for a message by text: Message 2
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'Message 2')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/chats/test_1_1_public_chats.py:1022: in test_1_1_chat_pin_messages
    self.chat_2.pin_message(self.message_2, 'pin-to-chat')
../views/chat_view.py:947: in pin_message
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:298: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'Message 2')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: tab-recent
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (25)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    @pavloburykh pavloburykh self-assigned this Apr 11, 2023
    @pavloburykh
    Copy link
    Contributor

    @jo-mut thanx for the PR.

    Initial issue misses the case with contact removal after which contact list is not being updated too. Is it possible to cover contact removal case by this PR?

    ISSUE 1 Removed contact is shown in contact list until app reopening or opening removed user profile screen

    Preconditions: User A and User B are contacts

    Steps:

    1. User A removes User B from contacts
    2. See if User B has been removed from User's A contact list

    Actual result: User B remains in User's A contact list until app reopening or opening removed user profile screen

    telegram-cloud-document-2-5307848119155697470.mp4

    @status-im-auto
    Copy link
    Member

    90% of end-end tests have passed

    Total executed tests: 29
Failed tests: 3
Passed tests: 26

    IDs of failed tests: 702840,702850,702838

    Failed tests (3)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 1: Find `RepliedMessageText` by `xpath`: `//*[starts-with(@text,'test message')]/preceding::android.widget.TextView[@content-desc='quoted-message']`
    Device 1: `RepliedMessageText` is `🚣‍♀️` 

    critical/test_public_chat_browsing.py:482: in test_community_emoji_send_copy_paste_reply
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Emoji message was not copied



    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: tab-recent
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Passed tests (26)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 13, 2023
    @VolodLytvynenko VolodLytvynenko removed their assignment Apr 13, 2023
    @jo-mut
    Copy link
    Contributor Author

    jo-mut commented Apr 13, 2023 •
    edited
    Loading

    @pavloburykh currently this pr as is removes User B from User's A list of contacts. I will update the pr so that user B is also removed from user A list contact.

    Screen_Recording_20230411_154758_Status.Debug.mov

    @jo-mut
    Copy link
    Contributor Author

    jo-mut commented Apr 14, 2023

    @pavloburykh I have updated the pr so that both contact are removed from each others list but just before you run the tests I would like to take another look at status-go please hold on running tests on this for a while

    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 14, 2023
    @churik
    Copy link
    Member

    churik commented Apr 14, 2023

    Also please note this behavior now: currently after blocking/removing a user, it disappears from the contact list only after reopening this list.
    It would be nice to address this issue here as well.

    Thank you!

    @jo-mut jo-mut force-pushed the jmn/fix-blocked-user branch 2 times, most recently from 701a53c to 00a3aee Compare April 14, 2023 14:54
    @jo-mut
    Copy link
    Contributor Author

    jo-mut commented Apr 14, 2023

    @pavloburykh this is ready. Thanks

    @flexsurfer
    Copy link
    Member

    hey @jo-mut could you please rebase and more to e2e

    @jo-mut jo-mut force-pushed the jmn/fix-blocked-user branch 2 times, most recently from 6797684 to abf1cf0 Compare April 18, 2023 15:00
    @status-im-auto
    Copy link
    Member

    93% of end-end tests have passed

    Total executed tests: 29
Failed tests: 2
Passed tests: 27

    IDs of failed tests: 702838,702850

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find `Button` by `accessibility id`: `tab-recent`
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (27)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    7. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    8. test_1_1_chat_edit_message, id: 702855
    Device sessions

    9. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    2. test_community_message_delete, id: 702839
    Device sessions

    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    4. test_community_unread_messages_badge, id: 702841
    Device sessions

    5. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    6. test_community_mentions_push_notification, id: 702786
    Device sessions

    7. test_community_leave, id: 702845
    Device sessions

    8. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_pin_messages, id: 702732
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi @jo-mut, thank you for PR. no issues from my side. PR is ready to be merged

    @jo-mut jo-mut merged commit 9e5c7cd into develop Apr 20, 2023
    @jo-mut jo-mut deleted the jmn/fix-blocked-user branch April 20, 2023 17:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil left review comments

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @alwx alwx alwx approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @jo-mut jo-mut

    @VolodLytvynenko VolodLytvynenko

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Users are not removed from each other's contact list after blocking
    10 participants
    @jo-mut @status-im-auto @VolodLytvynenko @pavloburykh @churik @flexsurfer @alwx @Parveshdhull @smohamedjavid @ibrkhalil