Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix status-bar font color #15596

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix status-bar font color #15596

merged 1 commit into from
Apr 17, 2023

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Apr 6, 2023 •
edited
Loading

fixes: #15590

Summary

  • We are initializing root before processing settings data (which has the account theme)
  • RNN Bug - We are also changing the status-bar-theme at runtime, but for some reason theme used at the time of root initialization has high priority and gets restored on navigation (going back from chat, etc.)
  • Also we need to change app theme, before root

Testing

  • The issue should be fixed for both light and dark app themes, but as mentioned above, the theme needs to be provided at the time of root initialization. So if the theme changes after login, then the behavior will be the same, until the account relogin.
  • PR also makes alters small modification made in [Update] Checks for Syncing completed signal #15574. So please check pairing is working as expected

status: ready

@Parveshdhull Parveshdhull changed the title fix status-bar color fix status-bar font color Apr 6, 2023
@Parveshdhull Parveshdhull self-assigned this Apr 6, 2023
@Parveshdhull Parveshdhull changed the title fix status-bar font color [WIP] fix status-bar font color Apr 6, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Apr 6, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3160313 #2 2023-04-06 13:33:41 ~6 min tests 📄log
✔️ 3160313 #2 2023-04-06 13:34:36 ~7 min ios 📱ipa 📲
✔️ 3160313 #2 2023-04-06 13:35:32 ~8 min android-e2e 🤖apk 📲
✔️ 3160313 #2 2023-04-06 13:35:59 ~8 min android 🤖apk 📲
✔️ 1d76462 #3 2023-04-13 18:05:41 ~5 min android-e2e 🤖apk 📲
✔️ 1d76462 #3 2023-04-13 18:07:18 ~7 min ios 📱ipa 📲
✔️ 1d76462 #3 2023-04-13 18:07:20 ~7 min android 🤖apk 📲
✔️ 1d76462 #3 2023-04-13 18:07:32 ~7 min tests 📄log
✔️ 3ba9ef8 #4 2023-04-13 18:14:34 ~5 min android 🤖apk 📲
✔️ 3ba9ef8 #4 2023-04-13 18:15:41 ~6 min ios 📱ipa 📲
✔️ 3ba9ef8 #4 2023-04-13 18:15:51 ~7 min android-e2e 🤖apk 📲
✔️ 3ba9ef8 #4 2023-04-13 18:15:59 ~7 min tests 📄log
✔️ 7f370c9 #6 2023-04-16 17:44:59 ~5 min android 🤖apk 📲
✔️ 7f370c9 #6 2023-04-16 17:46:24 ~6 min android-e2e 🤖apk 📲
✔️ 7f370c9 #6 2023-04-16 17:46:47 ~7 min tests 📄log
✔️ 7f370c9 #6 2023-04-16 17:48:05 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 76f54cf #7 2023-04-17 08:16:07 ~5 min android-e2e 🤖apk 📲
✔️ 76f54cf #7 2023-04-17 08:17:35 ~6 min android 🤖apk 📲
✔️ 76f54cf #7 2023-04-17 08:17:39 ~6 min tests 📄log
✔️ 76f54cf #7 2023-04-17 08:19:01 ~8 min ios 📱ipa 📲
✔️ ec40da7 #8 2023-04-17 13:50:03 ~5 min android-e2e 🤖apk 📲
✔️ ec40da7 #8 2023-04-17 13:50:04 ~5 min android 🤖apk 📲
✔️ ec40da7 #8 2023-04-17 13:50:25 ~5 min tests 📄log
✔️ ec40da7 #8 2023-04-17 13:51:32 ~7 min ios 📱ipa 📲

@Parveshdhull Parveshdhull mentioned this pull request Apr 6, 2023
Closed
@churik
Copy link
Member

churik commented Apr 6, 2023 •
edited
Loading

FILE.2023-04-06.17.02.54.mp4

@Parveshdhull there is another issue with "Jump to" screen in light mode - the bar is not visible (both IOS and Android)
We can test it separately though, it is not as visible as the initial issue.

Testing on release 1.22 branch

@Parveshdhull Parveshdhull mentioned this pull request Apr 6, 2023
Closed
@Parveshdhull
Copy link
Member Author

Parveshdhull commented Apr 6, 2023 •
edited
Loading

hi @churik Thank you for testing the PR, for ios behavior is expected due to bug in rnn (#15260). For android it should be fixed in #15599

PS: Issue is only in release branch

@Parveshdhull Parveshdhull changed the title [WIP] fix status-bar font color fix status-bar font color Apr 13, 2023
@Parveshdhull Parveshdhull marked this pull request as ready for review April 13, 2023 18:00
@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

IDs of failed tests: 702850,702838

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: tab-recent
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Passed tests (27)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 14, 2023
    @qoqobolo qoqobolo self-assigned this Apr 14, 2023
    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Apr 14, 2023 •
    edited
    Loading

    Hi @Parveshdhull, thanks for the PR!

    Can ask you a question about a similar issue with the status bar on iOS? It is also reproducible in develop, and I see that there are some more status bar issues to be fixed, so I'm not sure this one in the scope of this PR.
    But could you tell for sure?

    ISSUE 1: Status bar has a white font on the home screen on iOS with light theme for a fresh install

    Screenshot 2023-04-14 at 11 05 18

    Steps:

    1. Set a light theme on your iOS device
    2. Install Status
    3. Create an account
    4. Check the home screen

    Relogin/reopening the app doesn't help in this case.
    Should we log this issue separately?

    @Parveshdhull
    Copy link
    Member Author

    Hi @qoqobolo, Thank you for testing the PR.
    I think it will be best if we can fix this issue in the scope of PR.
    I will see what is causing it and will let you know once it is fixed.

    @Parveshdhull Parveshdhull force-pushed the fix/status-bar-issue branch 2 times, most recently from 7f370c9 to 76f54cf Compare April 17, 2023 08:10
    @Parveshdhull
    Copy link
    Member Author

    Hi @qoqobolo, Thank you for finding the issue. It should be fixed now

    @flexsurfer flexsurfer self-requested a review April 17, 2023 09:37
    @qoqobolo
    Copy link
    Contributor

    Thanks for the fix @Parveshdhull
    Looks good to me, let's wait for @flexsurfer's review.
    PR can be merged once approval is received unless re-testing is needed.

    @Parveshdhull Parveshdhull merged commit 512af40 into develop Apr 17, 2023
    @Parveshdhull Parveshdhull deleted the fix/status-bar-issue branch April 17, 2023 13:54
    alwx pushed a commit that referenced this pull request Apr 28, 2023
    @Parveshdhull @alwx
    fix status-bar font color (#15596)
    b62c494
    @Parveshdhull Parveshdhull mentioned this pull request Mar 26, 2024
    Merged
    @Parveshdhull Parveshdhull mentioned this pull request Jun 24, 2024
    Closed
    @Parveshdhull Parveshdhull mentioned this pull request Oct 25, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jo-mut jo-mut jo-mut approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @ibrkhalil ibrkhalil Awaiting requested review from ibrkhalil

    Assignees

    @Parveshdhull Parveshdhull

    @VolodLytvynenko VolodLytvynenko

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Status bar font turns white after background or opening a chat
    7 participants
    @Parveshdhull @status-im-auto @churik @qoqobolo @flexsurfer @jo-mut @VolodLytvynenko