Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#15518]Show disclaimer during password creation #15650

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[#15518]Show disclaimer during password creation #15650

merged 1 commit into from
Apr 17, 2023

Conversation

SilentCruzer
Copy link
Collaborator

fixes #15518

Summary

Modified the passwrod creation screen to show the disclaimer on the screen always from the beginning / always when both password fields are filled.

password.mp4

Review notes

  • In the code, you can notice that the I moved the disclaimer part above the password validation, I moved it because I wanted to display the disclaimer above the validation text when the password was focused.
  • Also another bug to be noted (apart from the current issue), from the above video you can see that the topbar is being overlapped by the status bar by a little bit. I can include that fix in this PR if its okay.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Onboarding

Steps to test

  • Open Status in a Fresh install
  • Press I'm new to status -> Generate keys -> Continue
  • When the page is open, we can see the disclaimer immediately in the bottom and it will remain there through out the process.

status: ready

@status-github-bot
Copy link

Hey @SilentCruzer, and thank you so much for making your first pull request in status-mobile! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

@status-im-auto
Copy link
Member

status-im-auto commented Apr 14, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ e36044b #1 2023-04-14 08:28:08 ~3 min tests 📄log
✔️ e36044b #1 2023-04-14 08:29:42 ~5 min android-e2e 🤖apk 📲
✔️ e36044b #1 2023-04-14 08:30:26 ~6 min android 🤖apk 📲
✔️ e36044b #1 2023-04-14 08:31:57 ~7 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ adefd10 #2 2023-04-14 15:40:10 ~6 min android 🤖apk 📲
✔️ adefd10 #2 2023-04-14 15:40:39 ~7 min android-e2e 🤖apk 📲
✔️ adefd10 #2 2023-04-14 15:40:46 ~7 min tests 📄log
✔️ adefd10 #2 2023-04-14 15:41:11 ~7 min ios 📱ipa 📲
✔️ 2c8031f #3 2023-04-15 11:45:35 ~5 min android 🤖apk 📲
✔️ 2c8031f #3 2023-04-15 11:46:55 ~7 min android-e2e 🤖apk 📲
✔️ 2c8031f #3 2023-04-15 11:47:01 ~7 min tests 📄log
✔️ 2c8031f #3 2023-04-15 11:51:58 ~12 min ios 📱ipa 📲

@Parveshdhull
Copy link
Member

@SilentCruzer Thank you very much for PR.

Linting is broken, please run make lint for see issue and make lint-fix for fixing it.

@Parveshdhull
Copy link
Member

Also another bug to be noted (apart from the current issue), from the above video you can see that the topbar is being overlapped by the status bar by a little bit. I can include that fix in this PR if its okay.

This issue is already tracked in #15628 and will be fixed in #15640

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

IDs of failed tests: 702850,702838

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: tab-recent
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Passed tests (27)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    @SilentCruzer
    Copy link
    Collaborator Author

    @SilentCruzer Thank you very much for PR.

    Linting is broken, please run make lint for see issue and make lint-fix for fixing it.

    Thanks, I was actually wondering on how to use the lint test. I have resolved the issue now.

    ulisesmac
    ulisesmac approved these changes Apr 14, 2023
    View reviewed changes
    Copy link
    Contributor

    @ulisesmac ulisesmac left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hi @SilentCruzer !

    Thank you very much for your PR! 😄
    I added a small comment

    src/status_im2/contexts/onboarding/create_password/view.cljs Show resolved Hide resolved
    SilentCruzer
    SilentCruzer commented Apr 15, 2023
    View reviewed changes
    src/status_im2/contexts/onboarding/create_password/view.cljs
    (scroll-to-end-fn)
    (reset! focused-input input-id))
    (reset! focused-input :password))
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @ulisesmac , As you mentioned since we don't need to :repeat-password, i have removed the parameter in :on-input-focused and defaulted the input-id to :password.

    Is this change okay?

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yes, it's ok! thank you! 👍

    @churik churik mentioned this pull request Apr 17, 2023
    Closed
    @churik churik self-assigned this Apr 17, 2023
    @churik
    Copy link
    Member

    churik commented Apr 17, 2023

    Thank you for amazing work, @SilentCruzer !
    Ready to be merged.

    @flexsurfer flexsurfer merged commit 45b5018 into status-im:develop Apr 17, 2023
    alwx pushed a commit that referenced this pull request Apr 28, 2023
    @SilentCruzer @alwx
    [#15518]Show disclaimer during password creation (#15650)
    81d4799
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ulisesmac ulisesmac ulisesmac approved these changes

    @briansztamfater briansztamfater briansztamfater approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @alwx alwx alwx approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @churik churik

    @SilentCruzer SilentCruzer

    Labels
    external request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Always show the "I understand my password can't be recovered" disclaimer on password creation screen
    8 participants
    @SilentCruzer @status-im-auto @Parveshdhull @churik @alwx @briansztamfater @ulisesmac @flexsurfer