Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] [iOS] Crash on onboarding for second profile without biometrics #15688

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[Fix] [iOS] Crash on onboarding for second profile without biometrics #15688

merged 1 commit into from
Apr 20, 2023

Conversation

smohamedjavid
Copy link
Member

fixes #15632

Summary

This PR fixes the crash on iOS when the user tries to create a second profile without enabling biometrics.

Review notes

The crash happened from Keychain due to setting a nil value into the keychain on login signal handling. This is resolved by removing any profile login data (:multiaccounts/login and :auth-method keys) from app-db on the onboarding-2/create-account-and-login event handler.

Platforms

  • iOS

status: ready

@smohamedjavid smohamedjavid self-assigned this Apr 19, 2023
@smohamedjavid smohamedjavid force-pushed the fix/#15632-ios-crash-on-onboarding branch from ccc1e40 to 53ea72f Compare April 19, 2023 10:54
@status-im-auto
Copy link
Member

status-im-auto commented Apr 19, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 53ea72f #2 2023-04-19 11:01:19 ~6 min android-e2e 🤖apk 📲
✔️ 53ea72f #2 2023-04-19 11:01:30 ~6 min android 🤖apk 📲
✔️ 53ea72f #2 2023-04-19 11:01:47 ~6 min tests 📄log
✔️ 53ea72f #2 2023-04-19 11:02:19 ~7 min ios 📱ipa 📲
✔️ e78d476 #3 2023-04-20 10:54:20 ~7 min android-e2e 🤖apk 📲
✔️ e78d476 #3 2023-04-20 10:54:36 ~7 min android 🤖apk 📲
✔️ e78d476 #3 2023-04-20 10:55:38 ~8 min tests 📄log
❌ e78d476 #3 2023-04-20 11:09:33 ~22 min ios 📄log
✔️ e78d476 #4 2023-04-20 11:29:31 ~10 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

IDs of failed tests: 702850,702838

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find `Button` by `accessibility id`: `tab-recent`
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (27)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @qoqobolo qoqobolo self-assigned this Apr 20, 2023
    @qoqobolo
    Copy link
    Contributor

    Thank you for the fix @smohamedjavid!
    No issues found, PR can be merged.

    @smohamedjavid smohamedjavid force-pushed the fix/#15632-ios-crash-on-onboarding branch from 53ea72f to e78d476 Compare April 20, 2023 10:46
    @smohamedjavid smohamedjavid merged commit 7c54537 into develop Apr 20, 2023
    @smohamedjavid smohamedjavid deleted the fix/#15632-ios-crash-on-onboarding branch April 20, 2023 11:30
    ibrkhalil pushed a commit that referenced this pull request Apr 20, 2023
    @smohamedjavid @ibrkhalil
    [Fix] iOS crash on onboarding without biometrics (#15688)
    a46f909
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @briansztamfater briansztamfater briansztamfater approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @smohamedjavid smohamedjavid

    @qoqobolo qoqobolo

    Labels
    ios onboarding request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    6 participants
    @smohamedjavid @status-im-auto @qoqobolo @flexsurfer @Parveshdhull @briansztamfater