Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quo2 title-input component selection color fix for android #15717

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: quo2 title-input component selection color fix for android #15717

merged 1 commit into from
May 2, 2023

Conversation

ajayesivan
Copy link
Contributor

fixes #15624

How to test

  1. Go to 'Im new to Status' flow
  2. Open the 'Display name' page set up
  3. Type any text into 'Display name' -> highlight it

Fix Screenshots

android ios
android-selection ios-selection

Cause for the original issue

The selection-color property behaves differently on iOS and Android. When providing a solid color for this property, iOS will use a translucent version of the color for the background of text selection, while Android will use the original solid color.

android ios
android-selection-color ios-selection-color

Issue introduced in this PR

TextInput component caret color is dependent on the selection-color property. As a result, on Android, the caret will appear lighter in color compared to iOS.

android ios
android-cursor ios-cursor

status: ready

@ajayesivan ajayesivan self-assigned this Apr 23, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Apr 23, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7419473 #1 2023-04-23 10:38:54 ~5 min android 🤖apk 📲
✔️ 7419473 #1 2023-04-23 10:38:57 ~5 min android-e2e 🤖apk 📲
✔️ 7419473 #1 2023-04-23 10:39:27 ~6 min tests 📄log
✔️ 7419473 #1 2023-04-23 10:40:15 ~7 min ios 📱ipa 📲
✔️ 6a0eb98 #2 2023-04-27 11:20:33 ~11 min android-e2e 🤖apk 📲
✔️ 6a0eb98 #2 2023-04-27 11:25:15 ~15 min android 🤖apk 📲
✔️ 6a0eb98 #2 2023-04-27 11:26:48 ~17 min tests 📄log
✔️ 6a0eb98 #2 2023-04-27 12:08:28 ~58 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 56af24c #3 2023-05-01 17:57:12 ~5 min android-e2e 🤖apk 📲
✔️ 56af24c #3 2023-05-01 17:57:41 ~5 min android 🤖apk 📲
✔️ 56af24c #3 2023-05-01 17:57:51 ~5 min tests 📄log
✔️ 56af24c #3 2023-05-01 17:58:11 ~6 min ios 📱ipa 📲
✔️ 77108d9 #4 2023-05-02 11:20:28 ~5 min android-e2e 🤖apk 📲
✔️ 77108d9 #4 2023-05-02 11:20:29 ~5 min android 🤖apk 📲
✔️ 77108d9 #4 2023-05-02 11:20:45 ~6 min tests 📄log
✔️ 77108d9 #4 2023-05-02 11:21:24 ~6 min ios 📱ipa 📲

@flexsurfer flexsurfer removed the request for review from cammellos April 23, 2023 11:43
@J-Son89
Copy link
Contributor

J-Son89 commented Apr 23, 2023

hmm, please align with @mariocnovoa to confirm these changes as there is no exact specification in the designs for how this is looking and we want to make sure design team are aware of how this is currently. working. 👍
I think in later versions of React Native we can achieve what they prefer but for now we are at the mercy of selection-color prop 🙃

@ajayesivan
Copy link
Contributor Author

hmm, please align with @mariocnovoa to confirm these changes as there is no exact specification in the designs for how this is looking and we want to make sure design team are aware of how this is currently. working. 👍 I think in later versions of React Native we can achieve what they prefer but for now we are at the mercy of selection-color prop 🙃

Sure, I will check with Mario. Once we upgrade react native to 0.70.x we can fix this properly.

@ajayesivan ajayesivan force-pushed the 15624-android-display-name-text-selection-style-issue branch 2 times, most recently from 6a0eb98 to 56af24c Compare May 1, 2023 17:51
@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 30
Failed tests: 2
Passed tests: 28

IDs of failed tests: 702850,702838

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:410: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:927: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: close-activity-center
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:73: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Passed tests (28)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push (TestRail link is not found)
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @churik churik self-assigned this May 2, 2023
    @churik
    Copy link
    Member

    churik commented May 2, 2023

    Thanks for your amazing work!
    e2e failures are known but not related to PR.
    Tested basic flows, LGTM!

    Devices:

    • IPhone 12 Mini (IOS 16)
    • Xiaomi Mi Note 9 Pro (Android 10)
    • BlackView BV5200 Pro (Android 12)

    @ajayesivan ajayesivan force-pushed the 15624-android-display-name-text-selection-style-issue branch from 56af24c to 77108d9 Compare May 2, 2023 11:14
    @ajayesivan ajayesivan merged commit 03aac0e into develop May 2, 2023
    @ajayesivan ajayesivan deleted the 15624-android-display-name-text-selection-style-issue branch May 2, 2023 11:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    Assignees

    @churik churik

    @ajayesivan ajayesivan

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    [Android] Text entered in the Display Name field is blurry when highlighted
    6 participants
    @ajayesivan @status-im-auto @J-Son89 @churik @flexsurfer @smohamedjavid