Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect font-size in user-avatar(size: medium) #15801

Merged
merged 1 commit into from
May 4, 2023
Merged

fix: incorrect font-size in user-avatar(size: medium) #15801

merged 1 commit into from
May 4, 2023

Conversation

ajayesivan
Copy link
Contributor

Closes #15793

Updated user-avatar initial font size as per the design.

status: ready

@ajayesivan ajayesivan self-assigned this May 3, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 3, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 84db660 #1 2023-05-03 10:36:36 ~5 min android-e2e 🤖apk 📲
✔️ 84db660 #1 2023-05-03 10:37:50 ~6 min android 🤖apk 📲
✔️ 84db660 #1 2023-05-03 10:37:55 ~7 min tests 📄log
✔️ 84db660 #1 2023-05-03 10:38:46 ~7 min ios 📱ipa 📲
✔️ 854c585 #2 2023-05-04 14:12:23 ~6 min tests 📄log
✔️ 854c585 #2 2023-05-04 14:12:45 ~6 min android-e2e 🤖apk 📲
✔️ 854c585 #2 2023-05-04 14:12:47 ~6 min android 🤖apk 📲
✔️ 854c585 #2 2023-05-04 14:12:53 ~6 min ios 📱ipa 📲

@ajayesivan ajayesivan requested a review from ilmotta May 3, 2023 23:36
@VolodLytvynenko VolodLytvynenko self-assigned this May 4, 2023
@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 30
Failed tests: 2
Passed tests: 28

IDs of failed tests: 702850,702838

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:410: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:927: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: close-activity-center
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:73: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Passed tests (28)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi @ajayesivan thank you for your work. No issues from my side. PR is ready to be merged

    @ajayesivan ajayesivan force-pushed the 15793-user-avatar-initial-font-size branch from 84db660 to 854c585 Compare May 4, 2023 14:05
    @ajayesivan ajayesivan force-pushed the 15793-user-avatar-initial-font-size branch from 854c585 to b8cc812 Compare May 4, 2023 15:49
    @ajayesivan ajayesivan merged commit 6aae68b into develop May 4, 2023
    @ajayesivan ajayesivan deleted the 15793-user-avatar-initial-font-size branch May 4, 2023 16:11
    @ajayesivan ajayesivan mentioned this pull request May 8, 2023
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @ajayesivan ajayesivan

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Check avatar font size
    4 participants
    @ajayesivan @status-im-auto @VolodLytvynenko @ilmotta