Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #15899 : failed to reset password #15914

Merged
merged 3 commits into from
May 18, 2023
Merged

fix #15899 : failed to reset password #15914

merged 3 commits into from
May 18, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented May 16, 2023

fixes #15899

Platforms

  • Android
  • iOS

status: ready

@qfrank qfrank self-assigned this May 16, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 16, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 56facd4 #1 2023-05-16 09:35:44 ~7 min tests 📄log
✔️ 56facd4 #1 2023-05-16 09:36:28 ~8 min android-e2e 🤖apk 📲
✔️ 56facd4 #1 2023-05-16 09:36:34 ~8 min android 🤖apk 📲
✔️ 56facd4 #1 2023-05-16 09:37:02 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e9775a5 #2 2023-05-18 07:52:57 ~7 min android-e2e 🤖apk 📲
✔️ e9775a5 #2 2023-05-18 07:53:32 ~8 min ios 📱ipa 📲
✔️ e9775a5 #2 2023-05-18 07:53:45 ~8 min tests 📄log
✔️ e9775a5 #2 2023-05-18 07:54:32 ~9 min android 🤖apk 📲
✔️ 150ac01 #3 2023-05-18 14:13:18 ~7 min tests 📄log
✔️ 150ac01 #3 2023-05-18 14:14:46 ~8 min android-e2e 🤖apk 📲
✔️ 150ac01 #3 2023-05-18 14:14:49 ~8 min android 🤖apk 📲
✔️ 150ac01 #3 2023-05-18 14:16:42 ~10 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 32
Failed tests: 4
Passed tests: 28

IDs of failed tests: 702786,702807,702838,702813

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    # STEP: Send emoji message to Device 1 while it's on background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:1097: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:945: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element

    [[blocked by 15859]]

    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Text is Delivered
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:228: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin

    [[blocked by 15859]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: user_1 

    critical/test_public_chat_browsing.py:812: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin

    [[blocked by 15859]]

    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:935: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (28)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_1_1_chat_image_send_reply, id: 702859
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @qfrank I am blocked from testing this for now until we will find out and fix status-go issue with slow login. Andrea is looking on that.

    @cammellos
    Copy link
    Contributor

    Failed to reload keystore contents" err="open /data/user/0/im.status.ethereum.pr/no_backup/keystore/0x6f56979602c2f951397ec87170664cc870e39774338b290653af9dfa98343233: no such file or directory"

    I had this error on this build by

    1. Create account
    2. Logout
    3. Delete a bunch of accounts, including the new one created
    4. Create another account
    5. Logout
    6. Login

    @qfrank
    Copy link
    Contributor Author

    qfrank commented May 17, 2023

    Failed to reload keystore contents" err="open /data/user/0/im.status.ethereum.pr/no_backup/keystore/0x6f56979602c2f951397ec87170664cc870e39774338b290653af9dfa98343233: no such file or directory"

    I had this error on this build by

    1. Create account
    2. Logout
    3. Delete a bunch of accounts, including the new one created
    4. Create another account
    5. Logout
    6. Login

    interesting, let me check

    @cammellos
    Copy link
    Contributor

    @qfrank it's the geth keystore, not sure is related to your pr though

    @qfrank
    Copy link
    Contributor Author

    qfrank commented May 17, 2023 •
    edited
    Loading

    it's just hanging here, what i did:

    • Create account
    • Logout
    • Create another account
    • stuck here
    image image don't you have this issue with this PR? we need fix this stuck issue first, my PR only fix "failed to reset password" @cammellos

    @pavloburykh
    Copy link
    Contributor

    don't you have this issue with this PR? we need fix this stuck issue first, my PR only fix "failed to reset password" @cammellos

    I have faced such issue in this PR.

    @qfrank
    Copy link
    Contributor Author

    qfrank commented May 17, 2023

    I have faced such issue in this PR.

    this issue should also exist on branch develop right? @pavloburykh

    @pavloburykh
    Copy link
    Contributor

    this issue should also exist on branch develop right? @pavloburykh

    right. I have just re-checked and can confirm.

    Reproduced both login issue and stuck Generation keys screen.

    But regarding login case, in develop after waiting for some time I am facing "cannot retrieve valid key for given multiaccount.." error and not redirected into account.

    photo_2023-05-17 16 24 08

    I believe this particular error has been fixed by current PR as I have not faced it here.

    So, slow login and stucked Generation keys screen issues are not related to this PR. We just used builds from current PR to reproduce those issues.

    @qfrank
    Copy link
    Contributor Author

    qfrank commented May 18, 2023

    found the cause that causing stuck

    @qfrank
    Copy link
    Contributor Author

    qfrank commented May 18, 2023

    Failed to reload keystore contents" err="open /data/user/0/im.status.ethereum.pr/no_backup/keystore/0x6f56979602c2f951397ec87170664cc870e39774338b290653af9dfa98343233: no such file or directory"

    I had this error on this build by

    1. Create account
    2. Logout
    3. Delete a bunch of accounts, including the new one created
    4. Create another account
    5. Logout
    6. Login

    after resolving the stuck issue , i'm unable to reproduce this issue 🙂 @cammellos

    @qfrank
    Copy link
    Contributor Author

    qfrank commented May 18, 2023

    can you retry again after last rebase , the stuck issue should not exist anymore, also pls re-check issue @cammellos reported (i'm unable to reproduce), thank you @pavloburykh

    @pavloburykh
    Copy link
    Contributor

    can you retry again after last rebase , the stuck issue should not exist anymore, also pls re-check issue @cammellos reported (i'm unable to reproduce), thank you @pavloburykh

    thanx, I will re-check today.

    @pavloburykh pavloburykh self-assigned this May 18, 2023
    @pavloburykh
    Copy link
    Contributor

    @qfrank thank you for the fix. PR is tested and ready to be merged.

    @qfrank qfrank merged commit c7bc166 into develop May 18, 2023
    @qfrank qfrank deleted the fix/mobile-issue-15899 branch May 18, 2023 14:30
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees

    @qfrank qfrank

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    "cannot retrieve valid key for given multiaccount.." error when trying login under updated password
    7 participants
    @qfrank @status-im-auto @pavloburykh @cammellos @ilmotta @flexsurfer @J-Son89