Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icons #15937

Merged
merged 1 commit into from
May 24, 2023
Merged

New Icons #15937

merged 1 commit into from
May 24, 2023

Conversation

ajayesivan
Copy link
Contributor

@ajayesivan ajayesivan commented May 18, 2023

@ajayesivan ajayesivan self-assigned this May 18, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 18, 2023

Jenkins Builds

Click to see older builds (32)
Commit #️⃣ Finished (UTC) Duration Platform Result
806ac6b #1 2023-05-18 00:04:51 ~3 min android 📄log
806ac6b #1 2023-05-18 00:07:24 ~5 min android-e2e 📄log
806ac6b #1 2023-05-18 00:07:31 ~6 min ios 📄log
806ac6b #1 2023-05-18 00:09:24 ~7 min tests 📄log
8390f7c #2 2023-05-18 01:57:23 ~3 min android-e2e 📄log
8390f7c #2 2023-05-18 01:57:35 ~3 min android 📄log
8390f7c #2 2023-05-18 02:00:05 ~6 min ios 📄log
8390f7c #2 2023-05-18 02:01:42 ~7 min tests 📄log
9328104 #3 2023-05-19 01:08:39 ~3 min android-e2e 📄log
9328104 #3 2023-05-19 01:08:56 ~3 min android 📄log
9328104 #3 2023-05-19 01:12:47 ~7 min ios 📄log
9328104 #3 2023-05-19 01:13:48 ~8 min tests 📄log
✔️ c5c9004 #4 2023-05-19 22:03:11 ~5 min android 🤖apk 📲
✔️ c5c9004 #4 2023-05-19 22:03:37 ~5 min android-e2e 🤖apk 📲
✔️ c5c9004 #4 2023-05-19 22:04:35 ~6 min ios 📱ipa 📲
c5c9004 #4 2023-05-19 22:05:49 ~7 min tests 📄log
✔️ ac4a732 #5 2023-05-19 22:23:43 ~5 min android-e2e 🤖apk 📲
✔️ ac4a732 #5 2023-05-19 22:23:48 ~5 min android 🤖apk 📲
✔️ ac4a732 #5 2023-05-19 22:24:43 ~6 min ios 📱ipa 📲
ac4a732 #5 2023-05-19 22:27:49 ~9 min tests 📄log
✔️ 2fb2526 #6 2023-05-19 23:53:50 ~5 min android 🤖apk 📲
✔️ 2fb2526 #6 2023-05-19 23:53:51 ~5 min android-e2e 🤖apk 📲
✔️ 2fb2526 #6 2023-05-19 23:54:35 ~6 min ios 📱ipa 📲
2fb2526 #6 2023-05-19 23:56:16 ~8 min tests 📄log
✔️ 1032441 #7 2023-05-20 00:29:51 ~5 min android 🤖apk 📲
✔️ 1032441 #7 2023-05-20 00:30:12 ~5 min android-e2e 🤖apk 📲
✔️ 1032441 #7 2023-05-20 00:30:56 ~6 min ios 📱ipa 📲
✔️ 1032441 #7 2023-05-20 00:32:28 ~7 min tests 📄log
✔️ b7882d2 #8 2023-05-22 18:47:42 ~5 min android 🤖apk 📲
✔️ b7882d2 #8 2023-05-22 18:48:02 ~5 min android-e2e 🤖apk 📲
✔️ b7882d2 #8 2023-05-22 18:48:51 ~6 min ios 📱ipa 📲
✔️ b7882d2 #8 2023-05-22 18:50:12 ~7 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f13e725 #9 2023-05-23 19:51:44 ~5 min android-e2e 🤖apk 📲
✔️ f13e725 #9 2023-05-23 19:52:33 ~6 min android 🤖apk 📲
✔️ f13e725 #9 2023-05-23 19:52:40 ~6 min ios 📱ipa 📲
✔️ f13e725 #9 2023-05-23 19:55:03 ~8 min tests 📄log
✔️ 721e0c1 #10 2023-05-24 12:53:16 ~5 min android 🤖apk 📲
✔️ 721e0c1 #10 2023-05-24 12:54:09 ~6 min android-e2e 🤖apk 📲
✔️ 721e0c1 #10 2023-05-24 12:55:40 ~7 min ios 📱ipa 📲
✔️ 721e0c1 #10 2023-05-24 12:57:37 ~9 min tests 📄log

@ajayesivan ajayesivan changed the title New Icons [WIP]New Icons May 18, 2023
@ajayesivan ajayesivan changed the title [WIP]New Icons New Icons May 18, 2023
@ajayesivan ajayesivan force-pushed the new-icons-may2023 branch from 806ac6b to 8390f7c Compare May 18, 2023 01:53
Copy link
Contributor

@siddarthkay siddarthkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current code expects icons to be named with lower case, thats also one of the reasons why tests are failing :)

@J-Son89 J-Son89 mentioned this pull request May 18, 2023
11 tasks
@ajayesivan ajayesivan changed the title New Icons [WIP] New Icons May 19, 2023
@ajayesivan ajayesivan force-pushed the new-icons-may2023 branch from 9328104 to c5c9004 Compare May 19, 2023 21:57
@ajayesivan ajayesivan changed the title [WIP] New Icons New Icons May 19, 2023
@ajayesivan ajayesivan force-pushed the new-icons-may2023 branch 3 times, most recently from 2fb2526 to 1032441 Compare May 20, 2023 00:24
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 32
Failed tests: 2
Passed tests: 30
Not executed tests: 1
IDs of not executed tests: 703194 
IDs of failed tests: 702844,702838 

Not executed tests (1)

Click to expand
  • Rerun not executed tests
  • Failed tests (2)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Tap on found: SendMessageButton
    Device 2: Find `Button` by `xpath`: `//*[@text="Don't ask me again"]`

    critical/test_public_chat_browsing.py:604: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
        self.channel_2.element_by_translation_id("dont-ask").click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: Button by xpath: `//*[@text="Don't ask me again"]` is not found on the screen
    



    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
        channel.verify_message_is_under_today_text(message, self.errors)
    ../views/chat_view.py:935: in verify_message_is_under_today_text
        message_element.wait_for_visibility_of_element()
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element 
    

    [[blocked by 14797]]

    Device sessions

    Passed tests (30)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_1_1_chat_image_send_reply, id: 702859
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    @flexsurfer
    Copy link
    Member

    hey @ajayesivan just wondering what the size of new icons ?

    @qoqobolo qoqobolo self-assigned this May 22, 2023
    @ajayesivan
    Copy link
    Contributor Author

    hey @ajayesivan just wondering what the size of new icons ?

    icon2 folder was 2.5MB(590 files) after adding all the new icons it's 4.3MB(1032 files).

    @ilmotta
    Copy link
    Contributor

    ilmotta commented May 22, 2023

    @ajayesivan, quick question, how did you re-generate all the icons from Figma? Do we have a script of sorts?

    @status-im-auto
    Copy link
    Member

    91% of end-end tests have passed

    Total executed tests: 32
    Failed tests: 3
    Passed tests: 29
    Not executed tests: 1
    
    IDs of not executed tests: 703194 
    
    IDs of failed tests: 702844,702859,702838 
    

    Not executed tests (1)

    Click to expand
  • Rerun not executed tests
  • Failed tests (3)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Tap on found: SendMessageButton
    Device 2: Find `Button` by `xpath`: `//*[@text="Don't ask me again"]`

    critical/test_public_chat_browsing.py:604: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
        self.channel_2.element_by_translation_id("dont-ask").click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: Button by xpath: `//*[@text="Don't ask me again"]` is not found on the screen
    



    Device sessions

    2. test_1_1_chat_image_send_reply, id: 702859

    Device 1: Trying to access image inside message with text 'description'
    Device 1: Find Button by xpath: //*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.view.ViewGroup/android.widget.ImageView

    critical/test_public_chat_browsing.py:508: in test_1_1_chat_image_send_reply
        self.channel_1.chat_element_by_text(image_description).image_in_message.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by xpath: `//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//android.view.ViewGroup/android.widget.ImageView` is not found on the screen
    



    Device sessions

    3. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
        channel.verify_message_is_under_today_text(message, self.errors)
    ../views/chat_view.py:935: in verify_message_is_under_today_text
        message_element.wait_for_visibility_of_element()
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element 
    

    [[blocked by 14797]]

    Device sessions

    Passed tests (29)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    @status-im-auto
    Copy link
    Member

    75% of end-end tests have passed

    Total executed tests: 32
    Failed tests: 8
    Passed tests: 24
    Not executed tests: 1
    
    IDs of not executed tests: 703194 
    
    IDs of failed tests: 702840,702844,702859,702786,702894,702841,703086,702838 
    

    Not executed tests (1)

    Click to expand
  • Rerun not executed tests
  • Failed tests (8)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 1: Sending message 'emoji'

    critical/test_public_chat_browsing.py:554: in test_community_emoji_send_copy_paste_reply
        self.channel_1.send_message(emoji_message)
    ../views/chat_view.py:945: in send_message
        self.chat_message_input.wait_for_element(wait_chat_input_sec)
    ../views/base_element.py:117: in wait_for_element
        raise TimeoutException(
     Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; also Unexpected Alert is shown: 'java.lang.NullPointerException: null cannot be cast to non-null type android.view.ViewGroup'
    



    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Tap on found: SendMessageButton
    Device 2: Find Button by xpath: //*[@text="Don't ask me again"]

    critical/test_public_chat_browsing.py:604: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
        self.channel_2.element_by_translation_id("dont-ask").click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: Button by xpath: `//*[@text="Don't ask me again"]` is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: null cannot be cast to non-null type android.view.ViewGroup'
    



    Device sessions

    3. test_1_1_chat_image_send_reply, id: 702859

    Device 2: Tap on found: SendMessageButton
    Device 1: Looking for a message by text: reply to image

    critical/test_public_chat_browsing.py:547: in test_1_1_chat_image_send_reply
        self.errors.verify_no_errors()
    base_test_case.py:184: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Reply message was not received by the sender; also Unexpected Alert is shown: 'java.lang.NullPointerException: null cannot be cast to non-null type android.view.ViewGroup'
    



    Device sessions

    4. test_community_mentions_push_notification, id: 702786

    # STEP: Admin gets push notification with the mention and tap it
    Device 1: Getting PN by 'user_1'

    critical/test_public_chat_browsing.py:811: in test_community_mentions_push_notification
        self.errors.verify_no_errors()
    base_test_case.py:184: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Push notification with the mention was not received by admin
    



    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find Button by accessibility id: jump-to

    critical/test_public_chat_browsing.py:655: in test_community_contact_block_unblock_offline
        [home.jump_to_card_by_text('# %s' % self.channel_name) for home in self.homes]
    critical/test_public_chat_browsing.py:655: in <listcomp>
        [home.jump_to_card_by_text('# %s' % self.channel_name) for home in self.homes]
    ../views/base_view.py:609: in jump_to_card_by_text
        self.jump_to_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `jump-to` is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: null cannot be cast to non-null type android.view.ViewGroup'
    



    Device sessions

    6. test_community_unread_messages_badge, id: 702841

    Device 1: Find Button by accessibility id: jump-to

    critical/test_public_chat_browsing.py:636: in test_community_unread_messages_badge
        self.channel_1.jump_to_communities_home()
    ../views/base_view.py:605: in jump_to_communities_home
        self.jump_to_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `jump-to` is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: null cannot be cast to non-null type android.view.ViewGroup'
    



    Device sessions

    7. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Find Button by accessibility id: jump-to

    critical/test_public_chat_browsing.py:726: in test_community_mark_all_messages_as_read
        self.channel_1.jump_to_communities_home()
    ../views/base_view.py:605: in jump_to_communities_home
        self.jump_to_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `jump-to` is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: null cannot be cast to non-null type android.view.ViewGroup'
    



    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
        channel.verify_message_is_under_today_text(message, self.errors)
    ../views/chat_view.py:935: in verify_message_is_under_today_text
        message_element.wait_for_visibility_of_element()
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element 
    

    [[blocked by 14797]]

    Device sessions

    Passed tests (24)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_message_delete, id: 702839
    Device sessions

    3. test_community_message_edit, id: 702843
    Device sessions

    @ajayesivan
    Copy link
    Contributor Author

    @ajayesivan, quick question, how did you re-generate all the icons from Figma? Do we have a script of sorts?

    No script. I regenerated the icons manually by selecting and exporting them all at once. Figma grouped them automatically by size, so it was easy.

    @ajayesivan ajayesivan force-pushed the new-icons-may2023 branch from 1032441 to b7882d2 Compare May 22, 2023 18:41
    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 1
    Failed tests: 0
    Passed tests: 1
    

    Passed tests (1)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    Hey @ajayesivan, can I ask you to rebase this PR against the latest develop, please, as we have one important fix merged?
    Thanks!

    @ajayesivan ajayesivan force-pushed the new-icons-may2023 branch from b7882d2 to f13e725 Compare May 23, 2023 19:45
    @ajayesivan
    Copy link
    Contributor Author

    @qoqobolo Rebased 👍

    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 7
    Failed tests: 0
    Passed tests: 7
    

    Passed tests (7)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    4. test_community_mentions_push_notification, id: 702786
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    @ajayesivan ajayesivan force-pushed the new-icons-may2023 branch from f13e725 to 721e0c1 Compare May 24, 2023 12:47
    @ajayesivan ajayesivan merged commit 7fc05bc into develop May 24, 2023
    @ajayesivan ajayesivan deleted the new-icons-may2023 branch May 24, 2023 12:59
    ajayesivan added a commit that referenced this pull request May 24, 2023
    rahulpsingh pushed a commit that referenced this pull request May 26, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    6 participants