-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Icons #15937
New Icons #15937
Conversation
Jenkins BuildsClick to see older builds (32)
|
806ac6b
to
8390f7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current code expects icons to be named with lower case, thats also one of the reasons why tests are failing :)
9328104
to
c5c9004
Compare
2fb2526
to
1032441
Compare
94% of end-end tests have passed
Not executed tests (1)Failed tests (2)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (30)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
hey @ajayesivan just wondering what the size of new icons ? |
icon2 folder was |
@ajayesivan, quick question, how did you re-generate all the icons from Figma? Do we have a script of sorts? |
91% of end-end tests have passed
Not executed tests (1)Failed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (29)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
75% of end-end tests have passed
Not executed tests (1)Failed tests (8)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (24)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
No script. I regenerated the icons manually by selecting and exporting them all at once. Figma grouped them automatically by size, so it was easy. |
1032441
to
b7882d2
Compare
100% of end-end tests have passed
Passed tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
|
Hey @ajayesivan, can I ask you to rebase this PR against the latest develop, please, as we have one important fix merged? |
b7882d2
to
f13e725
Compare
@qoqobolo Rebased 👍 |
100% of end-end tests have passed
Passed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
|
f13e725
to
721e0c1
Compare
This PR adds all the icons from here: https://www.figma.com/file/qLLuMLfpGxK9OfpIavwsmK/Iconset?type=design&node-id=1%3A413&t=SGSFkhz6o6GJfsif-1
status: ready