[Fix] Incorrect navigation to message reaction bottom sheet #16218

smohamedjavid · 2023-06-07T11:43:12Z

Summary

This PR fixes the incorrect navigation of the message reaction bottom sheet by ensuring the bottom sheet opens only on successful retrieval of message reaction data.

Platforms

Android
iOS

Steps to test

Open any chat
Leave a reaction to a message
Long press on any reaction to open the reaction author's bottom sheet
Check if the reaction which is long pressed is shown as selected

status: ready

src/status_im2/contexts/chat/messages/drawers/view.cljs

ibrkhalil

Thanks for the fix Mohamed!

src/status_im/chat/models/reactions.cljs

status-im-auto · 2023-06-07T11:50:07Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`b006886`	#1	2023-06-07 11:50:07	~6 min	`ios`	📱`ipa` 📲
✔️	`b006886`	#1	2023-06-07 11:54:15	~10 min	`android`	🤖`apk` 📲
✔️	`b006886`	#1	2023-06-07 11:54:40	~11 min	`android-e2e`	🤖`apk` 📲
✔️	`b006886`	#1	2023-06-07 11:56:50	~13 min	`tests`	📄`log`

✔️	`975219c`	#2	2023-06-07 12:09:44	~6 min	`ios`	📱`ipa` 📲
✔️	`975219c`	#2	2023-06-07 12:15:33	~12 min	`android-e2e`	🤖`apk` 📲
✔️	`975219c`	#2	2023-06-07 12:16:47	~14 min	`android`	🤖`apk` 📲
✔️	`975219c`	#2	2023-06-07 12:19:43	~16 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`498675b`	#3	2023-06-07 15:20:26	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`498675b`	#3	2023-06-07 15:20:49	~6 min	`android`	🤖`apk` 📲
✔️	`498675b`	#3	2023-06-07 15:24:26	~9 min	`tests`	📄`log`
✔️	`498675b`	#3	2023-06-07 15:26:40	~12 min	`ios`	📱`ipa` 📲

✔️	`bb1a282`	#4	2023-06-08 16:11:06	~5 min	`android`	🤖`apk` 📲
✔️	`bb1a282`	#4	2023-06-08 16:11:12	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`bb1a282`	#4	2023-06-08 16:12:02	~6 min	`ios`	📱`ipa` 📲
✔️	`bb1a282`	#4	2023-06-08 16:13:32	~8 min	`tests`	📄`log`

src/status_im/chat/models/reactions.cljs

src/status_im2/contexts/chat/messages/content/reactions/view.cljs

src/status_im2/contexts/chat/messages/drawers/view.cljs

flexsurfer

perfecto! thank you

status-im-auto · 2023-06-07T18:00:22Z

33% of end-end tests have passed

Total executed tests: 21
Failed tests: 14
Passed tests: 7
Not executed tests: 12

IDs of not executed tests: 702807,702732,702808,702846,702742,703133,702850,702851,702936,702947,702957,702958

IDs of failed tests: 702733,703194,702859,702855,702844,702745,702786,702894,702783,702845,702841,702731,703086,702838

Not executed tests (12)

Click to expand

Rerun not executed tests

Failed tests (14)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'message to delete for me')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 2: Tap on found: Text `critical/chats/test_1_1_public_chats.py:1160: in test_1_1_chat_text_message_delete_push_disappear self.chat_2.chat_element_by_text(message_to_delete_for_me).wait_for_status_to_be("Delivered") ../views/chat_view.py:227: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s" % expected_status) Message status was not changed to Delivered` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_edit_message, id: 702855
Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 2: Tap on found: Text `critical/chats/test_1_1_public_chats.py:1134: in test_1_1_chat_edit_message self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered") ../views/chat_view.py:227: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s" % expected_status) Message status was not changed to Delivered` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 1: Tap on found: SendMessageButton Device 2: Sending message 'hello' critical/chats/test_1_1_public_chats.py:1040: in test_1_1_chat_non_latin_messages_stack_update_profile_photo [self.chat_2.send_message(message) for message in messages] critical/chats/test_1_1_public_chats.py:1040: in <listcomp> [self.chat_2.send_message(message) for message in messages] ../views/chat_view.py:954: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
# STEP: Device1 goes back online and checks that 1-1 chat will be fetched Device 1: Looking for a message by text: test message `critical/chats/test_1_1_public_chats.py:1236: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not delivered after back up online, it is "Sending"!` [[Issue with messages not being sent for a long time]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
5. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device 2: Trying to access images (image container) inside message with text 'gallery' Device 2: Find `Button` by `xpath`: `//[starts-with(@text,'gallery')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc="image-container"]` critical/test_public_chat_browsing.py:558: in test_community_several_images_send_reply image_description).image_container_in_message.is_element_differs_from_template(file_name, 5): ../views/base_element.py:251: in is_element_differs_from_template difference = ImageChops.difference(self.image, self.template) ../views/base_element.py:224: in image return Image.open(BytesIO(base64.b64decode(self.find_element().screenshot_as_base64))) ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[starts-with(@text,'gallery')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc="image-container"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_one_image_send_reply, id: 702859
Device 1: Find `RepliedMessageText` by `xpath`: `//*[starts-with(@text,'reply to image')]/preceding::android.widget.TextView[@content-desc='quoted-message']` Device 1: `RepliedMessageText` is `description` `critical/test_public_chat_browsing.py:546: in test_community_one_image_send_reply self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Reply message was not received by the sender` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request six.raise_from(e, None) <string>:3: in raise_from ??? /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request httplib_response = conn.getresponse() /usr/lib/python3.10/http/client.py:1374: in getresponse response.begin() /usr/lib/python3.10/http/client.py:318: in begin version, status, reason = self._read_status() /usr/lib/python3.10/http/client.py:287: in _read_status raise RemoteDisconnected("Remote end closed connection without" E http.client.RemoteDisconnected: Remote end closed connection without response During handling of the above exception, another exception occurred: base_test_case.py:357: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:319: in execute response = self.command_executor.execute(driver_command, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:376: in execute return self._request(command_info[0], url, body=data) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:399: in _request resp = self._conn.request(method, url, body=body, headers=headers) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request return self.request_encode_body( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body return self.urlopen(method, url, extra_kw) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen response = conn.urlopen(method, u.request_uri, kw) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen retries = retries.increment( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment raise six.reraise(type(error), error, _stacktrace) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise raise value.with_traceback(tb) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request six.raise_from(e, None) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request httplib_response = conn.getresponse() /usr/lib/python3.10/http/client.py:1374: in getresponse response.begin() /usr/lib/python3.10/http/client.py:318: in begin version, status, reason = self._read_status() /usr/lib/python3.10/http/client.py:287: in _read_status raise RemoteDisconnected("Remote end closed connection without" ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
4. test_community_mentions_push_notification, id: 702786
Test setup failed: base_test_case.py:357: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) ERROR The test with session id 0b10025d598b40d992875a2bd8a4cd5d has already finished, and can't receive further commands. E You can learn more at https://app.eu-central-1.saucelabs.com/tests/0b10025d598b40d992875a2bd8a4cd5d E For help, please check https://docs.saucelabs.com/dev/error-messages
5. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: base_test_case.py:357: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) The test with session id 38ed29b9c5a944f59ecd0707445fc8df has already finished, and can't receive further commands. E For help, please check https://docs.saucelabs.com/dev/error-messages
6. test_community_leave, id: 702845
Test setup failed: base_test_case.py:357: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) ERROR The test with session id 0b10025d598b40d992875a2bd8a4cd5d has already finished, and can't receive further commands. E You can learn more at https://app.eu-central-1.saucelabs.com/tests/0b10025d598b40d992875a2bd8a4cd5d E For help, please check https://docs.saucelabs.com/dev/error-messages
7. test_community_unread_messages_badge, id: 702841
Test setup failed: base_test_case.py:357: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) ERROR The test with session id 0b10025d598b40d992875a2bd8a4cd5d has already finished, and can't receive further commands. E You can learn more at https://app.eu-central-1.saucelabs.com/tests/0b10025d598b40d992875a2bd8a4cd5d E For help, please check https://docs.saucelabs.com/dev/error-messages
8. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: base_test_case.py:357: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) ERROR The test with session id 0b10025d598b40d992875a2bd8a4cd5d has already finished, and can't receive further commands. E You can learn more at https://app.eu-central-1.saucelabs.com/tests/0b10025d598b40d992875a2bd8a4cd5d E For help, please check https://docs.saucelabs.com/dev/error-messages
9. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Verifying that 'hello' is under today Device 2: Looking for a message by text: hello critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username channel.verify_message_is_under_today_text(message, self.errors) ../views/chat_view.py:944: in verify_message_is_under_today_text message_element.wait_for_visibility_of_element() ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (7)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2023-06-08T13:23:32Z

57% of end-end tests have passed

Total executed tests: 7
Failed tests: 3
Passed tests: 4
Not executed tests: 5

IDs of not executed tests: 702846,702742,703133,702850,702851

IDs of failed tests: 702732,702957,702958

Not executed tests (5)

Click to expand

Rerun not executed tests

Failed tests (3)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePR:

1. test_activity_center_mentions, id: 702957
Test setup failed: base_test_case.py:357: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) ERROR The test with session id 8a9a0474c19843f78776207518bad084 has already finished, and can't receive further commands. E You can learn more at https://app.eu-central-1.saucelabs.com/tests/8a9a0474c19843f78776207518bad084 E For help, please check https://docs.saucelabs.com/dev/error-messages
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: base_test_case.py:357: in setup_method driver.execute_script("sauce:context=Started %s" % method.__name__) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:208: in check_response raise exception_class(value) ERROR The test with session id 8a9a0474c19843f78776207518bad084 has already finished, and can't receive further commands. E You can learn more at https://app.eu-central-1.saucelabs.com/tests/8a9a0474c19843f78776207518bad084 E For help, please check https://docs.saucelabs.com/dev/error-messages

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Passed tests (4)

Click to expand

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

status-im-auto · 2023-06-08T14:37:01Z

21% of end-end tests have passed

Total executed tests: 14
Failed tests: 11
Passed tests: 3

IDs of failed tests: 702838,703086,702844,702783,702841,702786,702859,703194,702845,702894,702731

Failed tests (11)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
# STEP: Device1 goes back online and checks that 1-1 chat will be fetched Device 1: Looking for a message by text: test message `critical/chats/test_1_1_public_chats.py:1250: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:182: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not delivered after back up online, it is "Sending"!` [[Issue with messages not being sent for a long time]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Verifying that 'new message' is under today Device 2: Looking for a message by text: new message critical/test_public_chat_browsing.py:458: in test_community_message_send_check_timestamps_sender_username self.channel_2.verify_message_is_under_today_text(new_message, self.errors, 60) ../views/chat_view.py:948: in verify_message_is_under_today_text message_element.wait_for_visibility_of_element(timeout) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'new message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_mark_all_messages_as_read, id: 703086
Device 2: Tap on found: Button Device 2: Sending message 'hello' critical/test_public_chat_browsing.py:765: in test_community_mark_all_messages_as_read self.channel_2.send_message(self.text_message) ../views/chat_view.py:958: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
# STEP: Checking github_pr preview case Device 2: Find `ChatMessageInput` by `accessibility id`: `chat-message-input` critical/test_public_chat_browsing.py:642: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable self.channel_2.chat_message_input.set_value(url) ../views/base_element.py:352: in set_value self.find_element().set_value(value) ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: ChatMessageInput by accessibility id: `chat-message-input` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_community_unread_messages_badge, id: 702841
Device 1: Find `CommunitiesTab` by `accessibility id`: `communities-stack-tab` Device 2: Sending message 'test message' critical/test_public_chat_browsing.py:669: in test_community_unread_messages_badge self.channel_2.send_message(message) ../views/chat_view.py:958: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
5. test_community_mentions_push_notification, id: 702786
# STEP: Invited member sends a message with a mention Device 2: Sending message 'hi' critical/test_public_chat_browsing.py:793: in test_community_mentions_push_notification self.channel_2.send_message("hi") ../views/chat_view.py:958: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; RemoteDisconnected Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
6. test_community_one_image_send_reply, id: 702859
# STEP: check image, description and options for receiver Device 2: Looking for a message by text: description critical/test_public_chat_browsing.py:534: in test_community_one_image_send_reply self.channel_2.chat_element_by_text(image_description).wait_for_visibility_of_element(60) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
7. test_community_several_images_send_reply, id: 703194
Device 2: Trying to access images (image container) inside message with text 'gallery' Device 2: Find `Button` by `xpath`: `//[starts-with(@text,'gallery')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc="image-container"]` critical/test_public_chat_browsing.py:560: in test_community_several_images_send_reply image_description).image_container_in_message.is_element_differs_from_template(file_name, 5): ../views/base_element.py:251: in is_element_differs_from_template difference = ImageChops.difference(self.image, self.template) ../views/base_element.py:224: in image return Image.open(BytesIO(base64.b64decode(self.find_element().screenshot_as_base64))) ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[starts-with(@text,'gallery')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc="image-container"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
8. test_community_leave, id: 702845
Device 2: Find `CommunitiesTab` by `accessibility id`: `communities-stack-tab` Device 2: Looking for community: 'ryxmumt' critical/test_public_chat_browsing.py:857: in test_community_leave community.long_press_until_element_is_shown(community_to_leave.leave_community_button) ../views/base_element.py:298: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:65: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'ryxmumt')]/..` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
9. test_community_contact_block_unblock_offline, id: 702894
# STEP: Sending message before block Device 2: Sending message 'I should not be in chat' critical/test_public_chat_browsing.py:691: in test_community_contact_block_unblock_offline self.channel_2.send_message(message_to_disappear) ../views/chat_view.py:958: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (3)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2023-06-08T16:01:34Z

Thanks for the fix and for your great work @smohamedjavid!
PR can be merged.

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

smohamedjavid added bug reactions labels Jun 7, 2023

smohamedjavid requested review from flexsurfer, yqrashawn, ajayesivan and ibrkhalil June 7, 2023 11:43

smohamedjavid self-assigned this Jun 7, 2023

smohamedjavid commented Jun 7, 2023

View reviewed changes

src/status_im2/contexts/chat/messages/drawers/view.cljs Outdated Show resolved Hide resolved

ibrkhalil reviewed Jun 7, 2023

View reviewed changes

src/status_im/chat/models/reactions.cljs Outdated Show resolved Hide resolved

flexsurfer reviewed Jun 7, 2023

View reviewed changes

src/status_im/chat/models/reactions.cljs Outdated Show resolved Hide resolved

smohamedjavid requested review from flexsurfer and ibrkhalil June 7, 2023 12:03

ibrkhalil approved these changes Jun 7, 2023

View reviewed changes

flexsurfer reviewed Jun 7, 2023

View reviewed changes

src/status_im2/contexts/chat/messages/content/reactions/view.cljs Outdated Show resolved Hide resolved

flexsurfer reviewed Jun 7, 2023

View reviewed changes

src/status_im2/contexts/chat/messages/drawers/view.cljs Outdated Show resolved Hide resolved

smohamedjavid force-pushed the fix/message-reactions-navigation branch from 975219c to 498675b Compare June 7, 2023 15:14

smohamedjavid requested a review from flexsurfer June 7, 2023 15:14

flexsurfer approved these changes Jun 7, 2023

View reviewed changes

smohamedjavid added the request-manual-qa label Jun 7, 2023

qoqobolo self-assigned this Jun 7, 2023

ajayesivan approved these changes Jun 8, 2023

View reviewed changes

qoqobolo added the Tested - OK label Jun 8, 2023

[Fix] Navigation to message reaction

bb1a282

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

smohamedjavid force-pushed the fix/message-reactions-navigation branch from 498675b to bb1a282 Compare June 8, 2023 16:05

smohamedjavid merged commit c59de7d into develop Jun 8, 2023

smohamedjavid deleted the fix/message-reactions-navigation branch June 8, 2023 16:17

codemaster115 pushed a commit that referenced this pull request Jun 16, 2023

[Fix] Navigation to message reaction (#16218)

e8fe996

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] Incorrect navigation to message reaction bottom sheet #16218

[Fix] Incorrect navigation to message reaction bottom sheet #16218

smohamedjavid commented Jun 7, 2023

ibrkhalil left a comment

status-im-auto commented Jun 7, 2023 •

edited

Loading

flexsurfer left a comment

status-im-auto commented Jun 7, 2023

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Jun 8, 2023

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

status-im-auto commented Jun 8, 2023

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

qoqobolo commented Jun 8, 2023

[Fix] Incorrect navigation to message reaction bottom sheet #16218

[Fix] Incorrect navigation to message reaction bottom sheet #16218

Conversation

smohamedjavid commented Jun 7, 2023

Summary

Platforms

Steps to test

ibrkhalil left a comment

Choose a reason for hiding this comment

status-im-auto commented Jun 7, 2023 • edited Loading

Jenkins Builds

flexsurfer left a comment

Choose a reason for hiding this comment

status-im-auto commented Jun 7, 2023

33% of end-end tests have passed

Not executed tests (12)

Failed tests (14)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Passed tests (7)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Jun 8, 2023

57% of end-end tests have passed

Not executed tests (5)

Failed tests (3)

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (4)

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

status-im-auto commented Jun 8, 2023

21% of end-end tests have passed

Failed tests (11)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Passed tests (3)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

qoqobolo commented Jun 8, 2023

status-im-auto commented Jun 7, 2023 •

edited

Loading