Address design feedback on Profile share tab Screen #16257

siddarthkay · 2023-06-13T10:18:11Z

fixes #16080

Testing notes

No functionality was changed, only UI Touchups

Platforms

Android
iOS

status: ready

status-im-auto · 2023-06-13T10:21:50Z

Jenkins Builds

Click to see older builds (86)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`6a56384`	#1	2023-06-13 10:21:50	~3 min	`tests`	📄`log`

✔️	`6f127fc`	#3	2023-06-13 10:27:56	~5 min	`ios`	📱`ipa` 📲
✔️	`6f127fc`	#3	2023-06-13 10:28:05	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`6f127fc`	#3	2023-06-13 10:28:21	~6 min	`android`	🤖`apk` 📲
✔️	`6f127fc`	#3	2023-06-13 10:30:56	~8 min	`tests`	📄`log`

✔️	`7d9cf0a`	#4	2023-06-13 11:00:37	~5 min	`android`	🤖`apk` 📲
✔️	`7d9cf0a`	#4	2023-06-13 11:00:38	~5 min	`ios`	📱`ipa` 📲
✔️	`7d9cf0a`	#4	2023-06-13 11:00:38	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`7d9cf0a`	#4	2023-06-13 11:04:13	~9 min	`tests`	📄`log`

✔️	`7617bbc`	#5	2023-06-14 06:49:36	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`7617bbc`	#5	2023-06-14 06:49:50	~6 min	`ios`	📱`ipa` 📲
✔️	`7617bbc`	#5	2023-06-14 06:50:55	~8 min	`android`	🤖`apk` 📲
✔️	`7617bbc`	#5	2023-06-14 06:51:19	~8 min	`tests`	📄`log`

✔️	`be50fac`	#6	2023-06-19 08:30:07	~5 min	`android`	🤖`apk` 📲
✔️	`be50fac`	#6	2023-06-19 08:30:16	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`be50fac`	#6	2023-06-19 08:31:42	~7 min	`ios`	📱`ipa` 📲
✔️	`be50fac`	#6	2023-06-19 08:33:39	~9 min	`tests`	📄`log`

✔️	`67145ff`	#7	2023-06-19 10:27:28	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`67145ff`	#7	2023-06-19 10:28:56	~7 min	`ios`	📱`ipa` 📲
❌	`67145ff`	#7	2023-06-19 10:29:28	~7 min	`tests`	📄`log`
✔️	`67145ff`	#7	2023-06-19 10:33:25	~11 min	`android`	🤖`apk` 📲

✔️	`80e1e27`	#10	2023-06-19 12:41:39	~5 min	`ios`	📱`ipa` 📲
✔️	`80e1e27`	#10	2023-06-19 12:44:22	~8 min	`tests`	📄`log`

✔️	`b20d15c`	#12	2023-06-19 13:29:21	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b20d15c`	#12	2023-06-19 13:30:18	~7 min	`ios`	📱`ipa` 📲
✔️	`b20d15c`	#12	2023-06-19 13:30:18	~7 min	`android`	🤖`apk` 📲

✔️	`3e0527f`	#13	2023-06-19 13:37:51	~6 min	`ios`	📱`ipa` 📲
✔️	`3e0527f`	#13	2023-06-19 13:38:09	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`3e0527f`	#13	2023-06-19 13:39:34	~8 min	`android`	🤖`apk` 📲
✔️	`3e0527f`	#13	2023-06-19 13:41:57	~10 min	`tests`	📄`log`

❌	`3e9940d`	#14	2023-06-30 04:38:37	~2 min	`tests`	📄`log`
✔️	`3e9940d`	#14	2023-06-30 04:41:25	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`3e9940d`	#14	2023-06-30 04:41:27	~5 min	`ios`	📱`ipa` 📲
✔️	`3e9940d`	#14	2023-06-30 04:41:47	~6 min	`android`	🤖`apk` 📲

❌	`c6241e3`	#15	2023-06-30 06:13:51	~2 min	`tests`	📄`log`
✔️	`c6241e3`	#15	2023-06-30 06:16:51	~5 min	`android`	🤖`apk` 📲
✔️	`c6241e3`	#15	2023-06-30 06:16:57	~5 min	`ios`	📱`ipa` 📲
✔️	`c6241e3`	#15	2023-06-30 06:17:02	~5 min	`android-e2e`	🤖`apk` 📲

❌	`af4fa28`	#17	2023-08-08 15:16:59	~2 min	`tests`	📄`log`
✔️	`af4fa28`	#17	2023-08-08 15:20:00	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`af4fa28`	#17	2023-08-08 15:21:50	~7 min	`android`	🤖`apk` 📲
✔️	`af4fa28`	#17	2023-08-08 15:27:25	~13 min	`ios`	📱`ipa` 📲

❌	`ec6a2d5`	#18	2023-08-29 12:42:43	~2 min	`tests`	📄`log`
✔️	`ec6a2d5`	#18	2023-08-29 12:45:56	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ec6a2d5`	#18	2023-08-29 12:46:33	~6 min	`android`	🤖`apk` 📲
✔️	`ec6a2d5`	#18	2023-08-29 12:48:19	~8 min	`ios`	📱`ipa` 📲

❌	`a0b433a`	#20	2023-09-13 18:11:28	~2 min	`tests`	📄`log`
✔️	`a0b433a`	#20	2023-09-13 18:15:14	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`a0b433a`	#20	2023-09-13 18:15:20	~6 min	`android`	🤖`apk` 📲
✔️	`a0b433a`	#20	2023-09-13 18:15:42	~6 min	`ios`	📱`ipa` 📲

✔️	`dbb19a2`	#21	2023-09-14 05:25:14	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`dbb19a2`	#21	2023-09-14 05:25:23	~6 min	`android`	🤖`apk` 📲
✔️	`dbb19a2`	#21	2023-09-14 05:27:50	~8 min	`tests`	📄`log`
✔️	`dbb19a2`	#21	2023-09-14 05:28:17	~9 min	`ios`	📱`ipa` 📲

✔️	`67504a7`	#22	2023-09-14 05:55:45	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`67504a7`	#22	2023-09-14 05:56:19	~6 min	`ios`	📱`ipa` 📲
✔️	`67504a7`	#22	2023-09-14 05:57:46	~7 min	`android`	🤖`apk` 📲
✔️	`67504a7`	#22	2023-09-14 05:59:19	~9 min	`tests`	📄`log`

✔️	`5b392ef`	#24	2023-09-14 11:26:50	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`5b392ef`	#24	2023-09-14 11:27:33	~6 min	`android`	🤖`apk` 📲
✔️	`5b392ef`	#24	2023-09-14 11:29:31	~8 min	`ios`	📱`ipa` 📲
✔️	`5b392ef`	#24	2023-09-14 11:31:21	~10 min	`tests`	📄`log`

❌	`647c0f7`	#25	2023-09-14 14:04:09	~2 min	`tests`	📄`log`
✔️	`647c0f7`	#25	2023-09-14 14:07:26	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`647c0f7`	#25	2023-09-14 14:07:30	~6 min	`android`	🤖`apk` 📲
✔️	`647c0f7`	#25	2023-09-14 14:09:01	~7 min	`ios`	📱`ipa` 📲

✔️	`e291be3`	#26	2023-09-14 14:38:07	~6 min	`ios`	📱`ipa` 📲
✔️	`e291be3`	#26	2023-09-14 14:41:08	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`e291be3`	#26	2023-09-14 14:41:23	~9 min	`android`	🤖`apk` 📲
✔️	`e291be3`	#26	2023-09-14 14:42:01	~10 min	`tests`	📄`log`

✔️	`9ff9588`	#27	2023-09-15 10:19:03	~5 min	`android`	🤖`apk` 📲
✔️	`9ff9588`	#27	2023-09-15 10:19:40	~6 min	`ios`	📱`ipa` 📲
✔️	`9ff9588`	#27	2023-09-15 10:21:12	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`9ff9588`	#27	2023-09-15 10:22:31	~9 min	`tests`	📄`log`

✔️	`d1f0254`	#28	2023-09-15 10:43:10	~5 min	`android`	🤖`apk` 📲
✔️	`d1f0254`	#28	2023-09-15 10:44:14	~6 min	`ios`	📱`ipa` 📲
✔️	`d1f0254`	#28	2023-09-15 10:45:38	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`d1f0254`	#28	2023-09-15 10:46:57	~9 min	`tests`	📄`log`

❌	`079b9f4`	#30	2023-09-15 11:22:38	~1 min	`ios`	📄`log`
✔️	`079b9f4`	#30	2023-09-15 11:26:20	~5 min	`android`	🤖`apk` 📲
✔️	`079b9f4`	#30	2023-09-15 11:26:30	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`079b9f4`	#30	2023-09-15 11:29:35	~8 min	`tests`	📄`log`

✔️	`0bbb7b4`	#31	2023-09-15 11:53:13	~5 min	`android`	🤖`apk` 📲
✔️	`0bbb7b4`	#31	2023-09-15 11:55:23	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0bbb7b4`	#31	2023-09-15 11:57:02	~9 min	`tests`	📄`log`
✔️	`0bbb7b4`	#31	2023-09-15 11:57:54	~10 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`50682c2`	#32	2023-09-15 12:05:53	~5 min	`android`	🤖`apk` 📲
✔️	`50682c2`	#32	2023-09-15 12:08:38	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`50682c2`	#32	2023-09-15 12:09:17	~9 min	`tests`	📄`log`

✔️	`9620179`	#33	2023-09-15 12:27:57	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`9620179`	#33	2023-09-15 12:28:04	~6 min	`android`	🤖`apk` 📲
✔️	`9620179`	#33	2023-09-15 12:28:25	~6 min	`ios`	📱`ipa` 📲
✔️	`9620179`	#33	2023-09-15 12:30:17	~8 min	`tests`	📄`log`

src/status_im2/contexts/share/view.cljs

src/status_im2/contexts/share/style.cljs

siddarthkay · 2023-06-13T11:12:57Z

I Will wait to hear from @mariocnovoa on the design review as well before merging this in.

J-Son89 · 2023-06-13T11:23:23Z

Nice, I'm also planning to check with figma this evening 👌
You done a review with figma + iPhone 11 Pro @siddarthkay?

status-im-auto · 2023-06-13T13:45:31Z

36% of end-end tests have passed

Total executed tests: 33
Failed tests: 21
Passed tests: 12

IDs of failed tests: 702840,702733,702958,703194,702859,702855,702732,702844,702745,702786,702894,702845,702850,702841,702957,702731,702839,702851,703086,702838,702843

Failed tests (21)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
2. test_community_several_images_send_reply, id: 703194
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
3. test_community_one_image_send_reply, id: 702859
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
5. test_community_mentions_push_notification, id: 702786
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
6. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
7. test_community_leave, id: 702845
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
8. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
9. test_community_message_delete, id: 702839
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
10. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen
11. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Find `Button` by `xpath`: `//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` Device 2: Find `Button` by `accessibility id`: `close-activity-center` Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
12. test_community_message_edit, id: 702843
Test setup failed: critical/test_public_chat_browsing.py:419: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:327: in handle_contact_request self.close_activity_centre.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `close-activity-center` is not found on the screen

Class TestActivityMultipleDevicePR:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
# STEP: Clearing history Device 2: Find `Button` by `accessibility id`: `jump-to` medium/test_activity_center.py:289: in test_activity_center_admin_notification_accept_swipe self.home_2.jump_to_messages_home() ../views/base_view.py:602: in jump_to_messages_home self.jump_to_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_mentions, id: 702957
Device 2: Tap on found: Button Device 2: Find `Button` by `xpath`: `//[@text="# general"]` medium/test_activity_center.py:255: in test_activity_center_mentions self.home_2.jump_to_card_by_text('# %s' % self.channel_name) ../views/base_view.py:613: in jump_to_card_by_text self.element_by_text(text).click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[@text="# general"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device 2: Looking for activity center element: 'sender' Device 2: Find `Button` by `xpath`: `//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']//[@content-desc="activity-message-body"]` medium/test_activity_center.py:68: in test_activity_center_contact_request_decline if activity_center_element.message_body.text != self.home_2.get_translation_by_key("add-me-to-your-contacts"): ../views/base_element.py:209: in text return self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']//[@content-desc="activity-message-body"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device 2: Find `Button` by `accessibility id`: `new-chat-button` Device 2: Find `Button` by `accessibility id`: `add-a-contact` medium/test_activity_center.py:78: in test_activity_center_contact_request_accept_swipe_mark_all_as_read self.home_2.add_contact(self.public_key_1, remove_from_contacts=True) ../views/home_view.py:337: in add_contact self.add_a_contact_chat_bottom_sheet_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `add-a-contact` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device 2: Tap on found: Button Device 1: Getting PN by 'DELETE ME' `critical/chats/test_1_1_public_chats.py:1209: in test_1_1_chat_text_message_delete_push_disappear self.errors.verify_no_errors() base_test_case.py:182: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not changed to 'Delivered' after 60 s, https://github.com/status-im/status-mobile/issues/15385` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_edit_message, id: 702855
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 2: Tap on found: Text `critical/chats/test_1_1_public_chats.py:1142: in test_1_1_chat_edit_message self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered") ../views/chat_view.py:228: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status)) Message status was not changed to Delivered, it's Sending` [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 3.4714642693014706 percents `critical/chats/test_1_1_public_chats.py:1076: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:182: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message with text 'ё, доброго вечерочка' was not received E Message with text '® æ ç ♥' was not received` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Passed tests (12)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
3. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

ilmotta

LGTM

ibrkhalil

Non blocking comment

src/status_im2/contexts/share/view.cljs

siddarthkay · 2023-06-19T12:37:39Z

done a review with figma + iPhone 11 Pro @siddarthkay?

pavloburykh · 2023-06-19T13:22:18Z

Hey @siddarthkay ! Is PR ready for test?

siddarthkay · 2023-06-19T13:23:41Z

Hi @pavloburykh : Sorry not yet, I've just now requested a re-review by Design Team.
Once I get the green signal from them I'll ping QA for testing :)

siddarthkay · 2023-09-14T06:11:01Z

@qoqobolo @pavloburykh @churik : I've fixed all the issues.
note on issue 4: I've made some updates to make blur better (blur not matching 100% with designs is a known issue)
This PR is ready for one more round of testing.

Apologies for the delay.

status-im-auto · 2023-09-14T06:39:05Z

37% of end-end tests have passed

Total executed tests: 43
Failed tests: 27
Passed tests: 16

IDs of failed tests: 702809,702782,702733,702784,702732,702813,703133,702957,703495,702948,702894,702745,702783,702742,703503,703496,702936,702855,703391,702786,702947,702731,702808,702730,702845,702958,703382

Failed tests (27)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 1: Looking for a message by text: Hurray! unblocked `critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Hurray! unblocked was not received in public chat after user unblock!` [[Message can be missed after unblock: https://github.com//issues/16873]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Test setup failed: critical/test_public_chat_browsing.py:1039: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/test_public_chat_browsing.py:1039: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_community_mentions_push_notification, id: 702786
Device 2: Find `Button` by `accessibility id`: `enable-notifications-later-button` Device 2: Find `Button` by `accessibility id`: `welcome-button` Test setup failed: critical/test_public_chat_browsing.py:1039: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception [[Issue with username in PN, issue #6 in 15500]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_community_leave, id: 702845
Test setup failed: critical/test_public_chat_browsing.py:1039: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Test setup failed: critical/chats/test_1_1_public_chats.py:1354: in prepare_devices self.home_1.send_contact_request_via_bottom_sheet(self.public_key_2) ../views/home_view.py:427: in send_contact_request_via_bottom_sheet chat.profile_add_to_contacts_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `Add to contacts-item-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 1: Find `Button` by `accessibility id`: `new-contact-button` Device 1: Find `Button` by `accessibility id`: `Add to contacts-item-button` Test setup failed: critical/chats/test_1_1_public_chats.py:1354: in prepare_devices self.home_1.send_contact_request_via_bottom_sheet(self.public_key_2) ../views/home_view.py:427: in send_contact_request_via_bottom_sheet chat.profile_add_to_contacts_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `Add to contacts-item-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_mute_chat, id: 703496
Test setup failed: critical/chats/test_1_1_public_chats.py:1354: in prepare_devices self.home_1.send_contact_request_via_bottom_sheet(self.public_key_2) ../views/home_view.py:427: in send_contact_request_via_bottom_sheet chat.profile_add_to_contacts_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `Add to contacts-item-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_mute_chat, id: 703495
Device 2: Long press on `ChatElement` Device 2: Find `MuteButton` by `accessibility id`: `mute-chat` critical/chats/test_group_chat.py:537: in test_group_chat_mute_chat if self.homes[1].mute_chat_button.text != transl["unmute-chat"]: ../views/home_view.py:213: in text return self.find_element().find_element(by=MobileBy.CLASS_NAME, value="android.widget.TextView").text ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: MuteButton by accessibility id: `mute-chat` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
3. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device 1: Could not reach home view by pressing system back button Device 1: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/test_public_chat_browsing.py:447: in test_restore_multiaccount_with_waku_backup_remove_switch profile = self.home.profile_button.click() ../views/base_view.py:145: in click ChatsTab(self.driver).click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device 1: Long press on `ChatElementByText` Device 1: Find `Button` by `xpath`: `//[@text="Copy text"]` critical/test_public_chat_browsing.py:366: in test_community_copy_and_paste_message_in_chat_input self.channel.copy_message_text(message) ../views/chat_view.py:1048: in copy_message_text self.element_by_translation_id("copy-text").click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@text="Copy text"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] https://github.com//issues/17175]]
4. test_community_mute_community_and_channel, id: 703382
Device 1: Getting cats channel element in community Device 1: Looking for chat: 'cats' critical/test_public_chat_browsing.py:409: in test_community_mute_community_and_channel self.community_view.get_channel(self.channel_name).long_press_element() ../views/base_element.py:311: in long_press_element element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//[@content-desc='channel-list-item']//[starts-with(@text,'# cats')]/..` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 1: Tap on found: CommunitiesTab Device 1: Looking for community: 'open community' Test setup failed: medium/test_activity_center.py:319: in prepare_devices self.community_1.share_community(self.community_name, self.username_2) ../views/chat_view.py:497: in share_community community_element.long_press_until_element_is_shown(self.share_community_button) ../views/base_element.py:317: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'open community')]/..` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: medium/test_activity_center.py:319: in prepare_devices self.community_1.share_community(self.community_name, self.username_2) ../views/chat_view.py:497: in share_community community_element.long_press_until_element_is_shown(self.share_community_button) ../views/base_element.py:317: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'open community')]/..` is not found on the screen after wait_for_visibility_of_element

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device 1: Tap on found: CommunitiesTab Device 1: Looking for community: 'open community' Test setup failed: medium/test_activity_center.py:171: in prepare_devices self.community_1.share_community(self.community_name, self.username_2) ../views/chat_view.py:497: in share_community community_element.long_press_until_element_is_shown(self.share_community_button) ../views/base_element.py:317: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'open community')]/..` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: medium/test_activity_center.py:171: in prepare_devices self.community_1.share_community(self.community_name, self.username_2) ../views/chat_view.py:497: in share_community community_element.long_press_until_element_is_shown(self.share_community_button) ../views/base_element.py:317: in long_press_until_element_is_shown element = self.find_element() ../views/home_view.py:74: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElement by xpath:`//*[@content-desc='chat-name-text'][starts-with(@text,'open community')]/..` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Test setup failed: critical/chats/test_1_1_public_chats.py:838: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Test setup failed: critical/chats/test_1_1_public_chats.py:838: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_1_1_chat_push_emoji, id: 702813
Test setup failed: critical/chats/test_1_1_public_chats.py:838: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Test setup failed: critical/chats/test_1_1_public_chats.py:838: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_1_1_chat_edit_message, id: 702855
Test setup failed: critical/chats/test_1_1_public_chats.py:838: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
6. test_1_1_chat_send_image_save_and_share, id: 703391
Test setup failed: critical/chats/test_1_1_public_chats.py:838: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
7. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
8. test_1_1_chat_message_reaction, id: 702730
Device 1: Find `Button` by `accessibility id`: `enable-notifications-button` Device 1: Find `Button` by `accessibility id`: `welcome-button` Test setup failed: critical/chats/test_1_1_public_chats.py:838: in prepare_devices self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True, /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:253: in create_user self.start_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (16)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2023-09-14T17:14:24Z

79% of end-end tests have passed

Total executed tests: 43
Failed tests: 9
Passed tests: 34

IDs of failed tests: 702894,703086,702786,702731,703496,702808,702783,702732,703503

Failed tests (9)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] https://github.com//issues/17175]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 1: Looking for a message by text: Hurray! unblocked `critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Hurray! unblocked was not received in public chat after user unblock!` [[Message can be missed after unblock: https://github.com//issues/16873]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_mark_all_messages_as_read, id: 703086
Device 1: Tap on found: Button Device 1: Click until `Text` by `accessibility id`: `community-description-text` will be presented `critical/test_public_chat_browsing.py:1028: in test_community_mark_all_messages_as_read self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New messages counter is not shown in home > Community element E New messages counter is not shown in community channel element` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

# STEP: Invited member gets push notification with the mention and tap it
Device 2: Getting PN by 'user_2'

critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

[[Issue with username in PN, issue #6 in 15500]]

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 1: Looking for a message by text: after unmute `critical/chats/test_1_1_public_chats.py:1457: in test_1_1_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message text 'should be muted' is not shown in chat preview after mute E Message 'should be muted' is not shown in chat for receiver after mute` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not changed to Delivered, it's Sent after back up online!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
2. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Passed tests (34)

Click to expand

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

qoqobolo · 2023-09-15T09:36:35Z

@siddarthkay thanks for the fixes!
One question.

I see you have updated the link format on the Share screen, but I'm afraid because of this, adding contacts by scanning a QR code doesn't work anymore.
In order for this to work correctly, we need to carry out full work on updating the format #16810
Please correct me if I misunderstood the purpose of this change.

IMG_1708.MP4

siddarthkay · 2023-09-15T09:53:19Z

Hi @qoqobolo : you're right, I missed this, I'll revert the links back to old format.

qoqobolo · 2023-09-15T10:57:03Z

Thanks for your work @siddarthkay!
PR is tested and ready to be reviewed by @Francesca-G

Francesca-G

Looks good to me ✨

This commit adds UI Touchups to profile share screen according to Design Review.

siddarthkay self-assigned this Jun 13, 2023

siddarthkay linked an issue Jun 13, 2023 that may be closed by this pull request

Profile - Share Tab - Design Review #16080

Closed

siddarthkay force-pushed the profile-share-tab-design-feedback branch from 6a56384 to ab86e22 Compare June 13, 2023 10:21

siddarthkay force-pushed the profile-share-tab-design-feedback branch from ab86e22 to 6f127fc Compare June 13, 2023 10:21

siddarthkay requested review from J-Son89, ilmotta, cammellos, flexsurfer and ibrkhalil June 13, 2023 10:44

flexsurfer reviewed Jun 13, 2023

View reviewed changes

src/status_im2/contexts/share/view.cljs Outdated Show resolved Hide resolved

src/status_im2/contexts/share/view.cljs Outdated Show resolved Hide resolved

src/status_im2/contexts/share/style.cljs Outdated Show resolved Hide resolved

siddarthkay requested a review from flexsurfer June 13, 2023 10:55

flexsurfer approved these changes Jun 13, 2023

View reviewed changes

ilmotta approved these changes Jun 13, 2023

View reviewed changes

siddarthkay force-pushed the profile-share-tab-design-feedback branch 2 times, most recently from 7617bbc to be50fac Compare June 19, 2023 08:23

ibrkhalil approved these changes Jun 19, 2023

View reviewed changes

src/status_im2/contexts/share/view.cljs Outdated Show resolved Hide resolved

siddarthkay force-pushed the profile-share-tab-design-feedback branch from 5e26706 to 80e1e27 Compare June 19, 2023 12:35

pavloburykh added the request-manual-qa label Jun 19, 2023

siddarthkay force-pushed the profile-share-tab-design-feedback branch from 80e1e27 to edc9e69 Compare June 19, 2023 13:20

siddarthkay force-pushed the profile-share-tab-design-feedback branch from edc9e69 to b20d15c Compare June 19, 2023 13:22

siddarthkay force-pushed the profile-share-tab-design-feedback branch from b20d15c to 3e0527f Compare June 19, 2023 13:30

siddarthkay mentioned this pull request Sep 11, 2023

[#16329] QR code variants #17221

Merged

siddarthkay force-pushed the profile-share-tab-design-feedback branch from 69fc219 to a0b433a Compare September 13, 2023 18:08

siddarthkay force-pushed the profile-share-tab-design-feedback branch 4 times, most recently from 647c0f7 to e291be3 Compare September 14, 2023 14:31

siddarthkay force-pushed the profile-share-tab-design-feedback branch from 9ff9588 to d1f0254 Compare September 15, 2023 10:37

qoqobolo added Tested - OK and removed Tested - Issues labels Sep 15, 2023

Francesca-G approved these changes Sep 15, 2023

View reviewed changes

siddarthkay force-pushed the profile-share-tab-design-feedback branch 4 times, most recently from 0bbb7b4 to 50682c2 Compare September 15, 2023 11:59

address design feedback on profile share UI

9620179

This commit adds UI Touchups to profile share screen according to Design Review.

siddarthkay force-pushed the profile-share-tab-design-feedback branch from 50682c2 to 9620179 Compare September 15, 2023 12:21

siddarthkay merged commit a24ddbe into develop Sep 15, 2023
6 checks passed

siddarthkay deleted the profile-share-tab-design-feedback branch September 15, 2023 12:32

Address design feedback on Profile share tab Screen #16257

Address design feedback on Profile share tab Screen #16257

Conversation

siddarthkay commented Jun 13, 2023

Testing notes

Platforms

status-im-auto commented Jun 13, 2023 • edited Loading

Jenkins Builds

siddarthkay commented Jun 13, 2023

J-Son89 commented Jun 13, 2023

status-im-auto commented Jun 13, 2023

36% of end-end tests have passed

Failed tests (21)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (12)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePR:

ilmotta left a comment

Choose a reason for hiding this comment

ibrkhalil left a comment

Choose a reason for hiding this comment

siddarthkay commented Jun 19, 2023

pavloburykh commented Jun 19, 2023

siddarthkay commented Jun 19, 2023

siddarthkay commented Sep 14, 2023

status-im-auto commented Sep 14, 2023

37% of end-end tests have passed

Failed tests (27)

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (16)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Sep 14, 2023

79% of end-end tests have passed

Failed tests (9)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (34)

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Sep 15, 2023

siddarthkay commented Sep 15, 2023

qoqobolo commented Sep 15, 2023

Francesca-G left a comment

Choose a reason for hiding this comment

status-im-auto commented Jun 13, 2023 •

edited

Loading