Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#16551] - shared community name in switcher #16576

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[#16551] - shared community name in switcher #16576

merged 2 commits into from
Jul 21, 2023

Conversation

ulisesmac
Copy link
Contributor

@ulisesmac ulisesmac commented Jul 13, 2023 •
edited
Loading

fixes #16551

Summary

This PR fixes the community tag, and, while solving it, I noticed the channel card was looking bad too, so I fixed it too.
Mainly solves problems due to the layout.

Previously:
notifications | no notifications
old-notifications old

In this PR:
notifications | no notifications
new-notifications new

Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx

Review notes

I rewrote the layout of the bottom container in the switcher card because it we had many absolute styles, they weren't behaving as expected.

In the current solution, I preferred to make the component context-tag more flexible, since I was breaking many styles in other uses of this tag.
We will need also to solve this new issue:

We must create all missing context tags variants.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Steps to test

  • Open Status
  • Send an invitation community link to a contact inside the chat
  • Press jump to
  • Visit a channel in a community
  • Press jump to
  • Now in the jump to screen will appear two cards containing the fixed styles.
  • Receive a notification in both the previous mentioned channel and chat
  • Now the cards will show a notification, these styles were also fixed.

status: ready

@ulisesmac ulisesmac self-assigned this Jul 13, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jul 13, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (5)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6a518c7 #1 2023-07-13 04:00:49 ~6 min ios 📱ipa 📲
✔️ 0d0203d #2 2023-07-13 04:09:23 ~5 min ios 📱ipa 📲
✔️ 0d0203d #2 2023-07-13 04:09:32 ~5 min android-e2e 🤖apk 📲
✔️ 0d0203d #2 2023-07-13 04:09:47 ~6 min android 🤖apk 📲
✔️ 0d0203d #2 2023-07-13 04:11:47 ~8 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6fbc3cc #3 2023-07-20 22:21:00 ~6 min ios 📱ipa 📲
✔️ 6fbc3cc #3 2023-07-20 22:23:13 ~8 min android-e2e 🤖apk 📲
✔️ 6fbc3cc #3 2023-07-20 22:23:30 ~8 min android 🤖apk 📲
✔️ 6fbc3cc #3 2023-07-20 22:24:36 ~9 min tests 📄log
✔️ ab8f83c #4 2023-07-21 20:08:16 ~6 min ios 📱ipa 📲
✔️ ab8f83c #4 2023-07-21 20:10:43 ~8 min android 🤖apk 📲
✔️ ab8f83c #4 2023-07-21 20:10:52 ~8 min android-e2e 🤖apk 📲
✔️ ab8f83c #4 2023-07-21 20:11:54 ~9 min tests 📄log

@ulisesmac ulisesmac force-pushed the 16551-name-shared-community-jump-to branch from 6a518c7 to 0d0203d Compare July 13, 2023 04:03
ajayesivan
ajayesivan approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

codemaster115
codemaster115 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@codemaster115 codemaster115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

smohamedjavid
smohamedjavid approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the context tags in Switcher cards and Activity Center. Looks Good!

@qoqobolo
Copy link
Contributor

Hey @ulisesmac , could you rebase this, please?

@ulisesmac ulisesmac force-pushed the 16551-name-shared-community-jump-to branch from 0d0203d to 6fbc3cc Compare July 20, 2023 22:14
@ulisesmac
Copy link
Contributor Author

Hey @ulisesmac , could you rebase this, please?

Done! @qoqobolo
:)

@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 36
Failed tests: 9
Passed tests: 27

IDs of failed tests: 702732,703133,702851,703086,702894,702783,702786,702731,702845

Failed tests (9)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Looking for chat: 'eugmqhb'
    Device 1: Long press on `ChatElement` until expected element is shown 

    critical/test_public_chat_browsing.py:898: in test_community_mark_all_messages_as_read
    community_1_element.long_press_until_element_is_shown(mark_as_read_button)
../views/base_element.py:302: in long_press_until_element_is_shown
    action.long_press(element).release().perform()
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:163: in perform
    self._driver.execute(Command.TOUCH_ACTION, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
    raise wde
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
    super().check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response
    raise exception_class(message, screen, stacktrace)
 The element 'By.xpath: //*[@content-desc='chat-name-text'][starts-with(@text,'eugmqhb')]/..' does not exist in DOM anymore; also Unexpected Alert is shown: 'Feature not implemented.'



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:852: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!



    Device sessions

    3. test_community_mentions_push_notification, id: 702786

    Device 1: Looking for a message by text: user_1
    Device 1: Find ChatElementByText by xpath: //*[starts-with(@text,'user_1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/test_public_chat_browsing.py:942: in test_community_mentions_push_notification
    self.channel_1.set_reaction(message=self.username_1, emoji="sad")
../views/chat_view.py:1020: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:298: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:133: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'user_1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element; also Unexpected Alert is shown: 'Feature not implemented.'



    Device sessions

    4. test_community_leave, id: 702845

    Device 2: Find Button by xpath: //*[@text="Leave community"]
    Device 2: Tap on found: Button 

    None; also Unexpected Alert is shown: 'Feature not implemented.'



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:433: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact(s) was (were) not restored from backup: MyCustomNickname!



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Find Button by accessibility id: tab-contacts
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:111: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact was not added to contact list after accepting contact request (as receiver)
E    Contact was not added to contact list after accepting contact request (as sender)



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1379: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline
E    Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (27)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    @pavloburykh pavloburykh self-assigned this Jul 21, 2023
    @status-im-auto
    Copy link
    Member

    22% of end-end tests have passed

    Total executed tests: 9
Failed tests: 7
Passed tests: 2

    IDs of failed tests: 702845,702894,703086,702786,702731,703133,702732

    Failed tests (7)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_leave, id: 702845 
    Test setup failed: critical/test_public_chat_browsing.py:453: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:351: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    2. test_community_contact_block_unblock_offline, id: 702894

    Device 2: Find Button by xpath: //*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]
    Device 2: Find Button by accessibility id: close-activity-center 

    Test setup failed: critical/test_public_chat_browsing.py:453: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:351: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/test_public_chat_browsing.py:453: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:351: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    4. test_community_mentions_push_notification, id: 702786 

    Test setup failed: critical/test_public_chat_browsing.py:453: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:351: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:433: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact(s) was (were) not restored from backup: MyCustomNickname!



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (2)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Jul 21, 2023 •
    edited
    Loading

    @ulisesmac thanx for the PR! One question: how have you been able to generate unread badges for community channel cards in Jump-to? For me unread badges do not appear neither in develop nor in this PR.

    253153128-099a82e1-466c-4014-a5fe-0e75938e9a06 png (320×489) 2023-07-21 17-28-06

    @pavloburykh
    Copy link
    Contributor

    @ulisesmac overall PR LGTM. Although I couldn't check the state with unread badge on channel card. But this issue is related to PR, we will log it separately. Ready for merge.

    @ulisesmac ulisesmac force-pushed the 16551-name-shared-community-jump-to branch from 6fbc3cc to ab8f83c Compare July 21, 2023 20:01
    @ulisesmac
    Copy link
    Contributor Author

    @ulisesmac thanx for the PR! One question: how have you been able to generate unread badges for community channel cards in Jump-to? For me unread badges do not appear neither in develop nor in this PR.
    253153128-099a82e1-466c-4014-a5fe-0e75938e9a06 png (320×489) 2023-07-21 17-28-06

    I showed them by modifying the code for testing 🤔 I don't know how to get them from the app too.

    @ulisesmac ulisesmac merged commit 0ac6817 into develop Jul 21, 2023
    2 checks passed
    @ulisesmac ulisesmac deleted the 16551-name-shared-community-jump-to branch July 21, 2023 20:15
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 left review comments

    @ajayesivan ajayesivan ajayesivan approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @codemaster115 codemaster115 codemaster115 approved these changes

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    Assignees

    @ulisesmac ulisesmac

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Jump To: sharing community names on 2 lines
    9 participants
    @ulisesmac @status-im-auto @qoqobolo @pavloburykh @ajayesivan @smohamedjavid @J-Son89 @ibrkhalil @codemaster115