Enable layout animations by default #16832

Parveshdhull · 2023-08-01T19:26:35Z

Summary

The issue is happening due to layout animations (used by toasts). This is a known issue and happens because layout animations are disabled by default and when toasts tried to use them, it enabled layout animations at runtime and caused this weird behavior.

Once we upgrade to reanimated v3, this change will be redundant as layout animations will be enabled by default in newer versions

Testing:

Please also test #14752

(Thank you @qoqobolo for your help in tracking issue cause)

status: ready

status-im-auto · 2023-08-01T19:33:39Z

Jenkins Builds

Click to see older builds (24)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`d88a21a`	#1	2023-08-01 19:33:38	~6 min	`ios`	📱`ipa` 📲
✔️	`d88a21a`	#1	2023-08-01 19:36:46	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`d88a21a`	#1	2023-08-01 19:36:53	~9 min	`android`	🤖`apk` 📲
❌	`d88a21a`	#1	2023-08-01 19:37:11	~10 min	`tests`	📄`log`

✔️	`fda7f17`	#2	2023-08-02 13:09:12	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`fda7f17`	#2	2023-08-02 13:09:13	~6 min	`android`	🤖`apk` 📲
❌	`fda7f17`	#2	2023-08-02 13:11:28	~8 min	`tests`	📄`log`
✔️	`fda7f17`	#2	2023-08-02 13:12:40	~9 min	`ios`	📱`ipa` 📲

❌	`c90d29a`	#3	2023-08-02 14:03:50	~2 min	`tests`	📄`log`
✔️	`c90d29a`	#3	2023-08-02 14:06:53	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`c90d29a`	#3	2023-08-02 14:07:00	~5 min	`android`	🤖`apk` 📲
✔️	`c90d29a`	#3	2023-08-02 14:16:54	~15 min	`ios`	📱`ipa` 📲

✔️	`7416702`	#4	2023-08-02 14:50:18	~8 min	`android`	🤖`apk` 📲
✔️	`7416702`	#4	2023-08-02 14:50:31	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`7416702`	#4	2023-08-02 14:50:48	~9 min	`ios`	📱`ipa` 📲
✔️	`7416702`	#4	2023-08-02 14:52:03	~10 min	`tests`	📄`log`

✔️	`cbfdbf6`	#5	2023-08-02 15:12:28	~7 min	`android`	🤖`apk` 📲
✔️	`cbfdbf6`	#5	2023-08-02 15:16:41	~12 min	`ios`	📱`ipa` 📲
✔️	`cbfdbf6`	#5	2023-08-02 15:17:24	~12 min	`android-e2e`	🤖`apk` 📲
❌	`cbfdbf6`	#5	2023-08-02 15:17:59	~13 min	`tests`	📄`log`

✔️	`29cd76e`	#6	2023-08-03 12:00:27	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`29cd76e`	#6	2023-08-03 12:01:31	~6 min	`ios`	📱`ipa` 📲
✔️	`29cd76e`	#6	2023-08-03 12:03:44	~8 min	`android`	🤖`apk` 📲
✔️	`29cd76e`	#6	2023-08-03 12:04:17	~9 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ce5bfda`	#7	2023-08-03 12:56:01	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`ce5bfda`	#7	2023-08-03 12:56:57	~6 min	`android`	🤖`apk` 📲
✔️	`ce5bfda`	#7	2023-08-03 12:59:08	~8 min	`tests`	📄`log`

✔️	`27f3291`	#8	2023-08-03 13:04:57	~5 min	`android`	🤖`apk` 📲
✔️	`27f3291`	#8	2023-08-03 13:07:50	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`27f3291`	#8	2023-08-03 13:08:20	~9 min	`tests`	📄`log`
✔️	`27f3291`	#8	2023-08-03 13:16:55	~17 min	`ios`	📱`ipa` 📲

ulisesmac

🚀

ulisesmac · 2023-08-01T19:48:27Z

src/react_native/reanimated.cljs

                             runOnJS)]
            [reagent.core :as reagent]
            ["react-native-redash" :refer (withPause)]
            [react-native.flat-list :as rn-flat-list]
            [utils.worklets.core :as worklets.core]))

+(enableLayoutAnimations true)


Nice 👍
Thanks for solving it @Parveshdhull

Why don't we upgrade to reanimated v3?

Hi @ulisesmac,
Thank you very much for reviewing PR. Actually upgrade is currently blocked.

status-im-auto · 2023-08-01T20:16:09Z

88% of end-end tests have passed

Total executed tests: 40
Failed tests: 5
Passed tests: 35

IDs of failed tests: 702732,703133,703495,702783,702731

Failed tests (5)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
`Test is not run, e2e blocker` [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Delivered` `critical/chats/test_1_1_public_chats.py:1379: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not delivered after resending from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_mute_chat, id: 703495
Device 2: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 2: Looking for a message by text: Chat is unmuted now `critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New messages counter near chat name is not shown after unmute` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Passed tests (35)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
4. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
12. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

qoqobolo · 2023-08-02T11:01:17Z

Thanks @Parveshdhull, awesome work 🙌
We can't reproduce neither #16693 nor #14752 in this PR.
The fix seems to be working, but we'll keep an eye on it for sure and let you know if it's reproducible even after the merge.

Parveshdhull mentioned this pull request Aug 1, 2023

Upgrade Reanimated to V3 #15764

Closed

Parveshdhull self-assigned this Aug 1, 2023

Parveshdhull requested review from yqrashawn and ulisesmac August 1, 2023 19:27

Parveshdhull changed the title ~~Enabled layout animations by default~~ Enable layout animations by default Aug 1, 2023

Parveshdhull added the request-manual-qa label Aug 1, 2023

ulisesmac approved these changes Aug 1, 2023

View reviewed changes

qoqobolo self-assigned this Aug 2, 2023

qoqobolo added the Tested - OK label Aug 2, 2023

Parveshdhull force-pushed the fix/elements-overlap branch from d88a21a to fda7f17 Compare August 2, 2023 13:02

J-Son89 force-pushed the fix/elements-overlap branch 3 times, most recently from 7416702 to cbfdbf6 Compare August 2, 2023 15:04

Parveshdhull added the blocked label Aug 3, 2023

J-Son89 force-pushed the fix/elements-overlap branch from cbfdbf6 to 29cd76e Compare August 3, 2023 11:54

Enable layout animations by default

ce5bfda

Parveshdhull force-pushed the fix/elements-overlap branch from 29cd76e to ce5bfda Compare August 3, 2023 12:50

add comment

27f3291

Parveshdhull removed the blocked label Aug 3, 2023

Parveshdhull merged commit 109061a into develop Aug 3, 2023
2 checks passed

Parveshdhull deleted the fix/elements-overlap branch August 3, 2023 13:23

Parveshdhull mentioned this pull request Sep 21, 2023

Elements overlap each other on Android (profile selection page; chat view) #16693

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable layout animations by default #16832

Enable layout animations by default #16832

Parveshdhull commented Aug 1, 2023 •

edited

Loading

status-im-auto commented Aug 1, 2023 •

edited

Loading

ulisesmac left a comment

ulisesmac Aug 1, 2023

Parveshdhull Aug 1, 2023

status-im-auto commented Aug 1, 2023

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Aug 2, 2023

Enable layout animations by default #16832

Enable layout animations by default #16832

Conversation

Parveshdhull commented Aug 1, 2023 • edited Loading

Summary

Testing:

status-im-auto commented Aug 1, 2023 • edited Loading

Jenkins Builds

ulisesmac left a comment

Choose a reason for hiding this comment

ulisesmac Aug 1, 2023

Choose a reason for hiding this comment

Parveshdhull Aug 1, 2023

Choose a reason for hiding this comment

status-im-auto commented Aug 1, 2023

88% of end-end tests have passed

Failed tests (5)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (35)

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Aug 2, 2023

Parveshdhull commented Aug 1, 2023 •

edited

Loading

status-im-auto commented Aug 1, 2023 •

edited

Loading