Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test commit erase #16868

Closed
wants to merge 1 commit into from
Closed

Test commit erase #16868

wants to merge 1 commit into from

Conversation

tumanov-alex
Copy link
Contributor

This is the 1st commit message:

Add transaction_sheet
Add locked input component, tests, styles
Add translations
Add duration icons

Remove extra code

Use theme from context

Add missing code

Update styles
Update gas icon (previous was not reacting to size change) Use text from components instead of rn/text

Fix styling for transaction sheet preview, locked input & account selector components Fix purple 50 color since it doesn't match design

Work on PR suggestions
Fix style to be pixel-perfect

Comment-in tests

Fix style

Add docs for locked-input component

Remove extra code

Fixed design discrepancies

Fix font-weight

Fix purple color in account selector

Remove unused icons

Fix linter

Fix tests

This is the commit message #2:

fix for airplane mode

This is the commit message #3:

[161108] Optimize message styling when there's multiple mentions on top of each other (#16505)

This is the commit message #4:

Fix failing mute till test (#16453)

This is the commit message #5:

fix navigation to community from discover communities screen (#16702)

This is the commit message #6:

Update version to 0.162.3

This is the commit message #7:

[#16703] The display name is not resolved in chats for user sender after relogin (#16704)

This is the commit message #8:

Mute community

  • mute and unmute community

status-im/status-go@dfdaa72...e6187ae

  • mute and unmute community and all community chats

status-im/status-go@dfdaa72...3abc86e

  • updated statu-go

status-im/status-go@dfdaa72...919123e

  • refactored mute chat drawer

status-im/status-go@d3e650d...3af0b17

  • refactored mute chat drawer

status-im/status-go@dfdaa72...3af0b17

  • fixing mute channels

  • fixed mute community channels

  • update community chats mute status

status-im/status-go@dfdaa72...dc50ac2

  • added mute and unmute community toast

status-im/status-go@dfdaa72...c06f7a6

  • unmute community when atleast one community channel is unmuted

status-im/status-go@dfdaa72...e691c47

  • updated status-go

status-im/status-go@b2e56f5...c52718c

[Fix] Scroll to bottom on editing message (#16630)

This commit fixes (by skipping) the scroll to the bottom of messages when the user edits a message and sends it.

This is the commit message #10:

Refactor Bottom Sheet to use Theme Context (#16710)

This commit updates "Bottom Sheet" to use the theme (for theme provider) provided on the bottom sheet args when dispatching. This will ensure the theme is passed down to its child components where it can consume and render based on the theme.

Changes done:

In Bottom Sheet:

  • Fix Bottom Sheet to use the correct background colour (neutral-95) for dark mode (as per Figma)
  • Fix the Icon colour for danger in light mode
  • Updated Quo2 Preview to provide an option for the bottom sheet theme

In Action Drawer:

  • Refactor the Action Drawer component to consume theme context

If you submit PR for issue with bounty then write here Fixes #NN where NN is issue number

otherwise

fixes #...

Summary

...

Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx

Review notes

Testing notes

Platforms

  • Android
  • iOS
  • macOS
  • Linux
  • Windows

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats
  • wallet / transactions
  • dapps / app browsing
  • account recovery
  • new account
  • user profile updates
  • networks
  • mailservers
  • fleet
  • bootnodes
Non-functional
  • battery performance
  • CPU performance / speed of the app
  • network consumption

Steps to test

  • Open Status
  • ...
  • Step 3, etc.

status: ready

# This is the 1st commit message:

Add transaction_sheet
Add locked input component, tests, styles
Add translations
Add duration icons

Remove extra code

Use theme from context

Add missing code

Update styles
Update gas icon (previous was not reacting to size change)
Use text from components instead of rn/text

Fix styling for transaction sheet preview, locked input & account selector components
Fix purple 50 color since it doesn't match design

Work on PR suggestions
Fix style to be pixel-perfect

Comment-in tests

Fix style

Add docs for locked-input component

Remove extra code

Fixed design discrepancies

Fix font-weight

Fix purple color in account selector

Remove unused icons

Fix linter

Fix tests

# This is the commit message #2:

fix for airplane mode

# This is the commit message #3:

[161108] Optimize message styling when there's multiple mentions on top of each other (#16505)

# This is the commit message #4:

Fix failing mute till test (#16453)

# This is the commit message #5:

fix navigation to community from discover communities screen (#16702)

# This is the commit message #6:

Update version to 0.162.3

# This is the commit message #7:

[#16703] The display name is not resolved in chats for user sender after relogin (#16704)

# This is the commit message #8:

Mute community

* mute and unmute community

status-im/status-go@dfdaa72...e6187ae

* mute and unmute community and all community chats

status-im/status-go@dfdaa72...3abc86e

* updated statu-go

status-im/status-go@dfdaa72...919123e

* refactored mute chat drawer

status-im/status-go@d3e650d...3af0b17

* refactored mute chat drawer

status-im/status-go@dfdaa72...3af0b17

* fixing mute channels

* fixed mute community channels

* update community chats mute status

status-im/status-go@dfdaa72...dc50ac2

* added mute and unmute community toast

status-im/status-go@dfdaa72...c06f7a6

* unmute community when atleast one community channel is unmuted

status-im/status-go@dfdaa72...e691c47

* updated status-go

status-im/status-go@b2e56f5...c52718c

* updated status-go version v0.162.5
# This is the commit message #9:

[Fix] Scroll to bottom on editing message (#16630)

This commit fixes (by skipping) the scroll to the bottom of messages when the user edits a message and sends it.

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
# This is the commit message #10:

Refactor `Bottom Sheet` to use Theme Context (#16710)

This commit updates "Bottom Sheet" to use the theme (for theme provider) provided on the bottom sheet args when dispatching. This will ensure the theme is passed down to its child components where it can consume and render based on the theme.

Changes done:

In Bottom Sheet:
 - Fix Bottom Sheet to use the correct background colour (neutral-95) for dark mode (as per Figma)
 - Fix the Icon colour for danger in light mode
 - Updated Quo2 Preview to provide an option for the bottom sheet theme

In Action Drawer:
 - Refactor the Action Drawer component to consume theme context

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
@tumanov-alex tumanov-alex deleted the erase-test branch August 3, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant