Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16594] Make unread-indicator as last child of view #17064

Merged
merged 3 commits into from
Aug 22, 2023
Merged

[16594] Make unread-indicator as last child of view #17064

merged 3 commits into from
Aug 22, 2023

Conversation

ibrkhalil
Copy link
Contributor

fixes #16594

Summary

The unread indicator was handled to show on the top using z-index, Sometimes that didn't work so making it last child of it's parent view made it always the last thing to show on top.

status: ready

@ibrkhalil ibrkhalil self-assigned this Aug 20, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Aug 20, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 45af09e #1 2023-08-20 13:34:56 ~8 min ios 📱ipa 📲
✔️ 45af09e #1 2023-08-20 13:36:46 ~9 min android 🤖apk 📲
✔️ 45af09e #1 2023-08-20 13:36:47 ~9 min android-e2e 🤖apk 📲
✔️ 45af09e #1 2023-08-20 13:37:14 ~10 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ f932582 #2 2023-08-21 11:12:53 ~3 min tests 📄log
✔️ f932582 #2 2023-08-21 11:16:37 ~6 min android-e2e 🤖apk 📲
✔️ f932582 #2 2023-08-21 11:16:42 ~6 min android 🤖apk 📲
✔️ f932582 #2 2023-08-21 11:17:04 ~7 min ios 📱ipa 📲
✔️ 256e90b #3 2023-08-22 09:40:26 ~6 min android 🤖apk 📲
✔️ 256e90b #3 2023-08-22 09:42:15 ~7 min ios 📱ipa 📲
✔️ 256e90b #3 2023-08-22 09:43:56 ~9 min android-e2e 🤖apk 📲
✔️ 256e90b #3 2023-08-22 09:44:58 ~10 min tests 📄log

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 43
Failed tests: 3
Passed tests: 40

IDs of failed tests: 702732,702786,702731

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Admin gets push notification with the mention and tap it
    Device 1: Getting PN by 'user_1' 

    critical/test_public_chat_browsing.py:1082: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:177: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (40)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    5. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    6. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    7. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    8. test_community_message_delete, id: 702839
    Device sessions

    9. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    10. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    11. test_community_message_edit, id: 702843
    Device sessions

    12. test_community_leave, id: 702845
    Device sessions

    13. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    8. test_1_1_chat_edit_message, id: 702855
    Device sessions

    9. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    10. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    @status-im-auto
    Copy link
    Member

    91% of end-end tests have passed

    Total executed tests: 43
Failed tests: 4
Passed tests: 39

    IDs of failed tests: 702732,702745,702786,702731

    Failed tests (4)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find `MemberPhoto` by `xpath`: `//*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']`
    Device 2: Image differs from template to 6.207059972426471 percents 

    critical/chats/test_1_1_public_chats.py:1129: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:177: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image of user in 1-1 chat is too different from template!



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Admin gets push notification with the mention and tap it
    Device 1: Getting PN by 'user_1' 

    critical/test_public_chat_browsing.py:1082: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:177: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin



    Device sessions

    Passed tests (39)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    6. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    7. test_1_1_chat_edit_message, id: 702855
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    9. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    5. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    6. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    7. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    8. test_community_message_delete, id: 702839
    Device sessions

    9. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    10. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    11. test_community_message_edit, id: 702843
    Device sessions

    12. test_community_leave, id: 702845
    Device sessions

    13. test_community_unread_messages_badge, id: 702841
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Aug 21, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    Hi @ibrkhalil thank you for PR. The issue is fixed.
    Could you resolve please the failed https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-17064/2/consoleText integration tests?

    @ibrkhalil ibrkhalil merged commit 8e7c6fe into develop Aug 22, 2023
    2 checks passed
    @ibrkhalil ibrkhalil deleted the 16594 branch August 22, 2023 11:20
    andresceballosm pushed a commit to andresceballosm/status-mobile that referenced this pull request Aug 29, 2023
    @ibrkhalil @andresceballosm-truenorth
    Make undread-indicator as last child of view (status-im#17064)
    08fe087
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jo-mut jo-mut jo-mut approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees

    @ibrkhalil ibrkhalil

    @VolodLytvynenko VolodLytvynenko

    Labels
    integration-tests request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Unread counter is located behind AC icon if notification is received while Shell was opened (Android)
    6 participants
    @ibrkhalil @status-im-auto @VolodLytvynenko @ilmotta @flexsurfer @jo-mut