nix: make fetching Gradle dependencies more generic #17161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubgs
added
android
nix
dependencies
Jenkins BuildsClick to see older builds (31)
|
jakubgs
force-pushed
the
nix/generic-maven-url2json
branch
5 times, most recently
from
ad20022
to
1ba7714
Compare
|
Here's the difference in sizes of the Gradle dependencies derivation: BeforeAfterWhich is not horrible. Out of the new files most are the This is annoying because as far as I can tell only one package actually requires the |
siddarthkay
reviewed
Sep 1, 2023
siddarthkay
approved these changes
Sep 1, 2023
|
I think I can make the blacklist more strict. I believe we only need ASC files for AARs - of which there is only 32 - for builds. |
jakubgs
force-pushed
the
nix/generic-maven-url2json
branch
from
8feac89
to
4c32c43
Compare
|
That's better: A |
Before what we did was essentially guess what files might exist for any given package. This approach mostly works, but not entirely. This is especially problematic when dealing with weird edge case packages like `react-native`, which you can read about here: react-native-community/discussions-and-proposals#508 https://github.com/react-native-community/discussions-and-proposals/blob/4a06fc64/proposals/0508-out-of-npm-artifacts.md#the-react-native-android-archive In order to avoid as much the guessing aspect of fetching Gradle dependencies we are using both HTML listsings of files and `artifact-metadata.json` files that exist for more recent packages. This way we can avoid having to add special edge cases that have been found out when working on React Native 72 upgrade in: #17062 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
nix/generic-maven-url2json
branch
from
6779803
to
83f622d
Compare
Signed-off-by: Jakub Sokołowski <jakub@status.im>
yakimant
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before what we did was essentially guess what files might exist for any given package. This approach mostly works, but not entirely. This is especially problematic when dealing with weird edge case packages like
react-native, which you can read about here:In order to avoid as much the guessing aspect of fetching Gradle dependencies we are using both HTML listsings of files and
artifact-metadata.jsonfiles that exist for more recent packages.This way we can avoid having to add special edge cases that have been found out when working on React Native 72 upgrade in: