Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(identifier): emoji hash line height #17386

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(identifier): emoji hash line height #17386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/status_im2/contexts/onboarding/identifiers/profile_card/style.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,5 @@
{:margin-top 2})))

(def emoji-hash
{:margin-top 12})
{:margin-top 12
:line-height 20.5})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about .5 ?

Copy link
Contributor Author

@BalogunofAfrica BalogunofAfrica Sep 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the lineHeight of 20.5 matches the designs' spacing and height.

The design uses regular images in a row for the emoji hash while we use text for this, and the lineHeight of the text used initially was 21.75 (paragraph-1 in typography).