-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue button is invisible behind keyboard in Add Address To Watch … #17940
Conversation
Jenkins BuildsClick to see older builds (26)
|
71% of end-end tests have passed
Failed tests (8)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Expected to fail tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (32)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
|
Thanks for the pr @ibrkhalil - @ulisesmac & I have been working on a generic approach for this as it is common to many pages in the wallet / redesign screens. We merged the pr last week and intending to use this approach on this screen. |
I used it, Can you kindly take another look? |
Thanks @ibrkhalil - code looks good to me. WDYT about that component, looks alright/ working okay? api makes sense etc? |
I think the animation that happens when keyboard opens can be improved as there's a 'slight' jump that happens when the keyboard gets toggled on my iOS simulator, I think that's caused because rn/keyboard returns it's values after the keyboard gets completely loaded/dismissed. We can utilize composer's focused property here which I think would make it seamless. Other than that the code looks excellent, Thank you! |
thanks for the feedback @ibrkhalil - sure we can adjust that in another pr :) |
Very interesting, yep, we can improve the behavior @J-Son89 :) |
@ibrkhalil |
Done |
100% of end-end tests have passed
Passed tests (8)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
|
Hi @ibrkhalil thank you for PR. Ready to be merged |
fixes #17888
status: ready