-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add common page-nav component for wallet #17946
Conversation
Jenkins BuildsClick to see older builds (7)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
b409abd
to
b8c7b60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good abstraction! 👏
58% of end-end tests have passed
Failed tests (15)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Expected to fail tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (26)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
73% of end-end tests have passed
Failed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (11)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
b8c7b60
to
8b43d3d
Compare
@qoqobolo - I rebased to bring this branch to latest develop, no changes made 👌 |
50% of end-end tests have passed
Failed tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (2)Click to expandClass TestActivityMultipleDevicePR:
|
Thanks @J-Son89! Tested the latest build, LGTM. |
8b43d3d
to
c913e8a
Compare
thanks @qoqobolo! :) |
fixes: #17872
This pr creates a single component for handling the account switcher in the wallet and updates the uses in the pr. Some of the data in this component is still mocked but handling this properly depends on pr: #17862 for this reason that will be done as a follow up, however it is using the correct emoji and colour etc of the current account being viewed.
Screens to check:
New Wallet account page
Select Address (Send To) page B
Bridge Page (click bridge button on account page)
Bridge Page
![](https://private-user-images.githubusercontent.com/22799766/284099661-fca15ab5-5da7-42cd-ac39-ffd39f973f0c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDMyNTcsIm5iZiI6MTczOTM0Mjk1NywicGF0aCI6Ii8yMjc5OTc2Ni8yODQwOTk2NjEtZmNhMTVhYjUtNWRhNy00MmNkLWFjMzktZmZkMzlmOTczZjBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA2NDkxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxZTA4NjE5ZDNkMTI0NGZiNTM4NjI2ODIzMzJiMzkyNmIwNTlmYjI1MTgzZTdjZTM4ZmUxM2Q3N2M1NDM1MjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Cqeb2bw_YeSOk8rx6du7nl7aDQamTaZN65QXvmCMtIk)
Send To
![](https://private-user-images.githubusercontent.com/22799766/284099662-2a749c39-9e01-4ff5-a84e-88169ab8618c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDMyNTcsIm5iZiI6MTczOTM0Mjk1NywicGF0aCI6Ii8yMjc5OTc2Ni8yODQwOTk2NjItMmE3NDljMzktOWUwMS00ZmY1LWE4NGUtODgxNjlhYjg2MThjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA2NDkxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNkNDM4MWQxNzU5MTEyNTNiNGEyOGZkNDRhMDg5YzI2MDk3OWMzODYzNTZiNTNjYTZiMWE0MmViNmI3YWZmMTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.JI_mXcoh-AMJzGov7S61cv3FXb_OOCyo00HZgE4gMxU)
App switcher menu
![](https://private-user-images.githubusercontent.com/22799766/284099659-661670a9-0df9-49e2-8f69-26b4bfb2022d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDMyNTcsIm5iZiI6MTczOTM0Mjk1NywicGF0aCI6Ii8yMjc5OTc2Ni8yODQwOTk2NTktNjYxNjcwYTktMGRmOS00OWUyLThmNjktMjZiNGJmYjIwMjJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA2NDkxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRhYWFkNTViNTgzMzU5MjM4ZjNmOTIzNzM1M2FiNmNjNGQ1NjI0ZDFjNDliOGNjN2JjMmIyNzg5YjFkMGY1MzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.u2azqDwyNRL4SD15lCpKd6B1o3QRl3E49_6iErTHzyM)
![Screenshot 2023-11-18 at 18 41 48](https://private-user-images.githubusercontent.com/22799766/284099664-3b1c1b11-c9ee-483b-b0ee-f35353a5dcfa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDMyNTcsIm5iZiI6MTczOTM0Mjk1NywicGF0aCI6Ii8yMjc5OTc2Ni8yODQwOTk2NjQtM2IxYzFiMTEtYzllZS00ODNiLWIwZWUtZjM1MzUzYTVkY2ZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA2NDkxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlMDFjZjI5ODgxZDJlZGE4NDU5ZWFkNGEwNDE4Yzk2N2Q4NmJkNjUzNTA1MDJjMzBhNDlmN2Q4YzA2ODdiNDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ZRebUCcHNuABLMgcdh3DRVW6itLpqTS5hTUGQPU9cz8)
Account Page