Match the changes in collectibles api in status-go #18033
Conversation
vkjr
requested review from
ilmotta,
briansztamfater,
J-Son89 and
siddarthkay
Jenkins BuildsClick to see older builds (8)
|
| [:wallet/last-collectible-details]) | ||
| {:keys [id collectible-data preview-url collection-data]} collectible | ||
| {:keys [traits description]} collectible-data | ||
| chain-id (get-in id [:contract-id :chain-id])] |
There was a problem hiding this comment.
should we have a sub to access this data instead?
There was a problem hiding this comment.
good idea, will update it!
| @@ -231,18 +232,37 @@ | |||
|
|
|||
| (rf/reg-event-fx :wallet/store-last-collectible-details store-last-collectible-details) | |||
|
|
|||
| (def collectible-data-types | |||
There was a problem hiding this comment.
It's very helpful during refactors to see private vars with the metadata because then we feel much safer to move things around knowing we're not missing usages. clojure-lsp helps a lot, but I don't fully trust it at all times because it's easy to get in a situation where the cache is stale while changing a lot of code.
| collectibles-request-batch-size | ||
| data-type | ||
| fetch-criteria]] | ||
| {:json-rpc/call [{:method "wallet_getOwnedCollectiblesAsync" |
There was a problem hiding this comment.
I've noticed we are having trouble following the re-frame guideline for using only :db and :fx in the returned map (https://github.com/status-im/status-mobile/blob/develop/doc/new-guidelines.md#registering-event-handlers). A lot of events in the repo only dispatch one effect (plus maybe the :db) so maybe we should relax that guideline. I would prefer if we had only one way of doing something and following re-frame's best practices, but it's tedious to comment in PRs to reinforce this guideline, so realistically speaking we should consider relaxing that guideline if we can't properly enforce it.
vkjr
force-pushed
the
collectibles-api-change
branch
from
61e9240
to
e645a2a
Compare
vkjr
force-pushed
the
collectibles-api-change
branch
from
642479b
to
3c6ebc9
Compare
fixes #17936
Summary
Collectible api was changed by this status-go PR.
This PR updates the mobile code to match the changes.
Review notes
Latest
status-gocommit used, not sure if it is better to use the commit from PR with API changes.status: ready