PR to make purge script more robust for MacOS #18192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
siddarthkay
changed the title
siddarthkay
force-pushed
the
fix-nix-purge-script
branch
2 times, most recently
from
b06e9f7
to
68df406
Compare
siddarthkay
force-pushed
the
fix-nix-purge-script
branch
2 times, most recently
from
d6c978a
to
08fe08c
Compare
siddarthkay
force-pushed
the
fix-nix-purge-script
branch
from
08fe08c
to
df488c7
Compare
|
@status-im/mobile-qa : merged without QA because this change only effects local dev environments. |
jakubgs
reviewed
Jan 2, 2024
Comment on lines
+52
to
+62
| echo "The volume /nix is in use by process ID $pid." | ||
|
|
||
| # Ask the user whether to terminate the process | ||
| read -p "Do you want to terminate this process? (y/n): " choice | ||
| if [[ $choice == "y" ]]; then | ||
| sudo kill $pid | ||
| echo "Process $pid terminated." | ||
| else | ||
| echo "Process not terminated. Please close it manually and retry." | ||
| return 1 | ||
| fi |
There was a problem hiding this comment.
This whole thing should be a function. Or even a separate scripts/kill_proc_prompt.sh.
jakubgs
reviewed
Jan 2, 2024
Comment on lines
+28
to
+29
| sudo launchctl unload "${NIX_SERVICE}" || true | ||
| sudo launchctl remove "${NIX_SERVICE}" || true |
There was a problem hiding this comment.
This isn't "robust", this is just ignoring failures.
There was a problem hiding this comment.
We need to understand why unload would fail.
jakubgs
reviewed
Jan 2, 2024
Comment on lines
+74
to
+76
| nix_purge_darwin_multi_user_service || true | ||
| nix_purge_darwin_multi_user_users || true | ||
| nix_purge_darwin_multi_user_volumes || true |
There was a problem hiding this comment.
Same here, this is not "robust", it just ignores failures and continues.
|
I do not like any of the |
|
@jakubgs : I agree with your review on this PR, the intent back then was to make sure that the purge script would run without exiting when it encountered any failures and so that the devs would be able to purge nix via this script without the need for any manual intervention. I created #18360 to detail out the issues with the existing steps so that we can perform a proper fix. Thank you |
siddarthkay
added a commit
that referenced
this pull request
Jan 30, 2024
## Summary In this commit we : - instead of `cd` to `/Library/LaunchDaemons` and then attempting to `launchctl unload` the nixos plist files we just pass the full path to unload as seen in `nix` documentation here : https://nixos.org/manual/nix/stable/installation/uninstall.html#:~:text=Stop%20and%20remove%20the%20Nix%20daemon%20services%3A - move killing a process by prompting for confirmation to a new shell script as per feedback from previous PR : #18192 (comment) - fix few small typos ## Platforms - macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing purge script for Darwin would fail and stop at many stages.
This PR makes the script more robust to certain failures that were observed and documented in #16404
fixes #16404
status: ready