set make run-metro target to clojure
#18215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
J-Son89
approved these changes
Dec 17, 2023
siddarthkay
requested review from
jakubgs,
yakimant,
apentori,
flexsurfer,
Parveshdhull and
OmarBasem
Parveshdhull
approved these changes
Dec 18, 2023
OmarBasem
approved these changes
Dec 18, 2023
siddarthkay
force-pushed
the
fix-metro-target
branch
from
7a4def5
to
3a2189b
Compare
|
@status-im/mobile-qa : merged without QA because this change only effects local dev environments. |
|
|
|
@flexsurfer : I mean it builds faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metro terminal no longer needs to have
androidtarget anymore.I had to do this in #17241
This PR sets the target of metro terminal back to
clojure.I tested building
androidandiOSon my MacOS and on my linux machines and found no side effect.Now metro terminal is fast again.
status: ready