Wallet: send token from drawer #18429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
requested review from
J-Son89,
briansztamfater,
vkjr,
smohamedjavid,
ulisesmac and
shivekkhurana
Jenkins BuildsClick to see older builds (12)
|
|
@OmarBasem, @briansztamfater - is the mechanics under the hood working as expected for this? 🤔 |
|
@J-Son89 The flow is the same, except that when going to the send flow from a token's drawer the select asset screen will be skipped as it has already been selected. Maybe to make them consistent, in the default send flow, selecting the token could be done before selecting the destination address. I think other apps do it that way, and it would be consistent with when entering the send flow from a token's drawer. |
|
> @J-Son89 The flow is the same, except that when going to the send flow from a token's drawer the select asset screen will be skipped as it has already been selected. > Maybe to make them consistent, in the default send flow, selecting the token could be done before selecting the destination address. I think other apps do it that way, and it would be consistent with when entering the send flow from a token's drawer. |
|
@J-Son89 yes tested them, both paths work the same |
J-Son89
approved these changes
Jan 8, 2024
79% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (38)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
smohamedjavid
approved these changes
Jan 9, 2024
|
|
||
| (rf/reg-event-fx :wallet/clean-selected-token | ||
| (fn [{:keys [db]}] | ||
| {:db (assoc-in db [:wallet :ui :send :token] nil)})) |
There was a problem hiding this comment.
Can we dissoc :token instead of setting a nil value?
vkjr
approved these changes
Jan 9, 2024
|
Hey @OmarBasem could you resolve the conflicts, please? |
OmarBasem
force-pushed
the
wallet/send-token-drawer
branch
from
e93a55f to
e4f6b20
Compare
Done! |
67% of end-end tests have passedFailed tests (13)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (3)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (32)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
92% of end-end tests have passedFailed tests (1)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Passed tests (12)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
|
|
Thank you @OmarBasem, PR can be merged! |
OmarBasem
force-pushed
the
wallet/send-token-drawer
branch
from
e4f6b20 to
1263b57
Compare
OmarBasem
force-pushed
the
wallet/send-token-drawer
branch
from
1263b57 to
f5d46da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements sending a token from the token item drawer.
Demo:
Screen_Recording_20240108_123806_Status.mp4