Editable profile screen #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| account {:public-key public-key | ||
| :address address | ||
| :name address | ||
| :phone "" |
There was a problem hiding this comment.
Why not just ignore that values if they are empty?
alwx
force-pushed
the
feature/profile-screen
branch
2 times, most recently
from
c86088d
to
314e375
Compare
|
@rasom this issue seems to be an issue with react-native-camera, because we don't control the process of capturing photo |
| photo-path :photo-path | ||
| phone :phone | ||
| status :status | ||
| :as account} @(subscribe [:get-current-account]) |
There was a problem hiding this comment.
This is not a correct way to subscriptions usage and views definition in re-frame. We have to follow form-2 here as everywhere. In result, this view will be slower than it could be.
As example, it can be done this way d61b8c0
|
@alwx please, check all view functions whether they follow form-1,form-2 or form-3 from https://github.com/Day8/re-frame/wiki/Creating%20Reagent%20Components or use |
* ability to edit profile data * ability to update status (we save it internally for now) * ability to change profile picture (from camera or gallery) * enhanced way of storing profile-related data in realm and internal state db
alwx
force-pushed
the
feature/profile-screen
branch
from
314e375
to
91d8ecc
Compare
|
@rasom fixed. |
0xc1c4da
pushed a commit
that referenced
this pull request
Jan 5, 2017
Editable profile screen Former-commit-id: 05798fc
rasom
added a commit
that referenced
this pull request
Sep 8, 2017
changes in shh API according to https://github.com/ethereum/go-ethereum/wiki/Whisper-v5-RPC-API
rasom
added a commit
that referenced
this pull request
Sep 13, 2017
changes in shh API according to https://github.com/ethereum/go-ethereum/wiki/Whisper-v5-RPC-API
rasom
added a commit
that referenced
this pull request
Sep 18, 2017
changes in shh API according to https://github.com/ethereum/go-ethereum/wiki/Whisper-v5-RPC-API
rasom
added a commit
that referenced
this pull request
Sep 18, 2017
changes in shh API according to https://github.com/ethereum/go-ethereum/wiki/Whisper-v5-RPC-API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182