Wallet - Add support for Sepolia testnet and Rarible collectible provider #18519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (52)
|
smohamedjavid
force-pushed
the
feature/add-support-for-sepolia-and-rarible
branch
8 times, most recently
from
cb946cf to
e405f6e
Compare
smohamedjavid
changed the title
This was referenced Jan 25, 2024
smohamedjavid
force-pushed
the
feature/add-support-for-sepolia-and-rarible
branch
from
e405f6e to
1d0b834
Compare
jakubgs
approved these changes
Jan 29, 2024
ulisesmac
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Thanks for the PR @smohamedjavid
I just left a small comment.
Yeah, It's much easier. I'm not sure about using a file (except |
71% of end-end tests have passedFailed tests (12)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (34)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
@smohamedjavid thanks a lot for this PR. Unfortunately currently we are blocked from proper testing due to #18652 as we need to test transactions sending which is impossible due to the mentioned issue. We will get back to testing of this PR as soon as #18652 is fixed. |
vkjr
approved these changes
Jan 30, 2024
smohamedjavid
force-pushed
the
feature/add-support-for-sepolia-and-rarible
branch
from
ad78964 to
c44f358
Compare
|
Hey @smohamedjavid , I'm still a bit confused. Currently, we have two conflicting testnet networks. Here are some examples:
Also, one more question: Are we planning to continue supporting the Goerli test network? I thought one of the goals of this PR was to replace Goerli with Sepolia. Is that still the case? |
|
Goerli/Prater is essentialy dead and needs to be removed:
https://blog.ethereum.org/2023/11/30/goerli-lts-update We have about two months left. |
Answering both queries. @VolodLytvynenko Apologies for the confusion 🙏. By default, when the user has enabled the In short, the
No, we don't leave both test networks in this state. The toggle
No, We won't continue supporting the Goerli testnet as it will shut down soon as @jakubgs stated. There are plans to replace Goerli with Sepolia (making Sepolia testnet default and removing the toggle) soon. This PR doesn't replace Goerli with Sepolia. It adds Sepolia support in the mobile. |
|
@smohamedjavid thanks for the answer!
No need to invest effort in this. As you have already mentioned - Goerli soon will be deprecated and we will have only 1 toggle 'Enable testnet'. |
|
Hey @smohamedjavid could you please rebase current and status go https://github.com/status-im/status-go/tree/chore/mobile-wallet-config PR? Thanx! |
smohamedjavid
force-pushed
the
feature/add-support-for-sepolia-and-rarible
branch
from
c44f358 to
2deff6c
Compare
88% of end-end tests have passedFailed tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (42)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
|
|
hi @smohamedjavid Could you take a look. Seems the Sepolia tokens/collectibles stop sending after rebase ISSUE 1: The sepolia tokens/collectibles not updated after sendingSteps:
Actual result:The tokens amount/collectibles are not transferred to Expected result:The tokens amount/collectibles are transferred to the Additional info:Note: The goerli tokens and collectibles are transferred successfully after sending Logs: |
|
@VolodLytvynenko - I tried the branch on the simulator. Additionally, I checked the PR build on an iOS device. |
@smohamedjavid that's strange. I checked it several times on different devices. I will try one more time. Thanks for checking |
|
Hey @smohamedjavid you are right. The sepolia assets transition goes correctly for me now, both tokens and collectibles. Last time I executed 2-3 different transactions and waited at least 1 hour to see update. Now, no issues from my side. PR is ready to be merged |
|
@VolodLytvynenko - Thanks for testing this PR 🙏 |
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
status-im/status-go@9879b1e...9378d99 Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
status-im/status-go@9879b1e...89f7949 Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
status-im/status-go@9879b1e...b83cd41 Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
force-pushed
the
feature/add-support-for-sepolia-and-rarible
branch
from
2deff6c to
caa8d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18188
fixes #18510
Summary
This PR adds support for the Sepolia test network and Rarible collectible/collection provider.
networkandnetwork infoin the advanced settings will be removed soon (shortly in a separate PR) as it's from the old wallet. Please don't confuse it with new wallet settings (Enable Testnet mode, andEnable Sepolia as Test network).Platforms
Areas impacted
Functional
Steps to test
Profile > Advanced SettingsTestnet modeSepolia as Test networkTesting Notes:
status: ready