Fix collectibles scroll crash #18658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohamedjavid
approved these changes
Jan 29, 2024
Jenkins BuildsClick to see older builds (8)
|
|
@clauxx Probably another fix we should first try (before trying to implement something in status-go) is changing the window size in the flat-list. |
@ulisesmac could you explain? Not sure how that will help |
It'd be good to check if the app is breaking because of the cache size or because of too many images/gifs/svgs being drawn at the same time. We could use change the window size (reduce it) to check if it solves the problem: |
It will help with the performance, but will add more blank space while scrolling and wouldn't solve the memory issue of rendering images and gifs that are sometimes too heavy (>10MB) when using |
|
@status-im/mobile-qa I moved it to E2E but the tests didn't show up for some reason :( |
@clauxx Thank you. The e2e tests were not triggered again. I have rerun it one more time. Now, I see the run in a queue. The result should be ready in 40-50 minutes |
67% of end-end tests have passedFailed tests (14)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (32)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
50% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Passed tests (7)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
29% of end-end tests have passedFailed tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
|
|
Hi @clauxx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18644
Summary
The crash seems to come from using
react-native-fast-image, caused by excessive memory usage. There's an old issue there, where rendering tons of large images in a flatlist causes a huge memory jump (usually from quick scrolling) and a crash. The core cause though seems to be the size/resolution of our images and GIFs, some of which can easily exceed 10MB.This is a temporary fix by going back to using the RN image component until we find a way to show the images without sacrificing performance. Ideally, we'd generate lower-res previews on status-go that would be displayed in the flatlist.
Platforms
Areas that maybe impacted
Functional
Non-functional
Steps to test
status: ready