Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate reagent atom part 2 #18905

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Migrate reagent atom part 2 #18905

merged 1 commit into from
Feb 28, 2024

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Feb 19, 2024 •
edited
Loading

Please review only second commit 5fa139d

@flexsurfer flexsurfer self-assigned this Feb 19, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Feb 19, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (27)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 4ab6970 #1 2024-02-19 15:51:51 ~5 min tests 📄log
✔️ 4ab6970 #1 2024-02-19 15:54:10 ~7 min android-e2e 🤖apk 📲
✔️ 4ab6970 #1 2024-02-19 15:54:18 ~8 min android 🤖apk 📲
✔️ 4ab6970 #1 2024-02-19 16:00:38 ~14 min ios 📱ipa 📲
❌ 4ab6970 #2 2024-02-19 16:02:47 ~5 min tests 📄log
❌ a7b7344 #3 2024-02-26 10:04:08 ~5 min tests 📄log
✔️ a7b7344 #2 2024-02-26 10:06:27 ~7 min android 🤖apk 📲
✔️ a7b7344 #2 2024-02-26 10:06:39 ~7 min android-e2e 🤖apk 📲
✔️ a7b7344 #2 2024-02-26 10:11:05 ~11 min ios 📱ipa 📲
✔️ 069cecf #3 2024-02-26 10:26:31 ~8 min android 🤖apk 📲
✔️ 069cecf #3 2024-02-26 10:27:16 ~9 min android-e2e 🤖apk 📲
✔️ 069cecf #3 2024-02-26 10:30:33 ~12 min ios 📱ipa 📲
❌ f3c7859 #5 2024-02-26 12:43:42 ~4 min tests 📄log
✔️ f3c7859 #4 2024-02-26 12:46:32 ~7 min android-e2e 🤖apk 📲
✔️ f3c7859 #4 2024-02-26 12:46:38 ~7 min android 🤖apk 📲
✔️ f3c7859 #4 2024-02-26 12:48:17 ~9 min ios 📱ipa 📲
✔️ 4758069 #6 2024-02-26 15:32:48 ~5 min tests 📄log
✔️ 4758069 #5 2024-02-26 15:35:43 ~8 min android 🤖apk 📲
✔️ 4758069 #5 2024-02-26 15:35:43 ~8 min android-e2e 🤖apk 📲
✔️ 5fa139d #7 2024-02-26 15:42:10 ~6 min tests 📄log
✔️ 5fa139d #6 2024-02-26 15:45:04 ~8 min android 🤖apk 📲
✔️ 5fa139d #6 2024-02-26 15:45:05 ~8 min android-e2e 🤖apk 📲
✔️ 5fa139d #6 2024-02-26 15:47:11 ~11 min ios 📱ipa 📲
✔️ 3ae1e4a #7 2024-02-27 15:31:47 ~54 min android 🤖apk 📲
❌ 3ae1e4a #8 2024-02-27 15:32:02 ~54 min tests 📄log
✔️ 3ae1e4a #7 2024-02-27 15:32:46 ~55 min android-e2e 🤖apk 📲
✔️ 3ae1e4a #7 2024-02-27 17:07:12 ~2 hr 29 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f8d9d91 #9 2024-02-28 08:55:17 ~7 min tests 📄log
✔️ f8d9d91 #8 2024-02-28 08:57:00 ~9 min android-e2e 🤖apk 📲
✔️ f8d9d91 #8 2024-02-28 08:57:46 ~10 min android 🤖apk 📲
✔️ f8d9d91 #8 2024-02-28 08:58:46 ~11 min ios 📱ipa 📲
✔️ 89f3560 #10 2024-02-28 10:56:49 ~6 min tests 📄log
✔️ 89f3560 #9 2024-02-28 10:58:58 ~9 min android-e2e 🤖apk 📲
✔️ 89f3560 #9 2024-02-28 11:04:22 ~14 min ios 📱ipa 📲

@flexsurfer flexsurfer force-pushed the feature/migrate-reagent-atom-part-2 branch from 4ab6970 to a7b7344 Compare February 26, 2024 09:58
@flexsurfer flexsurfer changed the title [WIP] Migrate reagent atom part 2 Migrate reagent atom part 2 Feb 26, 2024
@flexsurfer flexsurfer force-pushed the feature/migrate-reagent-atom-part-2 branch from 4758069 to 5fa139d Compare February 26, 2024 15:35
clauxx
clauxx reviewed Feb 27, 2024
View reviewed changes
src/quo/components/colors/color_picker/view.cljs Show resolved Hide resolved
src/quo/components/inputs/recovery_phrase/component_spec.cljs Outdated Show resolved Hide resolved
src/status_im/common/bottom_sheet/view.cljs Outdated
Comment on lines 84 to 88
(rn/use-effect
#(if hide?
(hide translate-y bg-opacity window-height on-close)
(show translate-y bg-opacity))
[hide?])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a reason to remove the use-effect deprecation, or would this be refactored away from use-effect?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, i need to take a look

@flexsurfer flexsurfer force-pushed the feature/migrate-reagent-atom-part-2 branch 2 times, most recently from 3ae1e4a to f8d9d91 Compare February 28, 2024 08:47
clauxx
clauxx approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@clauxx clauxx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 48
Failed tests: 4
Expected to fail tests: 1
Passed tests: 43

IDs of failed tests: 703194,703133,702745,702731 

IDs of expected to fail tests: 703503

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Tap on found: Button
    Device 1: Wait for element `Button` for max 30s and click when it is available 

    critical/chats/test_public_chat_browsing.py:195: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.recover_access(passphrase=waku_user.seed, second_user=True)
../views/sign_in_view.py:278: in recover_access
    self.identifiers_button.wait_and_click(30)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Button by accessibility id:`skip-identifiers` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    # STEP: Send messages with non-latin symbols
    Device 1: Find Button by accessibility id: jump-to 

    critical/chats/test_1_1_public_chats.py:278: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.home_1.jump_to_card_by_text(self.username_2)
../views/base_view.py:658: in jump_to_card_by_text
    self.click_on_floating_jump_to()
../views/base_view.py:647: in click_on_floating_jump_to
    self.jump_to_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731

    Device 1: Find Text by xpath: //*[starts-with(@text,'Message 4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 1: Text is Sent 

    critical/chats/test_1_1_public_chats.py:222: in test_1_1_chat_pin_messages
    self.chat_1.chat_element_by_text(message).wait_for_status_to_be("Delivered")
../views/chat_view.py:243: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194

    Device 2: Tap on found: SendMessageButton
    Device 1: Looking for a message by text: reply to gallery 

    critical/chats/test_public_chat_browsing.py:428: in test_community_several_images_send_reply
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Reply message was not received by the sender



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (43)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859
    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @flexsurfer failed e2e are not PR related

    @pavloburykh pavloburykh mentioned this pull request Feb 28, 2024
    Merged
    @flexsurfer flexsurfer force-pushed the feature/migrate-reagent-atom-part-2 branch from f8d9d91 to 89f3560 Compare February 28, 2024 10:49
    @flexsurfer flexsurfer merged commit b7bffb3 into develop Feb 28, 2024
    2 of 4 checks passed
    @flexsurfer flexsurfer deleted the feature/migrate-reagent-atom-part-2 branch February 28, 2024 10:49
    @ulisesmac ulisesmac mentioned this pull request Mar 15, 2024
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @clauxx clauxx clauxx approved these changes

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    Assignees

    @flexsurfer flexsurfer

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @flexsurfer @status-im-auto @pavloburykh @clauxx