Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't run contract tests in test-unit target #18947

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Feb 22, 2024

Summary

I noticed today a small regression from commit 9acf67d, where we introduced contract tests. In develop we're now running contract tests whenever the test-unit target runs. This PR fixes the typo.

status: ready

Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops 😅 thanks @ilmotta!

@status-im-auto
Copy link
Member

status-im-auto commented Feb 22, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 879e22c #1 2024-02-22 12:06:21 ~6 min tests 📄log
✔️ 879e22c #1 2024-02-22 12:07:57 ~7 min ios 📱ipa 📲
✔️ 879e22c #1 2024-02-22 12:09:07 ~9 min android-e2e 🤖apk 📲
✔️ 879e22c #1 2024-02-22 12:09:35 ~9 min android 🤖apk 📲
✔️ eb280ac #2 2024-02-22 12:26:21 ~5 min tests 📄log
✔️ eb280ac #2 2024-02-22 12:29:11 ~8 min android-e2e 🤖apk 📲
✔️ eb280ac #2 2024-02-22 12:29:15 ~8 min ios 📱ipa 📲
✔️ eb280ac #2 2024-02-22 12:29:17 ~8 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3d58ca1 #3 2024-02-23 10:21:03 ~5 min tests 📄log
✔️ 3d58ca1 #3 2024-02-23 10:23:03 ~7 min ios 📱ipa 📲
✔️ 3d58ca1 #3 2024-02-23 10:23:10 ~7 min android-e2e 🤖apk 📲
✔️ 3d58ca1 #3 2024-02-23 10:23:13 ~7 min android 🤖apk 📲
✔️ e697290 #4 2024-02-28 12:36:33 ~6 min tests 📄log
✔️ e697290 #4 2024-02-28 12:37:10 ~7 min android-e2e 🤖apk 📲
✔️ e697290 #4 2024-02-28 12:38:10 ~8 min android 🤖apk 📲
✔️ e697290 #4 2024-02-28 12:39:33 ~9 min ios 📱ipa 📲

@ilmotta ilmotta force-pushed the fix/only-run-unit-tests branch 2 times, most recently from eb280ac to 3d58ca1 Compare February 23, 2024 10:14
@ilmotta ilmotta merged commit 61f8c51 into develop Feb 28, 2024
6 checks passed
@ilmotta ilmotta deleted the fix/only-run-unit-tests branch February 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants