chore(wallet): remove legacy network settings options #18955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Son89
commented
Feb 23, 2024
| @@ -443,9 +442,6 @@ | |||
| (= method "wallet_switchEthereumChain") | |||
| (eip3326/handle-switch-ethereum-chain cofx dapp-name id message-id (first params)) | |||
|
|
|||
| (= method "wallet_addEthereumChain") | |||
There was a problem hiding this comment.
removed this method - which I couldn't see how to access from "browser" but perhaps it's not?
There was a problem hiding this comment.
Possibly used by dApps in the old wallet.
There was a problem hiding this comment.
@pavloburykh, @qoqobolo - do you know if this is needed?
Also @smohamedjavid if our current wallet can't handle it then does this really matter?
we have also removed wallet connect - not sure if that effects this here but probably this won't work anyway 🤔
There was a problem hiding this comment.
I guess it's safe to remove it as we don't allow users to add any Ethereum chain at this moment (at least foreseeable future)👍
There was a problem hiding this comment.
@pavloburykh, @qoqobolo - do you know if this is needed?
@J-Son89 we do not know.
There was a problem hiding this comment.
@pavloburykh, @qoqobolo - do you know if this is needed?
@J-Son89 we are not aware of the use of this method, sorry.
I think it would be safer to check this with someone from the devs who implemented the old wallet
There was a problem hiding this comment.
Thanks, I think it's safe to remove for now
Jenkins BuildsClick to see older builds (12)
|
J-Son89
commented
Feb 23, 2024
| @@ -24,22 +23,6 @@ | |||
| (keep | |||
| identity | |||
| [{:size :small | |||
| :title (i18n/label :t/network) | |||
There was a problem hiding this comment.
removing network buttons
J-Son89
commented
Feb 23, 2024
| @@ -33,7 +33,6 @@ | |||
| "add-custom-token": "Add custom token", | |||
| "add-mailserver": "Add Status node", | |||
There was a problem hiding this comment.
verified and all of these removed translation strings are not used elsewhere 👍
J-Son89
requested review from
a team,
cammellos,
rasom,
flexsurfer,
VolodLytvynenko,
qoqobolo and
pavloburykh
smohamedjavid
approved these changes
Feb 23, 2024
| @@ -443,9 +442,6 @@ | |||
| (= method "wallet_switchEthereumChain") | |||
| (eip3326/handle-switch-ethereum-chain cofx dapp-name id message-id (first params)) | |||
|
|
|||
| (= method "wallet_addEthereumChain") | |||
There was a problem hiding this comment.
Possibly used by dApps in the old wallet.
OmarBasem
approved these changes
Feb 23, 2024
ulisesmac
approved these changes
Feb 26, 2024
vkjr
approved these changes
Feb 26, 2024
ulisesmac
approved these changes
Feb 26, 2024
8% of end-end tests have passedFailed tests (43)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
|
pavloburykh
force-pushed
the
jc/clean-wallet-options
branch
from
57cf08f
to
9463462
Compare
21% of end-end tests have passedFailed tests (37)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (10)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
|
|
@yevh-berdnyk could you please check latest e2e results in this PR? |
Just pushed a fix and restarting the tests. @J-Son89 please don't forget my commit when merging |
92% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
J-Son89
force-pushed
the
jc/clean-wallet-options
branch
from
4dc6e0b
to
e199174
Compare
|
@pavloburykh - rebase was straightforward so I think should be all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another piece of #18559
This pr removes the Legacy settings:
"Network" & "Network Info"
Before
After
These settings are no longer used in the wallet and instead we make use of "testnet mode" on the same page