Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/password input cursor is jumping when typing password fast #19029

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Bug/password input cursor is jumping when typing password fast #19029

merged 1 commit into from
Feb 28, 2024

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Feb 28, 2024 •
edited
Loading

fixes #19004

there is a bug on some Android devices, that when text input is re-rendered text is removed from the native component, so temporary solution is to use default value, i used atom so it won't trigger re-rendering

@flexsurfer flexsurfer self-assigned this Feb 28, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Feb 28, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ec1f5db #1 2024-02-28 09:14:26 ~5 min tests 📄log
✔️ ec1f5db #1 2024-02-28 09:16:45 ~7 min android-e2e 🤖apk 📲
✔️ ec1f5db #1 2024-02-28 09:16:46 ~7 min android 🤖apk 📲
✔️ ec1f5db #1 2024-02-28 09:19:07 ~10 min ios 📱ipa 📲
✔️ 02ac4c2 #2 2024-02-28 11:00:41 ~7 min android-e2e 🤖apk 📲
✔️ 02ac4c2 #2 2024-02-28 11:00:46 ~7 min tests 📄log
✔️ 02ac4c2 #2 2024-02-28 11:01:02 ~8 min android 🤖apk 📲
✔️ 02ac4c2 #2 2024-02-28 11:03:15 ~10 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 48
Failed tests: 5
Expected to fail tests: 1
Passed tests: 42

IDs of failed tests: 703133,702948,702745,703391,702786 

IDs of expected to fail tests: 703503

Failed tests (5)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]`
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1091: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not all channels are shown in community before joining: ['dogs', 'cats']



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:928: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Edited message is not shown correctly for the (receiver) admin



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    # STEP: Send messages with non-latin symbols
    Device 1: Find Button by accessibility id: jump-to 

    critical/chats/test_1_1_public_chats.py:278: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.home_1.jump_to_card_by_text(self.username_2)
../views/base_view.py:658: in jump_to_card_by_text
    self.click_on_floating_jump_to()
../views/base_view.py:647: in click_on_floating_jump_to
    self.jump_to_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Click system back button
    Device 2: Looking for a message by text: test image 

    critical/chats/test_1_1_public_chats.py:411: in test_1_1_chat_send_image_save_and_share
    self.chat_2.chat_element_by_text(image_description).wait_for_visibility_of_element(30)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'test image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Tap on found: Button
    Device 1: Wait for element Button for max 30s and click when it is available 

    critical/chats/test_public_chat_browsing.py:195: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.recover_access(passphrase=waku_user.seed, second_user=True)
../views/sign_in_view.py:278: in recover_access
    self.identifiers_button.wait_and_click(30)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Button by accessibility id:`skip-identifiers` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (42)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    3. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    @flexsurfer flexsurfer force-pushed the bug/Password_input_cursor_is_jumping_when_typing_password_fast_#19004 branch from ec1f5db to 02ac4c2 Compare February 28, 2024 10:52
    flexsurfer
    flexsurfer commented Feb 28, 2024
    View reviewed changes
    src/status_im/common/standard_authentication/password_input/view.cljs
    [:<>
    [rn/view {:style {:flex-direction :row}}
    [quo/input
    {:container-style {:flex 1}
    :type :password
    :default-value @default-value
    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    this is the only related change, other just slight adjusting according new UI guidelines

    @pavloburykh
    Copy link
    Contributor

    @flexsurfer thanx for the PR. Initial issue is fixed and works fine.
    But I noticed some unexpected behaviour of cursor in name input field (IOS only).

    ISSUE 1 Sometimes cursor jumps back when typing fast in the name input filed (IOS)

    reproducing on iPhone X, IOS 16.7.5

    Steps:

    1. Open onboarding Create profile screen
    2. Start typing name fast
    3. See cursor's behaviour

    Actual result: Sometimes cursor jumps back when typing name fast. Also sometimes cursor starts lagging when deleting inout value.

    telegram-cloud-document-2-5402504821787868734.mp4

    @flexsurfer
    Copy link
    Member Author

    most likely it was introduced not in this PR ,could you create a separate issue please?

    @pavloburykh
    Copy link
    Contributor

    most likely it was introduced not in this PR ,could you create a separate issue please?

    sorry, you are right. I have just checked in another rebased PR and was able to reproduce. This PR is ready for merge.

    @flexsurfer flexsurfer merged commit 26dd51c into develop Feb 28, 2024
    6 checks passed
    @flexsurfer flexsurfer deleted the bug/Password_input_cursor_is_jumping_when_typing_password_fast_#19004 branch February 28, 2024 14:23
    @qoqobolo qoqobolo mentioned this pull request Feb 29, 2024
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @siddarthkay siddarthkay siddarthkay approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @yqrashawn yqrashawn yqrashawn approved these changes

    @clauxx clauxx Awaiting requested review from clauxx

    Assignees

    @flexsurfer flexsurfer

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Password input cursor is jumping when typing password fast
    6 participants
    @flexsurfer @status-im-auto @pavloburykh @yqrashawn @Parveshdhull @siddarthkay