Fraschetti - Add wallet-get-address-details-contract-test #19340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (11)
|
|
My RPC Calls returns: |
| [result] | ||
| (is (contains? result :address)) | ||
| (is (contains? result :path)) | ||
| (is (true? (:hasActivity result))) |
There was a problem hiding this comment.
status-go doesn't actually check whether there is an activity in that address instead it checks whether it has any balance or not.
If the address (test.eth) depletes the balance, this test will fail.
I would suggest checking whether the key is present in the result or not.
OR we can check whether this value is boolean (using the boolean? method).
There was a problem hiding this comment.
Tks! I was not aware. Gonna do this change!
FFFra
force-pushed
the
fraschetti/18349-add-contract-test-for-rpc-endpoint-wallet_getaddressdetails
branch
from
b717f04
to
9690ba5
Compare
FFFra
force-pushed
the
fraschetti/18349-add-contract-test-for-rpc-endpoint-wallet_getaddressdetails
branch
2 times, most recently
from
bc04c33
to
a5611c2
Compare
FFFra
force-pushed
the
fraschetti/18349-add-contract-test-for-rpc-endpoint-wallet_getaddressdetails
branch
from
a5611c2
to
4572c17
Compare
FFFra
deleted the
fraschetti/18349-add-contract-test-for-rpc-endpoint-wallet_getaddressdetails
branch
mmilad75
pushed a commit
that referenced
this pull request
Apr 2, 2024
Introduces comprehensive tests for the wallet_getAddressDetails endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18349
Epic #18587
Summary
This pull request introduces comprehensive tests for the
wallet_getAddressDetailsendpoint, ensuring its robustness and reliability in our wallet functionality.Steps to test
run
make test-contractsstatus: ready!