Change password inside new settings #19474

clauxx · 2024-04-02T09:43:23Z

fixes #19111

Summary

Added the new change password screens according to the current designs (which might change as they're not final)
- some parts were taken from the status-im.contexts.onboarding.create-password.view ns
- didn't add the enable biometrics step
- didn't add illustrations as the desings are not done yet
Added the password-tips quo component

Review notes

Testing notes

Platforms

Android
iOS

Areas that maybe impacted

Functional

settings

Steps to test

Open Status
open settings
password
change-password

status: ready

status-im-auto · 2024-04-02T09:48:09Z

Jenkins Builds

Click to see older builds (86)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ad0a9b2`	#1	2024-04-02 09:48:08	~4 min	`tests`	📄`log`
✔️	`ad0a9b2`	#1	2024-04-02 09:50:03	~6 min	`android`	🤖`apk` 📲
✔️	`ad0a9b2`	#1	2024-04-02 09:51:12	~7 min	`android-e2e`	🤖`apk` 📲

✔️	`324249a`	#2	2024-04-02 09:59:37	~4 min	`tests`	📄`log`
✔️	`324249a`	#2	2024-04-02 10:02:26	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`324249a`	#2	2024-04-02 10:02:33	~7 min	`android`	🤖`apk` 📲
✔️	`324249a`	#2	2024-04-02 10:11:44	~16 min	`ios`	📱`ipa` 📲

✔️	`3623a07`	#3	2024-04-05 07:57:53	~4 min	`tests`	📄`log`
✔️	`3623a07`	#3	2024-04-05 08:01:30	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`3623a07`	#3	2024-04-05 08:01:32	~8 min	`android`	🤖`apk` 📲
✔️	`3623a07`	#3	2024-04-05 08:02:51	~9 min	`ios`	📱`ipa` 📲

❌	`b2e3fae`	#4	2024-04-08 12:52:15	~3 min	`tests`	📄`log`
✔️	`b2e3fae`	#4	2024-04-08 12:55:16	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b2e3fae`	#4	2024-04-08 12:55:22	~6 min	`android`	🤖`apk` 📲
❌	`b2e3fae`	#4	2024-04-08 12:58:50	~10 min	`ios`	📄`log`

❌	`76952ec`	#6	2024-04-08 13:06:44	~3 min	`tests`	📄`log`
✔️	`76952ec`	#6	2024-04-08 13:09:13	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`76952ec`	#6	2024-04-08 13:10:02	~6 min	`android`	🤖`apk` 📲
✔️	`76952ec`	#6	2024-04-08 13:12:46	~9 min	`ios`	📱`ipa` 📲

✔️	`a5c1f3e`	#7	2024-04-08 13:18:37	~4 min	`tests`	📄`log`
✔️	`a5c1f3e`	#7	2024-04-08 13:21:09	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`a5c1f3e`	#7	2024-04-08 13:21:18	~6 min	`android`	🤖`apk` 📲
✔️	`a5c1f3e`	#7	2024-04-08 13:23:11	~8 min	`ios`	📱`ipa` 📲

✔️	`078cf53`	#9	2024-04-10 15:11:26	~5 min	`tests`	📄`log`
✔️	`078cf53`	#9	2024-04-10 15:13:13	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`078cf53`	#9	2024-04-10 15:13:18	~7 min	`android`	🤖`apk` 📲
✔️	`078cf53`	#9	2024-04-10 15:29:49	~23 min	`ios`	📱`ipa` 📲

✔️	`aa5558f`	#10	2024-04-11 13:32:41	~4 min	`tests`	📄`log`
✔️	`aa5558f`	#10	2024-04-11 13:36:23	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`aa5558f`	#10	2024-04-11 13:36:27	~8 min	`android`	🤖`apk` 📲
✔️	`aa5558f`	#10	2024-04-11 13:36:39	~8 min	`ios`	📱`ipa` 📲

✔️	`814fe67`	#11	2024-04-12 11:03:34	~4 min	`tests`	📄`log`
✔️	`814fe67`	#11	2024-04-12 11:05:14	~5 min	`android`	🤖`apk` 📲
✔️	`814fe67`	#11	2024-04-12 11:06:11	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`814fe67`	#11	2024-04-12 11:08:47	~9 min	`ios`	📱`ipa` 📲

✔️	`d152b56`	#12	2024-04-15 09:32:53	~4 min	`tests`	📄`log`
✔️	`d152b56`	#12	2024-04-15 09:35:30	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`d152b56`	#12	2024-04-15 09:35:42	~7 min	`android`	🤖`apk` 📲
✔️	`d152b56`	#12	2024-04-15 09:39:20	~11 min	`ios`	📱`ipa` 📲

✔️	`8ae6b0a`	#14	2024-04-16 09:01:25	~4 min	`tests`	📄`log`
✔️	`8ae6b0a`	#15	2024-04-16 09:02:51	~5 min	`android`	🤖`apk` 📲
✔️	`8ae6b0a`	#15	2024-04-16 09:04:05	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`8ae6b0a`	#15	2024-04-16 09:06:27	~9 min	`ios`	📱`ipa` 📲

✔️	`a41e6c5`	#15	2024-04-16 11:34:45	~4 min	`tests`	📄`log`
✔️	`a41e6c5`	#16	2024-04-16 11:38:29	~8 min	`android`	🤖`apk` 📲
✔️	`a41e6c5`	#16	2024-04-16 11:38:31	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`a41e6c5`	#16	2024-04-16 11:40:17	~9 min	`ios`	📱`ipa` 📲

✔️	`c16a43f`	#18	2024-04-17 14:31:26	~7 min	`tests`	📄`log`
✔️	`c16a43f`	#19	2024-04-17 14:32:59	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`c16a43f`	#19	2024-04-17 14:34:39	~11 min	`android`	🤖`apk` 📲
✔️	`c16a43f`	#19	2024-04-17 14:37:16	~13 min	`ios`	📱`ipa` 📲

❌	`8500e41`	#19	2024-04-23 14:38:29	~2 min	`tests`	📄`log`
✔️	`8500e41`	#20	2024-04-23 14:43:19	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`8500e41`	#20	2024-04-23 14:43:20	~6 min	`android`	🤖`apk` 📲
✔️	`8500e41`	#20	2024-04-23 14:44:53	~8 min	`ios`	📱`ipa` 📲

❌	`5da204a`	#20	2024-04-24 07:06:37	~2 min	`tests`	📄`log`
✔️	`5da204a`	#21	2024-04-24 07:11:55	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`5da204a`	#21	2024-04-24 07:11:59	~7 min	`android`	🤖`apk` 📲
✔️	`5da204a`	#21	2024-04-24 07:13:14	~9 min	`ios`	📱`ipa` 📲

✔️	`8637029`	#21	2024-04-24 08:38:57	~4 min	`tests`	📄`log`
✔️	`8637029`	#22	2024-04-24 08:42:31	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`8637029`	#22	2024-04-24 08:42:42	~8 min	`android`	🤖`apk` 📲

✔️	`d424e37`	#22	2024-04-24 08:47:21	~4 min	`tests`	📄`log`
✔️	`d424e37`	#23	2024-04-24 08:51:12	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`d424e37`	#23	2024-04-24 08:51:13	~8 min	`android`	🤖`apk` 📲
✔️	`d424e37`	#23	2024-04-24 08:51:18	~8 min	`ios`	📱`ipa` 📲

✔️	`e1cfa46`	#23	2024-04-25 11:34:28	~4 min	`tests`	📄`log`
✔️	`e1cfa46`	#24	2024-04-25 11:38:01	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`e1cfa46`	#24	2024-04-25 11:39:09	~9 min	`android`	🤖`apk` 📲
✔️	`e1cfa46`	#24	2024-04-25 11:39:27	~9 min	`ios`	📱`ipa` 📲

✔️	`3341895`	#24	2024-04-30 06:38:34	~4 min	`tests`	📄`log`
✔️	`3341895`	#25	2024-04-30 06:42:13	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`3341895`	#25	2024-04-30 06:42:20	~8 min	`android`	🤖`apk` 📲
✔️	`3341895`	#25	2024-04-30 06:42:41	~8 min	`ios`	📱`ipa` 📲

✔️	`48bba4d`	#25	2024-04-30 08:44:58	~4 min	`tests`	📄`log`
✔️	`48bba4d`	#26	2024-04-30 08:48:46	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`48bba4d`	#26	2024-04-30 08:48:50	~8 min	`android`	🤖`apk` 📲
✔️	`48bba4d`	#26	2024-04-30 08:50:03	~9 min	`ios`	📱`ipa` 📲

✔️	`93e9eae`	#26	2024-05-06 12:30:07	~4 min	`tests`	📄`log`
✔️	`93e9eae`	#27	2024-05-06 12:33:57	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`93e9eae`	#27	2024-05-06 12:33:57	~8 min	`android`	🤖`apk` 📲
✔️	`93e9eae`	#27	2024-05-06 12:34:08	~8 min	`ios`	📱`ipa` 📲

✔️	`a73fa6b`	#27	2024-05-06 12:45:17	~4 min	`tests`	📄`log`
✔️	`a73fa6b`	#28	2024-05-06 12:48:03	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`a73fa6b`	#28	2024-05-06 12:49:31	~8 min	`ios`	📱`ipa` 📲
✔️	`a73fa6b`	#28	2024-05-06 12:49:43	~8 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`10fc3c5`	#29	2024-05-07 12:50:45	~4 min	`android`	📄`log`
❌	`10fc3c5`	#28	2024-05-07 12:53:26	~7 min	`tests`	📄`log`
✔️	`10fc3c5`	#29	2024-05-07 12:56:03	~9 min	`ios`	📱`ipa` 📲
✔️	`10fc3c5`	#29	2024-05-07 12:58:44	~12 min	`android-e2e`	🤖`apk` 📲

✔️	`d0dffd3`	#29	2024-05-07 14:22:50	~4 min	`tests`	📄`log`
✔️	`d0dffd3`	#30	2024-05-07 14:26:23	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`d0dffd3`	#30	2024-05-07 14:26:30	~8 min	`android`	🤖`apk` 📲
✔️	`d0dffd3`	#30	2024-05-07 14:30:00	~11 min	`ios`	📱`ipa` 📲

src/native_module/utils.cljs

src/status_im/contexts/preview/quo/password/password_tips.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/new_password_form.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/old_password_form.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/view.cljs

src/status_im/navigation/screens.cljs

clauxx · 2024-04-08T13:03:50Z

@cammellos addressed your comments in the last commit

seanstrom

Nice stuff 🙌
Left some small comments, I'll doing another pass soon 🙏

src/quo/components/password/password_tips/style.cljs~

src/quo/components/selectors/disclaimer/style.cljs

src/status_im/contexts/onboarding/create_password/view.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/new_password_form.cljs

src/native_module/utils.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/effects.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/events.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/loading.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/style.cljs

ilmotta

Hey @clauxx, I wasn't added as a reviewer, but I felt like sharing a few comments 😈

src/native_module/core.cljs

src/native_module/utils.cljs

src/status_im/contexts/preview/quo/password/password_tips.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/effects.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/new_password_form.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/effects.cljs

src/quo/components/selectors/disclaimer/view.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/loading.cljs

src/status_im/contexts/preview/quo/password/password_tips.cljs

src/status_im/contexts/profile/settings/screens/password/change_password/new_password_form.cljs

src/status_im/subs/settings.cljs

src/quo/components/selectors/disclaimer/view.cljs

…ssword status-im/status-go@b744ff4...cdac86f

…ssword

cammellos · 2024-04-30T08:38:24Z

@clauxx is this ready to be tested again?

clauxx · 2024-04-30T08:40:03Z

@cammellos @mariia-skrypnyk yes ready for testing

mariia-skrypnyk · 2024-04-30T10:19:41Z

Hi @clauxx !

As we keep our Test mode banner we still need to figure out how to deal with Continue and Confirm password buttons that are hidding behind the keyboard. Maybe @Parveshdhull can help with an idea?

This issue is not visible on my screenshots (security restriction) but I can show you it on video:

We have two places on iOS where buttons are hidden:

Continue button
Confirm password button

video_2024-04-30_12-02-28.mp4

video_2024-04-30_12-02-32.mp4

Android doesn't contain such issue as there is a scroll there and Continue and Confirm password buttons are visible by reducing visible part of red warning message.
Let me show you:

video_2024-04-30_12-15-57.mp4

ISSUE 7: Additional screens are blinking after logout

Steps

Login to app
Go to Profile -> Change Password
Go through steps till Logout

Actual result:

video_2024-04-30_12-16-02.mp4

Expected result: no such blinking screens

Parveshdhull · 2024-04-30T10:55:43Z

hi @clauxx this should fix issue 6.

status-mobile/src/status_im/contexts/profile/edit/bio/view.cljs

Line 45 in 8c26125

:keyboard-vertical-offset (if platform/ios? alert-banners-top-margin 0)

Parveshdhull · 2024-04-30T10:57:31Z

src/status_im/contexts/profile/settings/screens/password/change_password/view.cljs

+ :on-press navigate-back}]
+ [rn/keyboard-avoiding-view
+ {:style {:flex 1}
+ :keyboardVerticalOffset (- (safe-area/get-bottom))}


here, in ios also subtract alert-banners-top-margin, that should fix the issue.

cammellos · 2024-05-02T09:23:51Z

@mariia-skrypnyk issue 7 seems to be low-priority, would it be fine to address separately and merge it if that's the only issue left?

mariia-skrypnyk · 2024-05-06T10:27:55Z

@mariia-skrypnyk issue 7 seems to be low-priority, would it be fine to address separately and merge it if that's the only issue left?

Sure 🙌

clauxx · 2024-05-06T12:48:53Z

@mariia-skrypnyk @Parveshdhull @cammellos @J-Son89 I pushed a fix, but it's a bit annoying that we have to add such changes due to the alert banner alone. Also, among other issues, when building new features where the test-mode banner doesn't matter (e.g. here), we have to always keep it in mind and check if the UI is messed up since the banner is also disabled on debug builds by default. I remember there was a thread about the banner topic, but not sure if there was any resolution and hopefully we can get back to it soon and figure out a way that is less ... intrusive.

mariia-skrypnyk · 2024-05-07T08:44:38Z

Hi @clauxx !

Thanks for you effort in this PR!

I have one iOS issue. It is overlapping of validation message on my iOS 13 in case NO Testnet banner:

Am I right that the best decision here is scroll, yes?
It is a situation when keyboard is opened and second password field hides beside it.

IMG_9047.MP4

@clauxx I am going to check PR on iPhone SE and see no blockers to merge it after.
Above 1) issue I can create as followup if needed. Just let me know.

clauxx · 2024-05-07T08:46:39Z

Hi @clauxx !

Thanks for you effort in this PR!

I have one iOS issue. It is overlapping of validation message on my iOS 13 in case NO Testnet banner:

2. Am I right that the best decision here is scroll, yes? It is a situation when keyboard is opened and second password field hides beside it.
IMG_9047.MP4
@clauxx I am going to check PR on iPhone SE and see no blockers to merge it after. Above 1) issue I can create as followup if needed. Just let me know.

@mariia-skrypnyk Yeah might be better to handle this as a follow-up. Thank you :)

status-im-auto · 2024-05-07T12:18:02Z

81% of end-end tests have passed

Total executed tests: 52
Failed tests: 8
Expected to fail tests: 2
Passed tests: 42

IDs of failed tests: 727230,704613,727231,702894,727229,702807,727232,702775

IDs of expected to fail tests: 703495,703503

Failed tests (8)

Click to expand

Rerun failed tests

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device 1: Find `Button` by `accessibility id`: `account-emoji` Device 1: Find `Button` by `accessibility id`: `share-account` critical/test_wallet.py:152: in test_wallet_add_remove_regular_account self.wallet_view.share_address_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `share-account` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs
2. test_wallet_add_remove_watch_only_account, id: 727232
# STEP: Adding new watch only account Device 1: Find `Button` by `accessibility id`: `add-account` critical/test_wallet.py:190: in test_wallet_add_remove_watch_only_account self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name) ../views/wallet_view.py:117: in add_watch_only_account self.add_account_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `add-account` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device 1: Find `Button` by `xpath`: `//*[@text="open community"]` Device 1: Tap on found: Button `critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE` Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device 1: Find `BrowserTab` by `accessibility id`: `browser-stack-tab` Device 1: Tap on found: BrowserTab critical/test_deep_and_universal_links.py:114: in test_links_deep_links self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE E Community 'Closed community' was not requested to join by the deep link status.app://c/GzAAAORtwyW4xNWM4td0F7hOnYZ1apSqCCRUUR0qxD19n3Ec97fX_aIVIGFWbdUM#zQ3shk6dgK8dYWWSC4m8Jj5c91zyfhfj1fFkgypS8D9gsXkrK Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894

Device 2: Find Button by accessibility id: open-activity-center-button
Device 2: Accepting incoming CR for user_1

critical/chats/test_public_chat_browsing.py:716: in test_community_contact_block_unblock_offline
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:422: in handle_contact_request
    self.close_activity_centre.wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`close-activity-center` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
# STEP: Getting ETH amount in the wallet of the sender before transaction Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab` critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:39: in _get_balances_before_tx self.wallet_1.wallet_tab.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_send_eth, id: 727229
Device 1: Swiping right on element SlideButton Device 1: Find `SlideButton` by `xpath`: `//[@resource-id='slide-button-track']` critical/test_wallet.py:109: in test_wallet_send_eth self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send) ../views/wallet_view.py:99: in send_asset self.confirm_transaction() ../views/wallet_view.py:86: in confirm_transaction self.slide_and_confirm_with_password() ../views/wallet_view.py:80: in slide_and_confirm_with_password self.slide_button_track.slide() ../views/base_view.py:257: in slide self.swipe_right_on_element(width_percentage=1.3, start_x=100) ../views/base_element.py:308: in swipe_right_on_element location, size = self.get_element_coordinates() ../views/base_element.py:294: in get_element_coordinates element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: SlideButton by xpath: `//[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807

Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
Device 2: Text is Sent

critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

Expected to fail tests (2)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
# STEP: Change device time so chat will be unmuted by timer Device 2: Long press on `ChatElement` `critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat is still muted after timeout` [[Chat is not unmuted after expected time: https://github.com//issues/19627]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Passed tests (42)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2024-05-07T12:42:57Z

Hi @clauxx !

Checked on iPhone SE, found minor issue, will add to follow up.

Failed tests are not related, please merge!

clauxx requested review from cammellos, Parveshdhull, J-Son89 and BalogunofAfrica April 2, 2024 09:43

clauxx self-assigned this Apr 2, 2024

clauxx commented Apr 2, 2024

View reviewed changes

src/native_module/utils.cljs Outdated Show resolved Hide resolved

clauxx requested a review from a team April 5, 2024 07:52

cammellos reviewed Apr 5, 2024

View reviewed changes

clauxx requested review from seanstrom and ibrkhalil April 8, 2024 12:58

clauxx force-pushed the cl-19111-change-password branch 2 times, most recently from e4da076 to 76952ec Compare April 8, 2024 13:03

clauxx requested a review from cammellos April 8, 2024 13:03

clauxx force-pushed the cl-19111-change-password branch from 76952ec to a5c1f3e Compare April 8, 2024 13:14

seanstrom reviewed Apr 9, 2024

View reviewed changes

ilmotta reviewed Apr 9, 2024

View reviewed changes

vkjr reviewed Apr 9, 2024

View reviewed changes

src/quo/components/selectors/disclaimer/view.cljs Outdated Show resolved Hide resolved

vkjr reviewed Apr 9, 2024

View reviewed changes

src/status_im/contexts/profile/settings/screens/password/change_password/loading.cljs Outdated Show resolved Hide resolved

vkjr reviewed Apr 9, 2024

View reviewed changes

src/status_im/contexts/preview/quo/password/password_tips.cljs Outdated Show resolved Hide resolved

vkjr reviewed Apr 9, 2024

View reviewed changes

src/status_im/contexts/profile/settings/screens/password/change_password/new_password_form.cljs Show resolved Hide resolved

flexsurfer reviewed Apr 10, 2024

View reviewed changes

src/status_im/subs/settings.cljs Show resolved Hide resolved

src/quo/components/selectors/disclaimer/view.cljs Outdated Show resolved Hide resolved

clauxx force-pushed the cl-19111-change-password branch 2 times, most recently from a14e999 to 078cf53 Compare April 10, 2024 15:05

clauxx requested review from ilmotta, seanstrom and vkjr April 10, 2024 15:06

vkjr approved these changes Apr 10, 2024

View reviewed changes

clauxx added 4 commits April 23, 2024 16:35

Merge remote-tracking branch 'origin/develop' into cl-19111-change-pa…

8500e41

…ssword status-im/status-go@b744ff4...cdac86f

Merge remote-tracking branch 'origin/develop' into cl-19111-change-pa…

5da204a

…ssword

fix: use-theme usage

8637029

Merge branch 'develop' into cl-19111-change-password

d424e37

mariia-skrypnyk mentioned this pull request Apr 24, 2024

Disabling Testnet alert banner #19762

Closed

clauxx added 2 commits April 25, 2024 13:29

Merge branch 'develop' into cl-19111-change-password

e1cfa46

Merge branch 'develop' into cl-19111-change-password

3341895

Merge branch 'develop' into cl-19111-change-password

48bba4d

Parveshdhull reviewed Apr 30, 2024

View reviewed changes

clauxx added 2 commits May 6, 2024 15:25

Merge branch 'develop' into cl-19111-change-password

93e9eae

fix: button alignment due to alert banner

a73fa6b

mariia-skrypnyk added Tested - OK and removed Tested - Issues labels May 7, 2024

clauxx added 2 commits May 7, 2024 15:45

Merge branch 'develop' into cl-19111-change-password

10fc3c5

Merge branch 'develop' into cl-19111-change-password

d0dffd3

clauxx merged commit 161ba27 into develop May 7, 2024
6 checks passed

clauxx deleted the cl-19111-change-password branch May 7, 2024 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change password inside new settings #19474

Change password inside new settings #19474

clauxx commented Apr 2, 2024 •

edited

Loading

status-im-auto commented Apr 2, 2024 •

edited

Loading

clauxx commented Apr 8, 2024

seanstrom left a comment

ilmotta left a comment

cammellos commented Apr 30, 2024

clauxx commented Apr 30, 2024

mariia-skrypnyk commented Apr 30, 2024 •

edited

Loading

Parveshdhull commented Apr 30, 2024

Parveshdhull Apr 30, 2024

cammellos commented May 2, 2024

mariia-skrypnyk commented May 6, 2024

clauxx commented May 6, 2024

mariia-skrypnyk commented May 7, 2024

clauxx commented May 7, 2024 •

edited

Loading

status-im-auto commented May 7, 2024

Class TestWalletOneDevice:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletMultipleDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePR:

mariia-skrypnyk commented May 7, 2024

Change password inside new settings #19474

Change password inside new settings #19474

Conversation

clauxx commented Apr 2, 2024 • edited Loading

Summary

Review notes

Testing notes

Platforms

Areas that maybe impacted

Functional

Steps to test

status-im-auto commented Apr 2, 2024 • edited Loading

Jenkins Builds

clauxx commented Apr 8, 2024

seanstrom left a comment

Choose a reason for hiding this comment

ilmotta left a comment

Choose a reason for hiding this comment

cammellos commented Apr 30, 2024

clauxx commented Apr 30, 2024

mariia-skrypnyk commented Apr 30, 2024 • edited Loading

Parveshdhull commented Apr 30, 2024

Parveshdhull Apr 30, 2024

Choose a reason for hiding this comment

cammellos commented May 2, 2024

mariia-skrypnyk commented May 6, 2024

clauxx commented May 6, 2024

mariia-skrypnyk commented May 7, 2024

clauxx commented May 7, 2024 • edited Loading

status-im-auto commented May 7, 2024

81% of end-end tests have passed

Failed tests (8)

Class TestWalletOneDevice:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletMultipleDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Expected to fail tests (2)

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (42)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePR:

mariia-skrypnyk commented May 7, 2024

clauxx commented Apr 2, 2024 •

edited

Loading

status-im-auto commented Apr 2, 2024 •

edited

Loading

mariia-skrypnyk commented Apr 30, 2024 •

edited

Loading

clauxx commented May 7, 2024 •

edited

Loading